Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11.8.0 proposal #25687

Merged
merged 88 commits into from
Jan 25, 2019
Merged
Changes from 1 commit
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
817b44d
test: refactor pummel/test-keep-alive
Trott Jan 14, 2019
69c0841
test: refactor pummel/test-net-connect-econnrefused
Trott Jan 14, 2019
307da2d
test: refactor pummel/test-net-many-clients
Trott Jan 14, 2019
6347940
test: refactor pummel/test-net-pingpong
Trott Jan 14, 2019
7ffa8ec
src: reset `StopTracingAgent()` before platform teardown
addaleax Jan 12, 2019
0897504
src: call `Environment::Exit()` for fatal exceptions
addaleax Jan 12, 2019
47d040d
build: introduce --openssl-is-fips flag
danbev Jan 9, 2019
03e05cb
src: fix FIPS section in Sign::SignFinal
danbev Jan 9, 2019
26c5bd8
doc: add metadata about ecdh curve options
sam-github Jan 14, 2019
ab86143
test: fix test-repl timeout and tmpdir refresh
mscdex Jan 9, 2019
07f1bb0
process: allow reading umask in workers
cjihrig Jan 15, 2019
4170230
doc: add Rich back to TSC list
mhdawson Jan 16, 2019
779ce29
test: add check for wrk to test-keep-alive
Trott Jan 15, 2019
35240ca
test: refactor min() in test-hash-seed
Trott Jan 15, 2019
cfcb759
test: prepare test-hash-seed for CI
Trott Jan 15, 2019
688fb8d
doc: fix typo in Buffer API
H1Gdev Jan 17, 2019
4c207d9
test: do not use uninitialized memory in common flags check
addaleax Jan 13, 2019
338f456
util: fix iterable types with special prototype
BridgeAR Jan 11, 2019
4e52b07
test: use fipsMode instead of common.hasFipsCrypto
danbev Jan 15, 2019
bb7f71a
crypto: fix key handle extraction
tniessen Jan 18, 2019
2112b70
test: improve code coverage for i18n
mhdawson Jan 10, 2019
b8d780c
test: ensure npm version is not release candidate
MylesBorins Jan 16, 2019
10bff7a
doc: add a note to `buf.fill()` description
vsemozhetbyt Jan 17, 2019
faa1776
test: relax chunk count expectations
gireeshpunathil Jan 9, 2019
58952a1
tls: make tls.connect() accept a timeout option
lpinca Jan 15, 2019
0c046e8
doc: correct my wrong note about buf.fill()
vsemozhetbyt Jan 19, 2019
e55c5c3
http: reuse noop function in socketOnError()
cjihrig Jan 18, 2019
c5d89e6
doc: reword stream docs to clarify that decodeStrings encodes strings
dgholz Jan 12, 2019
d9da4af
tools: update ESLint to 5.12.1
cjihrig Jan 18, 2019
3dcdf27
test: change ciphers from RC4 to no-such-cipher
danbev Jan 16, 2019
efe089e
test: use stronger curves for keygen
danbev Jan 16, 2019
291cedf
src: reduce includes of node_internals.h
joyeecheung Jan 13, 2019
5684da5
test: changed function to arrow function
Jan 11, 2019
92dd899
process: check env->EmitProcessEnvWarning() last
bcoe Jan 21, 2019
1cbadd8
tools: improve valgrind support
addaleax Dec 30, 2018
c3409f5
tls: do not free cert in `.getCertificate()`
addaleax Jan 14, 2019
65478fa
doc: hyperlink reference to process.nextTick
sam-github Jan 21, 2019
d6b50c6
http: make ClientRequest#setTimeout() noop at end
timdp Jan 16, 2019
aa9a86a
test,worker: verify that `.terminate()` breaks microtask queue
addaleax Jan 13, 2019
28894af
build: do not lint python scripts under test/fixtures
joyeecheung Jan 22, 2019
8cc936a
build: remove erroneous duplicate declaration from node_inspector.gypi
refack Jan 19, 2019
d9a8113
src: pass along errors from `--security-reverts`
addaleax Jan 12, 2019
6881454
test: replace common.PORT with `0` in https renegotiation test
Trott Jan 21, 2019
55768c0
src: restrict unloading addons to Worker threads
addaleax Jan 18, 2019
b2834ce
process: fix call process.reallyExit, vs., binding
bcoe Jan 23, 2019
34da9a3
build: make install.py python 3 compatiable
thefourtheye Jan 19, 2019
5a0332e
test: remove potential race condition in https renegotiation test
Trott Jan 21, 2019
ecd358b
test: revoke flaky designation for tests
gireeshpunathil Jan 21, 2019
647a37f
process: clarify the pre- and post-condition of esm setup
joyeecheung Jan 13, 2019
3c661f0
console: refactor inspector console extension installation
joyeecheung Jan 15, 2019
9a410a1
http2: allow fully synchronous `_final()`
addaleax Jan 21, 2019
593714e
events: show inspected error in uncaught 'error' message
addaleax Jan 21, 2019
7490fc8
test: switch to native v8 coverage
bcoe Jan 18, 2019
eac438a
doc: running coverage for individual suites
bcoe Jan 22, 2019
da8c526
policy: manifest with subresource integrity checks
bmeck Sep 13, 2018
219b1b8
worker: enable passing command line flags
yaelhe Jan 4, 2019
549216a
src: merge into core
gireeshpunathil Sep 5, 2018
4f38106
doc: add node-report documentation
vipinmenon Sep 5, 2018
0800f91
test: add node-report tests
LakshmiSwethaG Sep 5, 2018
8f42c9e
src: silence compiler warning in node_report.cc
danbev Jan 18, 2019
c0859d7
deps: upgrade to libuv 1.25.0
cjihrig Jan 18, 2019
dbecc82
src: remove outdated `Neuter()` call in `node_buffer.cc`
addaleax Jan 13, 2019
5440f9d
doc: use correct placeholder for policy docs
addaleax Jan 21, 2019
2b18582
n-api: mark thread-safe function as stable
Jan 18, 2019
42bbe58
report: remove unnecessary intermediate variable
cjihrig Jan 20, 2019
213eddd
report: remove unnecessary includes
cjihrig Jan 20, 2019
c598d98
report: use uv_pid_t instead of custom PID_TYPE
cjihrig Jan 20, 2019
a02b621
report: simplify option checking
cjihrig Jan 20, 2019
0f91e03
report: simplify rlimit to JSON logic
cjihrig Jan 20, 2019
f688e73
n-api: change #ifdef to #if in node_api_types
danbev Jan 22, 2019
0ebe6eb
os: implement os.release() using uv_os_uname()
cjihrig Jan 21, 2019
4031b5c
report: remove `InitializeReport()`
addaleax Jan 21, 2019
5fab92c
build: remove AIX/ppc (32bit) dead code
refack Jan 15, 2019
90a64ab
test: add stdio checks to cp-exec-maxBuffer
Fishrock123 Dec 11, 2018
ac5fa2c
child_process: truncate output when maxBuffer is exceeded
Fishrock123 Dec 11, 2018
f415069
crypto: add crypto modules to cannotUseCache
danbev Jan 21, 2019
c59edca
src: remove using v8::Function in node_os.cc
cjihrig Jan 21, 2019
572a70f
test: pull html/webappapis/microtask-queuing WPT
joyeecheung Jan 21, 2019
74ee8d3
test: run html/webappapis/microtask-queuing WPT
joyeecheung Jan 21, 2019
08ade9b
test: clarify the path relativeness of WPT runner classes
joyeecheung Jan 21, 2019
a9ffce9
test: fix pummel/test-exec
Trott Jan 24, 2019
9d8a225
doc: add note regarding pushing release tags
MylesBorins Jan 18, 2019
64959b6
report: remove `internalBinding('config').hasReport`
addaleax Jan 21, 2019
a161a9b
src: remove unnecessary `filename` variable
addaleax Jan 21, 2019
07a0dc8
report: roll extra loop iteration in `PrintNativeStack()`
addaleax Jan 21, 2019
03ba344
report: downgrade reinterpret_cast to static_cast
addaleax Jan 21, 2019
f3d0591
report: use `uv_handle_type_name()` to get handle type
addaleax Jan 21, 2019
11ee794
2019-01-24, Version 11.8.0 (Current)
MylesBorins Jan 24, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
n-api: change #ifdef to #if in node_api_types
Currently, there are a number of compiler warnings like the following:
In file included from ../src/node_api.h:11:
../src/node_api_types.h:13:21:x
 warning: extra tokens at end of #ifdef directive [-Wextra-tokens]
 #ifdef NAPI_VERSION >= 4

This commit changes the #ifdef macros to #if.

PR-URL: #25635
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
danbev authored and targos committed Jan 24, 2019
commit f688e739840d221fbba0d702bfd6ba1ade9cefd9
4 changes: 2 additions & 2 deletions src/node_api_types.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ typedef struct napi_async_work__* napi_async_work;
typedef struct napi_threadsafe_function__* napi_threadsafe_function;
#endif // NAPI_VERSION >= 4

#ifdef NAPI_VERSION >= 4
#if NAPI_VERSION >= 4
typedef enum {
napi_tsfn_release,
napi_tsfn_abort
Expand All @@ -27,7 +27,7 @@ typedef void (*napi_async_execute_callback)(napi_env env,
typedef void (*napi_async_complete_callback)(napi_env env,
napi_status status,
void* data);
#ifdef NAPI_VERSION >= 4
#if NAPI_VERSION >= 4
typedef void (*napi_threadsafe_function_call_js)(napi_env env,
napi_value js_callback,
void* context,
Expand Down