src: remove unimplemented method in node_http2.h #25732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
gengjiawen
force-pushed
the
cleanup_class_Http2Session
branch
from
ca15e99
to
e15606b
Compare
jasnell
approved these changes
Jan 28, 2019
cjihrig
approved these changes
Jan 28, 2019
|
@danbev can you import this change ? thanks. |
|
Re-run of CI: https://ci.nodejs.org/job/node-test-pull-request/20559/ (✔️) |
|
Commit message: |
Signed-off-by: gengjiawen <technicalcute@gmail.com>
gengjiawen
force-pushed
the
cleanup_class_Http2Session
branch
from
e15606b
to
e3e9d40
Compare
gengjiawen
changed the title
|
@targos Fixed. Thanks. |
|
Landed in c6ecbd3. |
danbev
pushed a commit
that referenced
this pull request
Feb 4, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes