Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unimplemented method in node_http2.h #25732

Closed
wants to merge 1 commit into from
Closed

src: remove unimplemented method in node_http2.h #25732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/node_http2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,12 +696,9 @@ class Http2Session : public AsyncWrap, public StreamListener {
return static_cast<StreamBase*>(stream_);
}

void Start();
void Stop();
void Close(uint32_t code = NGHTTP2_NO_ERROR,
bool socket_closed = false);
void Consume(Local<External> external);
void Unconsume();
void Goaway(uint32_t code, int32_t lastStreamID, uint8_t* data, size_t len);
void AltSvc(int32_t id,
uint8_t* origin,
Expand All @@ -710,9 +707,6 @@ class Http2Session : public AsyncWrap, public StreamListener {
size_t value_len);
void Origin(nghttp2_origin_entry* ov, size_t count);


bool Ping(v8::Local<v8::Function> function);

uint8_t SendPendingData();

// Submits a new request. If the request is a success, assigned
Expand Down Expand Up @@ -795,8 +789,6 @@ class Http2Session : public AsyncWrap, public StreamListener {
// The JavaScript API
static void New(const FunctionCallbackInfo<Value>& args);
static void Consume(const FunctionCallbackInfo<Value>& args);
static void Unconsume(const FunctionCallbackInfo<Value>& args);
static void Destroying(const FunctionCallbackInfo<Value>& args);
static void Destroy(const FunctionCallbackInfo<Value>& args);
static void Settings(const FunctionCallbackInfo<Value>& args);
static void Request(const FunctionCallbackInfo<Value>& args);
Expand All @@ -811,9 +803,6 @@ class Http2Session : public AsyncWrap, public StreamListener {
template <get_setting fn>
static void RefreshSettings(const FunctionCallbackInfo<Value>& args);

template <get_setting fn>
static void GetSettings(const FunctionCallbackInfo<Value>& args);

uv_loop_t* event_loop() const {
return env()->event_loop();
}
Expand Down