v6.17.1 proposal #26684

BethGriggs · 2019-03-15T15:02:18Z

2019-04-02, Version 6.17.1'Boron' (LTS), @BethGriggs

Node 6 is due to go End-of-Life on 2019-04-30.

Notable Changes

http:
- fix error check in Execute() (Brian White) #25939

Commits

[c9d21a0c10] - build: set -blibpath: for AIX (Richard Lau) #25447
[9ba5fd6bad] - build: only check REPLACEME & DEP...X for releases (Rod Vagg) #24575
[1371a6f88b] - doc: simplify CODE_OF_CONDUCT.md (Rich Trott) #23989
[ad62971573] - doc: document that addMembership must be called once in a cluster (James M Snell) #23746
[8080a9bf40] - http: fix error check in Execute() (Brian White) #25939
[aedc7120ea] - src: fix bootstrap_node on bsd (sylkat) #22663
[b5d464955a] - test: fix test-repl-envvars (Anna Henningsen) #25226

This is the last planned release for Node 6.

Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>

Fixes: #12572 Refs: #16240 PR-URL: #23746 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #23989 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #24575 Refs: #24551 Refs: #12958 Refs: #12957 Refs: #8325 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

In 180f865, the test was changed so that the `env` argument of `createInternalRepl()` also contained external environment variables, because keeping them can be necessary for spawning processes on some systems. However, this test does not spawn new processes, and relies on the fact that the environment variables it tests are not already set (and fails otherwise); therefore, reverting to the original state should fix this. Fixes: #21451 Fixes: nodejs/build#1377 Refs: #25219 PR-URL: #25226 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Refs: #24738 Fixes: #25858 PR-URL: #25939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

#17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: #25444 Backport-PR-URL: #26478 PR-URL: #25447 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs-github-bot · 2019-03-15T15:02:21Z

@BethGriggs build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2922/pipeline

doc/changelogs/CHANGELOG_V6.md

refack · 2019-03-15T15:41:17Z

Running CI test preemptively: https://ci.nodejs.org/job/node-test-pull-request/21566/ to make sure the CI infra is still compatible with v6

BridgeAR

LGTM. Just the notable change in the release commit message should be reformatted for plain-text.

BethGriggs · 2019-03-27T11:12:58Z

There's just one open PR for v6.x that would be good to get into this release

[v6.x backport] src: add environment cleanup hooks #22633 (/cc @gabrielschulhof)

nodejs-github-bot · 2019-04-02T10:09:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22119/

BethGriggs · 2019-04-02T10:31:12Z

CITGM against v6.x: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1792/
CITGM on v6.17.1: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1793

BethGriggs · 2019-04-02T10:59:12Z

Seeing addons failures on Windows on the latest CI (https://ci.nodejs.org/job/node-test-binary-windows-2/53/), I'm assuming it is the same issue as @richardlau mentioned in nodejs/reliability#22 (comment)
/cc @nodejs/build

refack · 2019-04-02T12:05:42Z

Seeing addons failures on Windows on the latest CI

It's my fault. I'm on it.

nodejs-github-bot · 2019-04-02T12:10:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22121/

Failed https://ci.nodejs.org/job/node-test-binary-windows/25039/COMPILED_BY=vs2015,RUNNER=win2008r2-vs2013,RUN_SUBSET=2/

nodejs-github-bot · 2019-04-02T13:05:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22123/

Failed with:

09:19:48 not ok 365 sequential/test-child-process-pass-fd
09:19:48   ---
09:19:48   duration_ms: 66.383
09:19:48   severity: fail
09:19:48   stack: |-
09:19:48     timeout
09:19:48   ...

https://ci.nodejs.org/job/node-test-binary-windows/25041/COMPILED_BY=vs2015,RUNNER=win2008r2-vs2013,RUN_SUBSET=2/

nodejs-github-bot · 2019-04-02T13:51:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22126/

Failed:
https://ci.nodejs.org/job/node-test-binary-windows/25043/COMPILED_BY=vs2015,RUNNER=win2008r2-vs2013,RUN_SUBSET=2

BethGriggs · 2019-04-02T21:01:02Z

Still trying to work out where the sequential/test-child-process-pass-fd failure on one Windows distribution is coming from 🤔 It seems to also be failing on v6.x - (https://ci.nodejs.org/job/node-test-commit/27415/)

refack · 2019-04-02T22:11:11Z

So it seems like the issue is related to this OS issue (it causes node to start slow and hog 100% cpu for ~1 second). This specific test creates 80 sub-processes in a tight loop, and it just times out at 60 seconds (when it needs ~77).

I'm cleaning the update cache on https://ci.nodejs.org/computer/test-azure_msft-win2008r2-x64-1/ to see if that solves the issue.

nodejs-github-bot · 2019-04-02T22:39:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22135/ ✅

Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684

PR-URL: #26684

Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684

Refs: nodejs/node#26684

Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684

sylkat and others added 7 commits March 7, 2019 11:26

src: fix bootstrap_node on bsd

aedc712

Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>

doc: document that addMembership must be called once in a cluster

ad62971

Fixes: #12572 Refs: #16240 PR-URL: #23746 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

build: only check REPLACEME & DEP...X for releases

9ba5fd6

PR-URL: #24575 Refs: #24551 Refs: #12958 Refs: #12957 Refs: #8325 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

http: fix error check in Execute()

8080a9b

Refs: #24738 Fixes: #25858 PR-URL: #25939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v6.x labels Mar 15, 2019

richardlau reviewed Mar 15, 2019

View reviewed changes

doc/changelogs/CHANGELOG_V6.md Outdated Show resolved Hide resolved

BethGriggs force-pushed the v6.17.1-proposal branch from 83598c4 to 8051716 Compare March 15, 2019 16:10

richardlau mentioned this pull request Mar 17, 2019

tools: remove eslint rule no-let-in-for-declaration #26715

Closed

2 tasks

BethGriggs force-pushed the v6.17.1-proposal branch from 8051716 to f34c917 Compare March 19, 2019 16:23

BridgeAR approved these changes Mar 25, 2019

View reviewed changes

BethGriggs force-pushed the v6.17.1-proposal branch from f34c917 to 4fd8cd3 Compare April 2, 2019 10:09

richardlau mentioned this pull request Apr 2, 2019

CI failures: 20190330-20190402 nodejs/reliability#22

Closed

refack added the windows Issues and PRs related to the Windows platform. label Apr 2, 2019

BethGriggs force-pushed the v6.17.1-proposal branch from 4fd8cd3 to 94b3b03 Compare April 3, 2019 11:40

BethGriggs added a commit that referenced this pull request Apr 3, 2019

2019-04-03, Version 6.17.1 'Boron' (LTS)

94b3b03

Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684

2019-04-03, Version 6.17.1 'Boron' (LTS)

576c2bf

Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684

BethGriggs force-pushed the v6.17.1-proposal branch from 94b3b03 to 576c2bf Compare April 3, 2019 14:45

BethGriggs merged commit 576c2bf into v6.x Apr 3, 2019

BethGriggs added a commit that referenced this pull request Apr 3, 2019

Working on v6.17.2

f223bba

PR-URL: #26684

BethGriggs added a commit that referenced this pull request Apr 3, 2019

2019-04-03, Version 6.17.1 'Boron' (LTS)

883a0d5

Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Apr 3, 2019

Blog: v6.17.1 release post

2e708ed

Refs: nodejs/node#26684

BethGriggs mentioned this pull request Apr 3, 2019

Blog: v6.17.1 release post nodejs/nodejs.org#2168

Merged

BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Apr 3, 2019

Blog: v6.17.1 release post (#2168)

0d17c5f

Refs: nodejs/node#26684

BethGriggs added a commit that referenced this pull request Apr 4, 2019

2019-04-03, Version 6.17.1 'Boron' (LTS)

4005f22

Notable changes: - http: - fix error check in `Execute()` (Brian White) [#25939](#25939) PR-URL: #26684

targos deleted the v6.17.1-proposal branch June 4, 2019 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v6.17.1 proposal #26684

v6.17.1 proposal #26684

BethGriggs commented Mar 15, 2019 •

edited

Loading

nodejs-github-bot commented Mar 15, 2019

refack commented Mar 15, 2019

BridgeAR left a comment

BethGriggs commented Mar 27, 2019

nodejs-github-bot commented Apr 2, 2019

BethGriggs commented Apr 2, 2019 •

edited

Loading

BethGriggs commented Apr 2, 2019

refack commented Apr 2, 2019

nodejs-github-bot commented Apr 2, 2019 •

edited by refack

Loading

nodejs-github-bot commented Apr 2, 2019 •

edited by refack

Loading

nodejs-github-bot commented Apr 2, 2019 •

edited by refack

Loading

BethGriggs commented Apr 2, 2019

refack commented Apr 2, 2019

nodejs-github-bot commented Apr 2, 2019 •

edited by BethGriggs

Loading

v6.17.1 proposal #26684

v6.17.1 proposal #26684

Conversation

BethGriggs commented Mar 15, 2019 • edited Loading

2019-04-02, Version 6.17.1'Boron' (LTS), @BethGriggs

Notable Changes

Commits

nodejs-github-bot commented Mar 15, 2019

refack commented Mar 15, 2019

BridgeAR left a comment

Choose a reason for hiding this comment

BethGriggs commented Mar 27, 2019

nodejs-github-bot commented Apr 2, 2019

BethGriggs commented Apr 2, 2019 • edited Loading

BethGriggs commented Apr 2, 2019

refack commented Apr 2, 2019

nodejs-github-bot commented Apr 2, 2019 • edited by refack Loading

nodejs-github-bot commented Apr 2, 2019 • edited by refack Loading

nodejs-github-bot commented Apr 2, 2019 • edited by refack Loading

BethGriggs commented Apr 2, 2019

refack commented Apr 2, 2019

nodejs-github-bot commented Apr 2, 2019 • edited by BethGriggs Loading

BethGriggs commented Mar 15, 2019 •

edited

Loading

BethGriggs commented Apr 2, 2019 •

edited

Loading

nodejs-github-bot commented Apr 2, 2019 •

edited by refack

Loading

nodejs-github-bot commented Apr 2, 2019 •

edited by refack

Loading

nodejs-github-bot commented Apr 2, 2019 •

edited by refack

Loading

nodejs-github-bot commented Apr 2, 2019 •

edited by BethGriggs

Loading