Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove eslint rule no-let-in-for-declaration #26715

Closed
wants to merge 1 commit into from
Closed

tools: remove eslint rule no-let-in-for-declaration #26715

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

In continue our discussion in #26562 (comment)

cc @targos @ZYSzys @Trott @BridgeAR

Maybe still add a label don't land on 6.x though the last 6.x release has been drafted.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 17, 2019
richardlau
richardlau requested changes Mar 17, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove

node/lib/.eslintrc.yaml

Line 20 in 32853c0

node-core/no-let-in-for-declaration: error

@gengjiawen
Copy link
Member Author

Please also remove

node/lib/.eslintrc.yaml

Line 20 in 32853c0

node-core/no-let-in-for-declaration: error

Fixed.

@richardlau
Copy link
Member

I'm happy for this to land before Node.js 6 goes End-of-Life at the end of April as #26684 is the last planned release and nothing is landing there without a good deal of caution.

@gengjiawen
Copy link
Member Author

I'm happy for this to land before Node.js 6 goes End-of-Life at the end of April as #26684 is the last planned release and nothing is landing there without a good deal of caution.

I am happy that we can use native async await in community libs as node 6 reaches EOL :)

@danbev
Copy link
Contributor

danbev commented Mar 20, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21682/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21887/

@gengjiawen
Copy link
Member Author

@danbev Can you import this ? Thanks.

Trott pushed a commit to Trott/io.js that referenced this pull request Mar 26, 2019
@gengjiawen @Trott
tools: remove eslint rule no-let-in-for-declaration
8209cae 
PR-URL: nodejs#26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member

Trott commented Mar 26, 2019

Landed in 8209cae

@Trott Trott closed this Mar 26, 2019
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@gengjiawen @targos
tools: remove eslint rule no-let-in-for-declaration
57b872b 
PR-URL: nodejs#26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 27, 2019
@gengjiawen @targos
tools: remove eslint rule no-let-in-for-declaration
d80cd50 
PR-URL: #26715
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gengjiawen @richardlau @danbev @nodejs-github-bot @Trott @targos @BridgeAR @ZYSzys