-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: V8: cherry-pick 385aa80 #26702
Conversation
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2172/ /CC @nodejs/v8-update @nodejs/platform-windows, since this resolves a regression (and is a backport of a validated change from upstream), I'd like this to be considered for fast-tracking. |
P.S. @hashseed do you know why this code path is only live in a debug build, and is it relevant for node debugging (i.e. can we just turn it off?) |
Original commit message: Correct removal of redundant moves The logic for removing while iterating is non-standard and a left over from a previous index based loop. This patch replaces it with a standard erase based version. This fixes a runtime crash with MSVC that invalidates the iterator and then asserts. This also makes the code safe in case the last move can be redundant. Change-Id: Ie6990e0d65a3b83a4b7da3e2e89ed4e60a6cd215 Reviewed-on: https://chromium-review.googlesource.com/c/1488762 Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59868} Refs: v8/v8@385aa80 PR-URL: nodejs#26702 Fixes: nodejs#26694 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
dd3dfd3
to
8e308e8
Compare
Fixes: #26694
Original commit message:
Refs: v8/v8@385aa80
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes