Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 385aa80 #26702

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Commits on Mar 17, 2019

  1. deps,v8: cherry-pick 385aa80

    Original commit message:
    
        Correct removal of redundant moves
    
        The logic for removing while iterating is non-standard and
        a left over from a previous index based loop. This patch
        replaces it with a standard erase based version.
    
        This fixes a runtime crash with MSVC that invalidates the
        iterator and then asserts. This also makes the code safe
        in case the last move can be redundant.
    
        Change-Id: Ie6990e0d65a3b83a4b7da3e2e89ed4e60a6cd215
        Reviewed-on: https://chromium-review.googlesource.com/c/1488762
        Reviewed-by: Ben Titzer <titzer@chromium.org>
        Commit-Queue: Ben Titzer <titzer@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59868}
    
    Refs: v8/v8@385aa80
    
    PR-URL: nodejs#26702
    Fixes: nodejs#26694
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    refack committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    8e308e8 View commit details
    Browse the repository at this point in the history