-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove public util use in lib/vm.js and lib/zlib.js #26716
Conversation
Welcome @dinaelhanan and thank you for your contribution. Your changes to
You can find information about building and testing node locally here. Let us know if you need assistance. |
@ZYSzys any clues why I'm getting this error? appreciate the help :) |
@ZYSzys hey, I've made few changes but I didn't touch isAnyArrayBuffer, however, I'm getting errors on it. Any ideas why? |
@dinaelhanan the reason for it is a cyclic structure. The former loading order allowed the module to properly resolve. Some changes reference them self, so one module returns |
@BridgeAR ahhhh makes sense! |
Co-Authored-By: dinaelhanan <dinaelhanan@gmail.com>
@ZYSzys should be good but it's still showing an error :/ |
@dinaelhanan it turns out that after a lot of similar PRs like this one landed that
Would you be so kind and update the test as well so this can land? :) |
@BridgeAR done, let me know if there's anything I need to fix 👍 |
@dinaelhanan It seems that there is still something wrong in (Maybe it would be less painful if you can do a It's weird that our travis CI passed and didn't catch that error before :D |
@dinaelhanan sorry that this did not go better but please have another look. Thanks :) |
It was a bug that was introduced into the Travis scripts that has been fixed: #27176 |
This seems outdated and the specific changes have already landed else wise. @dinaelhanan thank you very much for your contribution and I am sorry that this could not land! Please feel free to see if there's not something else for you that you would like to contribute with instead! |
Removed public use of util in lib/vm.js and lib/zlib.js
Checklist