Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public util use in lib/vm.js and lib/zlib.js #26716

Closed
wants to merge 16 commits into from
Closed

Remove public util use in lib/vm.js and lib/zlib.js #26716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
54ec24d
lib: remove require('util') from lib/zlib.js
digitaldina Mar 17, 2019
d45b855
lib: remove require('util') from lib/vm.js
digitaldina Mar 17, 2019
f423c0f
Update vm.js
digitaldina Mar 17, 2019
3d93e80
Update zlib.js
digitaldina Mar 17, 2019
a9f2237
Update zlib.js
digitaldina Mar 18, 2019
9272f74
Update vm.js
digitaldina Mar 20, 2019
137008c
Update zlib.js
digitaldina Mar 20, 2019
e3fe24a
Update zlib.js
digitaldina Mar 20, 2019
f9bb062
Update zlib.js
digitaldina Mar 20, 2019
923ae76
Update zlib.js
digitaldina Mar 22, 2019
49eae24
Update lib/zlib.js
jasnell Mar 26, 2019
01fffc9
Update zlib.js
digitaldina Mar 27, 2019
2afd109
Update zlib.js
digitaldina Mar 31, 2019
f26f092
Update zlib.js
digitaldina Apr 1, 2019
65ca6a3
Update zlib.js
digitaldina Apr 1, 2019
535b087
Update test-bootstrap-modules.js
digitaldina Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/vm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ const {
ERR_INVALID_ARG_TYPE,
ERR_VM_MODULE_NOT_MODULE,
} = require('internal/errors').codes;
const { isModuleNamespaceObject, isArrayBufferView } = require('util').types;
const {
isModuleNamespaceObject,
isArrayBufferView
} = require('internal/util/types');
const {
validateInt32,
validateUint32,
Expand Down
12 changes: 6 additions & 6 deletions lib/zlib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ const {
} = require('internal/errors').codes;
const Transform = require('_stream_transform');
const {
deprecate,
types: {
isAnyArrayBuffer,
isArrayBufferView
}
} = require('util');
deprecate
} = require('internal/util');
const {
isAnyArrayBuffer,
isArrayBufferView
} = require('internal/util/types');
digitaldina marked this conversation as resolved.
Show resolved Hide resolved
const binding = internalBinding('zlib');
const assert = require('internal/assert');
const {
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-bootstrap-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const expectedModules = new Set([
'Internal Binding trace_events',
'Internal Binding types',
'Internal Binding url',
'Internal Binding util',
'NativeModule buffer',
'NativeModule events',
'NativeModule fs',
Expand Down