dgram: append actual errors to ERR_SOCKET_CANNOT_SEND #27865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit appends the actual error to the emitted `ERR_SOCKET_CANNOT_SEND` error so that we could know the detailed reason why the `send()` operation failed.
This comment has been minimized.
This comment has been minimized.
sam-github
reviewed
May 28, 2019
This comment has been minimized.
This comment has been minimized.
|
/cc @nodejs/dgram Someone might help to take a look. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Jan 12, 2020
| // Append `causedByError` to the `error`. | ||
| function addCausedByError(error, message, causedByError) { | ||
| let msg = message; | ||
| if (causedByError) { |
There was a problem hiding this comment.
It might actually make sense to remove this if statement. If the cause is e.g., a thrown undefined or false, so be it.
|
@oyyd sorry that it took so long for someone to look at this again. This needs a rebase by now but otherwise this seems good to go. |
lundibundi
approved these changes
Jan 26, 2020
|
Did #31958 handle this issue (differently) and this can/should now be closed? |
|
Yes, it looks like #31958 has fixed this gracefully. I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our apps has used up all available ports because of misuse and we have noticed some
ERR_SOCKET_CANNOT_SENDerrors in our logs indicating this. I think appending the actual errors to theERR_SOCKET_CANNOT_SENDerror would help with diagnosing.This commit appends the actual error to the emitted
ERR_SOCKET_CANNOT_SENDerror so that we could know the detailed reason why the
send()operationfailed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes