dgram: don't hide implicit bind errors #31958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
added
the
semver-major
nodejs-github-bot
added
dgram
addaleax
approved these changes
Feb 26, 2020
bnoordhuis
approved these changes
Feb 26, 2020
lpinca
approved these changes
Feb 26, 2020
awibox
approved these changes
Feb 26, 2020
jasnell
approved these changes
Feb 27, 2020
cjihrig
added
the
author ready
When dgram socket implicit binding fails, an attempt is made to clean up the send queue. This was originally implemented using an 'error' handler that performed cleanup and then emitted a fake error, which concealed the original error. This was done to prevent cases where the same error was emitted twice. Now that the errorMonitor event is available, use that to perform the cleanup without impacting the actual error handling. PR-URL: nodejs#31958 Refs: nodejs/help#2484 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This error is no longer used within core. This commit removes it. PR-URL: nodejs#31958 Refs: nodejs/help#2484 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in fb26b13...331d636. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dgram socket implicit binding fails, an attempt is made to
clean up the send queue. This was originally implemented using
an
'error'handler that performed cleanup and then emitted afake error, which concealed the original error. This was done
to prevent cases where the same error was emitted twice. Now
that the
errorMonitorevent is available, use that to performthe cleanup without impacting the actual error handling.
The second commit removes the
ERR_SOCKET_CANNOT_SENDerror, which is now unused.Refs: nodejs/help#2484
cc: @bnoordhuis
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes