-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: rm py semicolons (Python != JavaScript) #29120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you undo the changes to deps/v8/
and tools/gyp/
? Those are vendored in and not managed by this repository.
Ah, do gyp changes need to occur in node-gyp? |
I'm not sure to be honest. /ping @nodejs/node-gyp
Contributing to V8 is described at https://v8.dev/docs/contribute |
For obvious reasons, I like this PR but... based @addaleax comment above this might not be the right forum.
|
@targos May you assist with getting these changes made to v8? |
There was a conflict in |
Reworked the commit here (preserving authorship) and opened #29170. Going to close this, since it shouldn't land, but feel free to continue discussion about getting the changes upstreamed to V8. If you think it should be open for any reason, go ahead and re-open (or if GitHub won't allow that, post a comment asking that it be re-opened). |
Sounds good. Hopefully, someone can help land the v8 changes 👍 |
sorry, just for clarity I'll address:
They are not in sync, a PR here should be followed by a PR to node-gyp, ideally, and vice versa. We're still trying to figure out how to maintain this mess. |
@rvagg As I've got the PR open in node-gyp already, should I create a separate one in node that duplicates those changes? |
@MattIPv4 yep, I think so, if they're changes for tools/gyp then it's probably worth doing, we're out of sync already and don't have a process to get back into sync yet so doing things manually isn't going to hurt for now. |
Follow-up PR from #29105 (review) that applies Flake8 E703 (no semicolons) to all Python files.
Checklist