Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: rm py semicolons (Python != JavaScript) #29120

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deps/v8/test/benchmarks/csuite/compare-baseline.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def NormalizedSigmaToString(normalized_sigma):

def ComputeZ(baseline_avg, baseline_sigma, mean, n):
if baseline_sigma == 0:
return 1000.0;
return 1000.0
return abs((mean - baseline_avg) / (baseline_sigma / math.sqrt(n)))

# Values from http://www.fourmilab.ch/rpkp/experiments/analysis/zCalc.html
Expand Down Expand Up @@ -185,7 +185,7 @@ def ProcessResults(opts, results, baselines):
if suite in results:
for result in results[suite]:
ProcessOneResultLine(opts, suite, result[0], result[1], result[2],
result[3], baselines);
result[3], baselines)
PrintSeparator(opts, baselines, False)

def ProcessFile(file_path):
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/test/debugger/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __init__(self, *args, **kwargs):

def _parse_source_files(self, source):
files_list = [] # List of file names to append to command arguments.
files_match = FILES_PATTERN.search(source);
files_match = FILES_PATTERN.search(source)
# Accept several lines of 'Files:'.
while True:
if files_match:
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/test/mjsunit/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def __init__(self, *args, **kwargs):
source = self.get_source()

files_list = [] # List of file names to append to command arguments.
files_match = FILES_PATTERN.search(source);
files_match = FILES_PATTERN.search(source)
# Accept several lines of 'Files:'.
while True:
if files_match:
Expand Down
4 changes: 2 additions & 2 deletions deps/v8/test/preparser/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ def MkTest(replacement, expectation):
testname = name
testsource = source
for key in replacement.keys():
testname = testname.replace("$" + key, replacement[key]);
testsource = testsource.replace("$" + key, replacement[key]);
testname = testname.replace("$" + key, replacement[key])
testsource = testsource.replace("$" + key, replacement[key])
Test(testname, testsource, expectation)
return MkTest
execfile(pathname, {"Test": Test, "Template": Template})
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/test/wasm-js/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def _get_files_params(self):
thisdir = os.path.dirname(self._get_source_path())
script = os.path.join(thisdir, script)
else:
raise Exception("Unexpected absolute path for script: \"%s\"" % script);
raise Exception("Unexpected absolute path for script: \"%s\"" % script)

files.append(script)

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/test/webkit/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def __init__(self, *args, **kwargs):

def _parse_source_files(self, source):
files_list = [] # List of file names to append to command arguments.
files_match = FILES_PATTERN.search(source);
files_match = FILES_PATTERN.search(source)
# Accept several lines of 'Files:'.
while True:
if files_match:
Expand Down
4 changes: 2 additions & 2 deletions deps/v8/third_party/binutils/detect_v8_host_arch.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ def main():
return 0

def DoMain(_):
return DetectHostArch();
return DetectHostArch()

def DetectHostArch():
"""Hook to be called from gyp without starting a separate python
interpreter."""
host_arch = platform.machine()
host_system = platform.system();
host_system = platform.system()

# Convert machine type to format recognized by gyp.
if re.match(r'i.86', host_arch) or host_arch == 'i86pc':
Expand Down
6 changes: 3 additions & 3 deletions deps/v8/tools/adb-d8.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
def CreateFileHandlerClass(root_dirs, verbose):
class FileHandler(SocketServer.BaseRequestHandler):
def handle(self):
data = self.request.recv(1024);
data = self.request.recv(1024)
while data[-1] != "\0":
data += self.request.recv(1024);
data += self.request.recv(1024)

filename = data[0:-1]

Expand All @@ -47,7 +47,7 @@ def handle(self):
sys.stdout.write("Serving {}\r\n".format(os.path.relpath(filename)))

with open(filename) as f:
contents = f.read();
contents = f.read()
self.request.sendall(struct.pack("!i", len(contents)))
self.request.sendall(contents)

Expand Down
10 changes: 5 additions & 5 deletions deps/v8/tools/callstats.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def run_site(site, domain, args, timeout=None):
# If none of these two happened, then chrome apparently crashed, so
# it must be called again.
if status != 124 and status != 0:
print("CHROME CRASHED, REPEATING RUN");
print("CHROME CRASHED, REPEATING RUN")
continue
# If the stats file is empty, chrome must be called again.
if os.path.isfile(result) and os.path.getsize(result) > 0:
Expand All @@ -227,7 +227,7 @@ def run_site(site, domain, args, timeout=None):
timeout += 2 ** retries_since_good_run
retries_since_good_run += 1
print("EMPTY RESULT, REPEATING RUN ({})".format(
retries_since_good_run));
retries_since_good_run))
finally:
if not args.user_data_dir:
shutil.rmtree(user_data_dir)
Expand Down Expand Up @@ -366,7 +366,7 @@ def add_category_total(entries, groups, category_prefix):


def read_stats(path, domain, args):
groups = [];
groups = []
if args.aggregate:
groups = [
('Group-IC', re.compile(".*IC_.*")),
Expand Down Expand Up @@ -529,11 +529,11 @@ def sum_up(parent, key, other):
# dominates execution time and speedometer is measured elsewhere.
excluded_domains = ['adwords.google.com', 'speedometer-angular',
'speedometer-jquery', 'speedometer-backbone',
'speedometer-ember', 'speedometer-vanilla'];
'speedometer-ember', 'speedometer-vanilla']
# Sum up all the entries/metrics from all non-excluded domains
for domain, entries in domains.items():
if domain in excluded_domains:
continue;
continue
for key, domain_stats in entries.items():
if key not in total:
total[key] = {}
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/tools/deprecation_stats.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def GetBlame(file_path):
blame_list.append(current_blame)
return blame_list

RE_MACRO_END = re.compile(r"\);");
RE_MACRO_END = re.compile(r"\);")
RE_DEPRECATE_MACRO = re.compile(r"\(.*?,(.*)\);", re.MULTILINE)

def FilterAndPrint(blame_list, macro, before):
Expand Down
4 changes: 2 additions & 2 deletions deps/v8/tools/gen-inlining-tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -393,11 +393,11 @@ def printtest(flags):
if isinstance(result, tuple) and result[0] == "throw":
result = ('return', 2 + local)
elif catchReturns and not catchWithLocal:
write(" return 2 + ex;");
write(" return 2 + ex;")
if isinstance(result, tuple) and result[0] == "throw":
result = ('return', 2 + result[1])
elif catchWithLocal:
write(" local += ex;");
write(" local += ex;")
if isinstance(result, tuple) and result[0] == "throw":
local += result[1]
result = None
Expand Down
Loading