doc: remove reference to stale CITGM job #29774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
requested changes
Sep 30, 2019
There was a problem hiding this comment.
citgm-smoker is very much still in use so the reference to that should be kept.
citgm-abi-smoker doesn't seemed to have been used recently, even for things like #29241 where there were questions about ABI compatibility.
jasnell
previously approved these changes
Sep 30, 2019
targos
requested changes
Sep 30, 2019
jasnell
dismissed
their stale review
Based on targos' clarification, removing my rubber stamp lgtm :-)
|
@richardlau, @targos thanks for the clarification. I should have read the comments more carefully. Updated to only remove the reference to |
richardlau
approved these changes
Sep 30, 2019
targos
approved these changes
Sep 30, 2019
richardlau
reviewed
Sep 30, 2019
COLLABORATOR_GUIDE.md
Outdated
| @@ -194,8 +194,7 @@ for changes that only affect comments or documentation. | |||
| * [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/) | |||
| uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run | |||
| `npm install && npm test` on a large selection of common modules. This is | |||
| useful to check whether a change will cause breakage in the ecosystem. To test | |||
| Node.js ABI changes you can run [`citgm-abi-smoker`](https://ci.nodejs.org/job/citgm-abi-smoker/). | |||
| useful to check whether a change will cause breakage in the ecosystem. | |||
There was a problem hiding this comment.
Suggested change
| useful to check whether a change will cause breakage in the ecosystem. | |
| useful to check whether a change will cause breakage in the ecosystem. |
should fix the linter failure.
Trott
approved these changes
Oct 1, 2019
lpinca
approved these changes
Oct 1, 2019
BridgeAR
approved these changes
Oct 1, 2019
Remove reference to job that is out of date, has not been run for a long time and likely does not work properly. Refs: nodejs/citgm#741
|
Fixed lint issue, rebased, edited commit message for a typo, squashed commits, force-pushed. PTAL |
richardlau
approved these changes
Oct 2, 2019
|
Landed in 48a1f75 |
Trott
pushed a commit
that referenced
this pull request
Oct 2, 2019
Remove reference to job that is out of date, has not been run for a long time and likely does not work properly. Refs: nodejs/citgm#741 PR-URL: #29774 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
Remove reference to job that is out of date, has not been run for a long time and likely does not work properly. Refs: nodejs/citgm#741 PR-URL: #29774 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reference to job that is out of date, hast not
been run for a long time and likely does not work
properly.
Refs: nodejs/citgm#741
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes