fs: update tests for rmdir() #29815
Closed
fs: update tests for rmdir() #29815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests to create more nested folders and files, like rimraf package tests do. Each test will create 28 nested directories and 210 files. It will also create different types of files, like symlinks.
iansu
suggested changes
Oct 2, 2019
|
CI is currently failing because of linter errors. You can check those locally by running |
mscdex
reviewed
Oct 2, 2019
|
@iansu Can you have a look at my last commit? I moved the first part of tests in their own function so I can test it with different folder hierarchy levels and file types. Lmk what you think so I can sth similar with the rest. |
|
@mpaktiti That looks pretty good to me. I'd say go ahead and do something similar with the other tests. |
|
@nodejs/testing @nodejs/fs @bcoe This could use some reviews. |
bcoe
approved these changes
Oct 11, 2019
| function makeNonEmptyDirectory() { | ||
| const dirname = `rmdir-recursive-${count}`; | ||
| fs.mkdirSync(path.join(dirname, 'foo', 'bar', 'baz'), { recursive: true }); | ||
| function makeNonEmptyDirectory(depth, files, folders, dirname, createSymLinks) { |
There was a problem hiding this comment.
I really like this approach of building this out into a factory, so that it's easy to create a bunch of different scenarios, thanks for doing this 🎉
Trott
added
the
author ready
Trott
pushed a commit
that referenced
this pull request
Oct 13, 2019
Update tests to create more nested folders and files, like rimraf package tests do. Each test will create 28 nested directories and 210 files. It will also create different types of files, like symlinks. PR-URL: #29815 Reviewed-By: Ben Coe <bencoe@gmail.com>
|
Landed in 27507ca. Thanks for the contribution! 🎉 |
targos
pushed a commit
that referenced
this pull request
Oct 14, 2019
Update tests to create more nested folders and files, like rimraf package tests do. Each test will create 28 nested directories and 210 files. It will also create different types of files, like symlinks. PR-URL: #29815 Reviewed-By: Ben Coe <bencoe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests to create more nested folders and files, like rimraf package tests do.
Each test will create 28 nested directories and 210 files.
It will also create different types of files, like symlinks.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes