v12.13.0 'Erbium' release proposal #29981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #29839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Clearly state the modules version 72 is official node 12, similar as it is done for other major node versions. PR-URL: #29877 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #29886 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
It is a common and unfortunate pattern to simply just forward any and all options into the base constructor without taking into account whether these options might conflict with basic stream assumptions. PR-URL: #29857 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #29828 Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #29822 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
- Double word "the" - offical -> official - annoucement -> announcement PR-URL: #29822 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
These can turn into links if reference links are added to the document PR-URL: #29809 Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #29917 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
PR-URL: #29911 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #29915 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
When it isn't nested, a new unordered list is created for the next item PR-URL: #29915 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Update tests to create more nested folders and files, like rimraf package tests do. Each test will create 28 nested directories and 210 files. It will also create different types of files, like symlinks. PR-URL: #29815 Reviewed-By: Ben Coe <bencoe@gmail.com>
Using `process.exit()` in these tests is unnecessary and may mask other problems. Refs: #29873 (review) PR-URL: #29923 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
nodejs-github-bot
added
meta
richardlau
approved these changes
Oct 15, 2019
|
/cc @nodejs/collaborators @nodejs/tsc @nodejs/releasers |
|
Release candidate build: https://ci-release.nodejs.org/job/iojs+release/4766/ |
BridgeAR
approved these changes
Oct 15, 2019
gengjiawen
approved these changes
Oct 15, 2019
cjihrig
approved these changes
Oct 15, 2019
hiroppy
approved these changes
Oct 15, 2019
gireeshpunathil
approved these changes
Oct 15, 2019
|
RC available for download: https://nodejs.org/download/rc/v12.13.0-rc.0/ |
BethGriggs
approved these changes
Oct 15, 2019
jasnell
approved these changes
Oct 15, 2019
'finish' could previously be emitted before the file has been created when ending a write stream without having written any data. Refs: expressjs/multer#238 PR-URL: #29930 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This release marks the transition of Node.js 12.x into Long Term Support (LTS) with the codename 'Erbium'. The 12.x release line now moves into "Active LTS" and will remain so until October 2020. After that time, it will move into "Maintenance" until end of life in April 2022. Notable changes: npm was updated to 6.12.0. It now includes a version of `node-gyp` that supports Python 3 for building native modules. PR-URL: #29981
targos
force-pushed
the
v12.13.0-proposal
branch
from
89c8158 to
42cce5a
Compare
This comment has been minimized.
This comment has been minimized.
|
@Trott there is a |
Today I learned! |
|
Resumed node-test-commit: https://ci.nodejs.org/job/node-test-commit/31992/ |
|
Only two CITGM failures! Both are long-standing and not new here, one has a fix ready to go (just needs to land and be released in the package). |
|
Are we OK with the Travis failure? https://travis-ci.com/nodejs/node/jobs/247038699#L263 |
Re-running the check to see if it's flaky or consistent.... |
and FWIW it failed once in the v12.12.0 release on both the CI and Travis: #29919 (comment) |
|
Release build: https://ci-release.nodejs.org/job/iojs+release/4777/ |
targos
added a commit
that referenced
this pull request
Oct 21, 2019
This release marks the transition of Node.js 12.x into Long Term Support (LTS) with the codename 'Erbium'. The 12.x release line now moves into "Active LTS" and will remain so until October 2020. After that time, it will move into "Maintenance" until end of life in April 2022. Notable changes: npm was updated to 6.12.0. It now includes a version of `node-gyp` that supports Python 3 for building native modules. PR-URL: #29981
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 21, 2019
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 21, 2019
|
Download page on nodejs.org shows 12.13.0 LTS as |
|
13.0.0 will be there tomorrow |
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-10-21, Version 12.13.0 'Erbium' (LTS), @targos
This release marks the transition of Node.js 12.x into Long Term Support (LTS)
with the codename 'Erbium'. The 12.x release line now moves into "Active LTS"
and will remain so until October 2020. After that time, it will move into
"Maintenance" until end of life in April 2022.
Notable changes
npm was updated to 6.12.0. It now includes a version of
node-gypthatsupports Python 3 for building native modules.
Commits
b59209b118] - deps: update npm to 6.12.0 (isaacs) #298851dde617491] - doc: fix --enable-source-maps flag in v12.12.0 changelog (Unlocked) #29960e5e2dfabdc] - doc: nest code fence under unordered list (Nick Schonning) #299155b0c993d4c] - doc: remove double word "where" (Nick Schonning) #29915ad318c6cec] - doc: add brackets to implicit markdown links (Nick Schonning) #299113155ab4134] - doc: use the WHATWG URL API in http code examples (Thomas Watson) #29917b916ea3010] - doc: escape brackets not used as markdown reference links (Nick Schonning) #29809f3bf8be11c] - doc: correct typos in security release process (Nick Schonning) #2982225fa2066a2] - doc: indent code fence under list item (Nick Schonning) #29822f3842892dd] - doc: return type is number (exoego) #29828cbd12518d4] - doc: add note about forwarding stream options (Robert Nagy) #298577683aa0bfb] - doc: set module version 72 to node 12 (Gerhard Stoebich) #29877f58fe5099a] - doc: fix tls version values (Tobias Nießen) #298398ebc94562c] - fs: do not emit 'finish' before 'open' on write empty file (Robert Nagy) #2993050f066087e] - test: do not force the process to exit (Luigi Pinca) #2992344c581ef0b] - test: add more recursive fs.rmdir() tests (Maria Paktiti) #29815fc5334513c] - test: remove unnecessary --expose-internals flags (Anna Henningsen) #29886