errors: drop pronouns from ERR_WORKER_PATH message #32285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
errors
targos
approved these changes
Mar 15, 2020
Trott
reviewed
Mar 15, 2020
lib/internal/errors.js
Outdated
| @@ -1425,8 +1425,7 @@ E('ERR_WORKER_PATH', (filename) => | |||
| 'The worker script or module filename must be an absolute path or a ' + | |||
| 'relative path starting with \'./\' or \'../\'.' + | |||
| (filename.startsWith('file://') ? | |||
| ' If you want to pass a file:// URL, you must wrap it around `new URL`.' : | |||
| '' | |||
| ' file:// URLs must be wrapped with `new URL`.' : '' | |||
There was a problem hiding this comment.
Nit: Maybe avoid passive voice?
Suggested change
| ' file:// URLs must be wrapped with `new URL`.' : '' | |
| ' Wrap file:// URLs with `new URL`.' : '' |
Trott
approved these changes
Mar 15, 2020
jasnell
approved these changes
Mar 16, 2020
mmarchini
approved these changes
Mar 16, 2020
This commit drops pronouns from the ERR_WORKER_PATH message, and also shortens the text a bit.
antsmartian
approved these changes
Mar 17, 2020
cjihrig
added
the
author ready
lpinca
approved these changes
Mar 17, 2020
jasnell
pushed a commit
that referenced
this pull request
Mar 17, 2020
This commit drops pronouns from the ERR_WORKER_PATH message, and also shortens the text a bit. PR-URL: #32285 Refs: #31664 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in c788964 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 19, 2020
This commit drops pronouns from the ERR_WORKER_PATH message, and also shortens the text a bit. PR-URL: #32285 Refs: #31664 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
This commit drops pronouns from the ERR_WORKER_PATH message, and also shortens the text a bit. PR-URL: #32285 Refs: #31664 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
added
backport-blocked-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
This commit drops pronouns from the ERR_WORKER_PATH message, and also shortens the text a bit. PR-URL: nodejs#32285 Refs: nodejs#31664 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
This commit drops pronouns from the ERR_WORKER_PATH message, and also shortens the text a bit. PR-URL: #32285 Refs: #31664 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit drops pronouns from the
ERR_WORKER_PATHmessage, and also shortens the text a bit.Refs: #31664
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes