Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: rework ASAN build on Actions #32352

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 16 additions & 20 deletions .github/workflows/ASAN.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,19 @@ name: node ASAN
on: [push, pull_request]

jobs:
ubuntu-build:
runs-on: ubuntu-latest
container: gengjiawen/node-build:2020-02-14
steps:
- uses: actions/checkout@v2
- name: Build
# TODO(mmarchini): With V8 8.1, GitHub Actions doesn't have enough
# memory to build with debug and ASAN. Allow this build to fail until
# we figure out a workaround, or until we update to 8.2 (where build
# is passing).
continue-on-error: true
run: |
npx envinfo
./configure --debug --enable-asan --ninja && ninja -C out/Debug
- name: Test
env:
ASAN_OPTIONS: halt_on_error=0
continue-on-error: true
run: |
python3 tools/test.py -J --mode=debug
build-linux-asan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Environment Information
run: npx envinfo
- name: Build
run: ./configure --enable-asan && make -j2
# TODO(mmarchini): re-enable tests when we fix all issues pointed out
# by ASAN
# - name: Test
# env:
# ASAN_OPTIONS: halt_on_error=0
# continue-on-error: true
# run: |
# python3 tools/test.py -J