build: rework ASAN build on Actions #32352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
Changed from Debug build to Release build to avoid out of memory issues during the link step. This should also speed up the build. Commented out the test runner for now, since there are too many ASAN warnings there to be useful. We should re-enable the test runner once our ASAN warnings are fixed. Simplify the environment: instead of running on a container, runs directly on the host. With this, ASAN build looks identical to other builds in GitHub Actions, with the exception of the `--enable-asan` flag. Ref: https://github.com/nodejs/node/issue/32257 Ref: nodejs#32324
mmarchini
force-pushed
the
gh-actions-asan-release
branch
from
4508808
to
daf2add
Compare
4 tasks
BridgeAR
approved these changes
Mar 19, 2020
|
URL for the first |
|
Well, that's a bummer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from Debug build to Release build to avoid out of memory issues
during the link step. This should also speed up the build.
Commented out the test runner for now, since there are too many ASAN
warnings there to be useful. We should re-enable the test runner once
our ASAN warnings are fixed.
Simplify the environment: instead of running on a container, runs
directly on the host. With this, ASAN build looks identical to other
builds in GitHub Actions, with the exception of the
--enable-asanflag.
Ref: #32257
Ref: #32324
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes