Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove non required console.log #32541

Closed
wants to merge 1 commit into from
Closed

test: remove non required console.log #32541

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30164/

cjihrig
cjihrig approved these changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Alternatively, you could change the console.log() to util.debuglog().

@jasnell
Copy link
Member

jasnell commented Mar 29, 2020

LGTM. Alternatively, you could change the console.log() to util.debuglog().

If you wanted to do this, include const debug = require('util').debuglog('test') at the top of the file then call debug('...')

@juanarbol juanarbol mentioned this pull request Mar 29, 2020
Closed
3 tasks
@juanarbol
Copy link
Member Author

If you wanted to do this, include const debug = require('util').debuglog('test') at the top of the file then call debug('...')

Something like this?

I think this test does not require logging very much.

Trott
Trott approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Commit message suggestion:

test: remove unnecessary console.log() calls

@juanarbol juanarbol force-pushed the juanarbol/remove-console-log branch from 9550ead to c21e9b9 Compare March 30, 2020 20:18
@juanarbol
Copy link
Member Author

LGTM.

Commit message suggestion:

test: remove unnecessary console.log() calls

Commit reword is done! Thank you!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30304/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 2, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/30374/ ✔️

addaleax pushed a commit that referenced this pull request Apr 2, 2020
@juanarbol @addaleax
test: replace console.log() with debuglog()
579e6b9 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in 9a914ff

addaleax pushed a commit that referenced this pull request Apr 2, 2020
@juanarbol @addaleax
test: remove unnecessary console.log() calls
9a914ff 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax closed this Apr 2, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@juanarbol @BethGriggs
test: replace console.log() with debuglog()
b2339c8 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@juanarbol @BethGriggs
test: remove unnecessary console.log() calls
9d6adf3 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@juanarbol @targos
test: replace console.log() with debuglog()
8f0c106 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@juanarbol @targos
test: remove unnecessary console.log() calls
30505d7 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@juanarbol @targos
test: replace console.log() with debuglog()
30d21fb 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@juanarbol @targos
test: remove unnecessary console.log() calls
4165312 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
@juanarbol juanarbol deleted the juanarbol/remove-console-log branch January 19, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@juanarbol @nodejs-github-bot @jasnell @addaleax @Trott @cjihrig @ZYSzys