-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace console.log for debug in test #32550
Closed
juanarbol
wants to merge
1
commit into
nodejs:master
from
juanarbol:juanarbol/replace-console.log-for-debug
Closed
test: replace console.log for debug in test #32550
juanarbol
wants to merge
1
commit into
nodejs:master
from
juanarbol:juanarbol/replace-console.log-for-debug
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jasnell
approved these changes
Mar 29, 2020
Trott
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message suggestion:
test: replace console.log() with debuglog()
lpinca
approved these changes
Mar 30, 2020
juanarbol
force-pushed
the
juanarbol/replace-console.log-for-debug
branch
from
March 30, 2020 20:17
591da23
to
79d3d95
Compare
Commit reword is done now. |
ZYSzys
approved these changes
Apr 1, 2020
ZYSzys
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 1, 2020
Landed in 579e6b9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #32541
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes