Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] ESM Module update #32610

Closed

Commits on Apr 2, 2020

  1. tools: update minimist@1.2.5

    Update minimist used by lint-md.js to 1.2.5.
    
    Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764
    Signed-off-by: Rich Trott <rtrott@gmail.com>
    
    PR-URL: nodejs#32274
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    c0e6e60 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. esm: import.meta.resolve with nodejs: builtins

    PR-URL: nodejs#31032
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    guybedford authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    a1a282f View commit details
    Browse the repository at this point in the history
  2. module: package "exports" error refinements

    PR-URL: nodejs#31625
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    guybedford authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    37aee30 View commit details
    Browse the repository at this point in the history
  3. esm: remove unused parameter on module.instantiate

    PR-URL: nodejs#32147
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    himself65 authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    e147f61 View commit details
    Browse the repository at this point in the history
  4. module: add hook for global preload code

    PR-URL: nodejs#32068
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    jkrems authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    07b77a3 View commit details
    Browse the repository at this point in the history
  5. doc: import clarifications with links to MDN

    PR-URL: nodejs#31479
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    aldeed authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    9da5813 View commit details
    Browse the repository at this point in the history
  6. doc: improve wording in esm.md

    Simplify complex sentence. Remove use of "straightforward".
    
    PR-URL: nodejs#32427
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    ef27b5a View commit details
    Browse the repository at this point in the history
  7. doc: fix lint warning in doc/api/esm.md

    Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    
    PR-URL: nodejs#32462
    Refs: nodejs#31479
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    richardlau authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    5c7c915 View commit details
    Browse the repository at this point in the history
  8. doc: remove unnecessary "obvious(ly)" modifiers in esm.md

    Remove "obvious" and "obviously" in two places in esm.md. It may be
    obvious to some, but likely not everyone or else it probably wouldn't be
    worth mentioning/documenting.
    
    PR-URL: nodejs#32457
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    17a18a1 View commit details
    Browse the repository at this point in the history
  9. build: add mjs extension to lint-js

    This matches what the lint-js make target passes through the CLI.
    
    PR-URL: nodejs#32145
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nschonni authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    26e44c9 View commit details
    Browse the repository at this point in the history
  10. doc: update conditional exports recommendations

    Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
    PR-URL: nodejs#32098
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    2 people authored and MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    4ab422a View commit details
    Browse the repository at this point in the history
  11. doc: esm spec bug

    MylesBorins committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    fce87a5 View commit details
    Browse the repository at this point in the history