Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.14.0 proposal #33122

Merged
merged 116 commits into from
Apr 29, 2020
Merged
Changes from 1 commit
Commits
Show all changes
116 commits
Select commit Hold shift + click to select a range
ea85768
deps: V8: cherry-pick dc3a90be6ca7
targos Apr 12, 2020
cc0395c
Revert "n-api: detect deadlocks in thread-safe function"
Apr 16, 2020
fd4320c
n-api: detect deadlocks in thread-safe function
Apr 6, 2020
b80b08f
worker: fix type check in receiveMessageOnPort
addaleax Apr 9, 2020
1996198
doc: add puzpuzpuz to collaborators
puzpuzpuz Apr 13, 2020
f4e9bd6
test: use symlinks to copy shells
Apr 7, 2020
c6078f0
build: add build from tarball
Mar 6, 2020
b304df9
async_hooks: prevent sync methods of async storage exiting outer context
Qard Feb 25, 2020
52d8afc
async_hooks: merge run and exit methods
puzpuzpuz Mar 14, 2020
ea09c0f
doc: document `buffer.from` returns internal pool buffer
HarshithaKP Apr 7, 2020
bff11a9
src: remove unused v8 Array namespace
juanarbol Apr 10, 2020
c0e4ac4
doc: improve AsyncLocalStorage sample
puzpuzpuz Apr 10, 2020
d937874
buffer: mark pool ArrayBuffer as untransferable
addaleax Apr 10, 2020
1436f53
tls: provide default cipher list from command line
addaleax Apr 10, 2020
a1178b6
buffer: add type check in bidirectionalIndexOf
Flarna Apr 10, 2020
95cd771
doc: remove warning from `response.writeHead`
cecchi Apr 7, 2020
c8d4360
build: use same flags as V8 for ASAN
mmarchini Apr 10, 2020
5c4d8cd
build: re-enable ASAN Action using clang
mmarchini Mar 21, 2020
a0be60e
doc: updated guidance for n-api changes
mhdawson Apr 8, 2020
8fb7852
cli, report: move --report-on-fatalerror to stable
cjihrig Mar 26, 2020
ae034c4
doc: add transform stream destroy() return value
cjihrig Apr 11, 2020
e1809c8
build: add configure flag to build V8 with DCHECKs
addaleax Apr 11, 2020
83f1e98
lib: created isValidCallback helper
yashLadha Apr 5, 2020
2f7e372
src: ignore GCC -Wcast-function-type for v8.h
danbev Apr 6, 2020
f1273e8
test: cover node entry type in perf_hooks
julianduque Apr 10, 2020
b7da587
doc: note that signatures of binary may be from subkeys
haqer1 Apr 1, 2020
98db564
test: mark test-http2-reset-flood flaky on all
sam-github Apr 13, 2020
edc10d4
test: mark test-worker-prof flaky on arm
sam-github Apr 13, 2020
46cafad
test: replace equal with strictEqual
JesuHrz Apr 8, 2020
3b590d4
process: suggest --trace-warnings when printing warning
addaleax Apr 12, 2020
5b01772
src: use basename(argv0) for --trace-uncaught suggestion
addaleax Apr 12, 2020
85b333b
http: refactor agent 'free' handler
ronag Apr 12, 2020
23a4d60
test: mark cpu-prof-dir-worker flaky on all
sam-github Apr 13, 2020
8774cb4
fs: use finished over destroy w/ cb
ronag Apr 13, 2020
3f4bb8d
doc: improve net docs
ronag Apr 13, 2020
740f864
test: only detect uname on supported os
dmabupt Apr 13, 2020
4baf41f
test: replace console.log/error() with debuglog
daemon1024 Apr 6, 2020
832ea52
build: remove .git folders when testing V8
richardlau Apr 16, 2020
7980f6f
doc: improve consistency in usage of NULL
mhdawson Apr 8, 2020
a72d1d3
src: remove unused using in node_worker.cc
danbev Apr 14, 2020
520347c
module: fix memory leak when require error occurs
lianxuify Apr 14, 2020
5dba49d
doc: missing brackets
sla100 Apr 4, 2020
0c7391c
module: remove experimental modules warning
guybedford Feb 26, 2020
cc47645
doc: add juanarbol as collaborator
juanarbol Apr 17, 2020
45a125c
doc: add N-API version 6 to table
mhdawson Apr 13, 2020
9fd0c35
src: remove redundant v8::HeapSnapshot namespace
juanarbol Apr 14, 2020
f7b25c0
tools: decrease timeout in test.py
addaleax Apr 15, 2020
e529a32
src: elevate v8 namespaces
nimit95 Apr 15, 2020
87149c4
test: changed function to arrow function
nimit95 Apr 16, 2020
43adbe6
doc: add `tsc-agenda` to onboarding labels list
Trott Apr 13, 2020
b36eb75
stream: inline unbuffered _write
ronag Apr 16, 2020
507240c
stream: close iterator in Readable.from
vadzim Apr 14, 2020
8a85afa
lib: remove unnecesary else block
ddazal Apr 3, 2020
0b2cff2
fs: remove unnecessary else statement
JesuHrz Apr 4, 2020
c1f54c7
src: remove validation of unreachable code
juanarbol Apr 13, 2020
8c1a69c
doc: synch SECURITY.md with website
Trott Apr 17, 2020
771ca7d
deps: upgrade to libuv 1.36.0
cjihrig Apr 15, 2020
afe7f41
deps: upgrade to libuv 1.37.0
cjihrig Apr 19, 2020
7bd51fb
perf_hooks: remove unnecessary assignment when name is undefined
rickyes Apr 18, 2020
04b1f63
fs: extract kWriteFileMaxChunkSize constant
rickyes Apr 3, 2020
c596759
doc: fix typo in zlib.md
chenmnkken Apr 17, 2020
76e960c
doc: fix usage of folder and directory terms in fs.md
karan1205 Apr 18, 2020
944e010
test: mark test-child-process-fork-args as flaky on Windows
puzpuzpuz Apr 20, 2020
faeb408
doc: corrected ERR_SOCKET_CANNOT_SEND message
willarmiros Apr 14, 2020
0fdc55f
src: fix null deref in AllocatedBuffer::clear
fowles Apr 16, 2020
8c48d16
doc: fix typo in security-release-process.md
SASUKE40 Apr 19, 2020
4432bb2
module: partial doc removal of --experimental-modules
MylesBorins Apr 18, 2020
bfa19c4
tls: move getAllowUnauthorized to internal/options
jasnell Apr 18, 2020
e540d5c
module: improve error for invalid package targets
MylesBorins Apr 17, 2020
cb93c60
module: exports not exported for null resolutions
guybedford Apr 14, 2020
a673c8f
http2: wait for secureConnect before initializing
bcoe Apr 21, 2020
27837fe
fs: update validateOffsetLengthRead in utils.js
daemon1024 Apr 17, 2020
015f33c
src: use using NewStringType
rickyes Apr 14, 2020
c402edd
tools: remove unused code in doc generation tool
Trott Apr 18, 2020
287bd8a
doc: elevate diagnostic report to tier1
gireeshpunathil Mar 25, 2020
99f4af4
doc: remove repeated word in modules.md
kodekage Apr 19, 2020
347f71a
deps: V8: cherry-pick e1eac1b16c96
Apr 21, 2020
c3025f3
test: test-async-wrap-constructor prefer forEach
dericop Apr 3, 2020
2eb5262
doc: add angle brackets around implicit links
nschonni Apr 6, 2020
f7c7713
doc: ignore no-literal-urls in changelogs
nschonni Apr 6, 2020
a5bed1e
doc: convert bare email addresses to mailto links
nschonni Apr 23, 2020
e372b8b
doc: ignore no-literal-urls in README
nschonni Apr 23, 2020
2c364d4
lib: simplify function process.emitWarning
himself65 Apr 22, 2020
4169bc4
test: refactor events tests for invalid listeners
edsadr Apr 11, 2020
fae1aed
doc: updated directory entry information
Apr 12, 2020
a223ccc
test: better error validations for event-capture
edsadr Apr 10, 2020
bd096bd
src: delete MicroTaskPolicy namespace
juanarbol Apr 14, 2020
d178250
lib: unnecessary const assignment for class
yashLadha Apr 21, 2020
5dc4349
inspector: only write coverage in fully bootstrapped Environments
joyeecheung Apr 21, 2020
8809699
vm: add importModuleDynamically option to compileFunction
devsnek Apr 21, 2020
f155690
src: assignment to valid type
yashLadha Apr 16, 2020
790c453
test: remove timers-blocking-callback
Fishrock123 Apr 15, 2020
dd1cc1a
doc: avoid tautology in README
ishaanjain1898 Apr 22, 2020
18fd841
buffer,n-api: fix double ArrayBuffer::Detach() during cleanup
addaleax Apr 24, 2020
5caa627
deps: V8: backport 3f8dc4b2e5ba
ryzokuken Apr 22, 2020
f6274af
tls: add highWaterMark option for connect
rickyes Apr 11, 2020
29d7202
deps: upgrade openssl sources to 1.1.1g
hassaanp Apr 21, 2020
28c39d3
deps: update archs files for OpenSSL-1.1.1g
hassaanp Apr 21, 2020
9ebcd79
doc: add documentation for transferList arg at worker threads
juanarbol Apr 16, 2020
428fca1
worker: fix process.env var empty key access
bl-ue Apr 26, 2020
018de28
src: fix empty-named env var assertion failure
bl-ue Apr 18, 2020
14cf904
src: do not compare against wide characters
bl-ue Apr 19, 2020
0f4d513
cluster: removed unused addressType argument from constructor
yashLadha Apr 21, 2020
c239cc6
util,readline: NFC-normalize strings before getStringWidth
addaleax Apr 25, 2020
6984fbc
test: refactor test-async-hooks-constructor
himself65 Apr 25, 2020
6b6c8d0
doc: document major finished changes in v14
ronag Apr 25, 2020
b953ab6
src: add AsyncWrapObject constructor template factory
Qard Apr 25, 2020
79d92b2
doc: improve release documentation
targos Apr 24, 2020
c97a7ce
module: refactor condition
MylesBorins Apr 22, 2020
be55aac
doc: make openssl maintenance position independent
sam-github Apr 21, 2020
bd40a8b
build: fix vcbuild error for missing Visual Studio
Hakerh400 Apr 4, 2020
de3ab9f
doc: improve WHATWG url constructor code example
lirantal Apr 11, 2020
4fc7877
n-api: fix false assumption on napi_async_context structures
legendecas Apr 19, 2020
9d18408
http: doc deprecate abort and improve docs
ronag Apr 13, 2020
386d158
doc: assign missing deprecation code
richardlau Apr 27, 2020
9fc74f1
2020-04-29, Version 13.14.0 (Current)
BridgeAR Apr 28, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix usage of folder and directory terms in fs.md
This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md

Fixes: #32902

PR-URL: #32919
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
karan1205 authored and BridgeAR committed Apr 28, 2020
commit 76e960c67f5bc1dbbb15ef40dd9619e54ba8071a
32 changes: 16 additions & 16 deletions doc/api/fs.md
Original file line number Diff line number Diff line change
@@ -2470,11 +2470,11 @@ changes:
Asynchronously creates a directory.

The callback is given a possible exception and, if `recursive` is `true`, the
first folder path created, `(err, [path])`.
first directory path created, `(err, [path])`.

The optional `options` argument can be an integer specifying mode (permission
and sticky bits), or an object with a `mode` property and a `recursive`
property indicating whether parent folders should be created. Calling
property indicating whether parent directories should be created. Calling
`fs.mkdir()` when `path` is a directory that exists results in an error only
when `recursive` is false.

@@ -2520,7 +2520,7 @@ changes:
* Returns: {string|undefined}

Synchronously creates a directory. Returns `undefined`, or if `recursive` is
`true`, the first folder path created.
`true`, the first directory path created.
This is the synchronous version of [`fs.mkdir()`][].

See also: mkdir(2).
@@ -2547,7 +2547,7 @@ changes:
* `encoding` {string} **Default:** `'utf8'`
* `callback` {Function}
* `err` {Error}
* `folder` {string}
* `directory` {string}

Creates a unique temporary directory.

@@ -2557,16 +2557,16 @@ inconsistencies, avoid trailing `X` characters in `prefix`. Some platforms,
notably the BSDs, can return more than six random characters, and replace
trailing `X` characters in `prefix` with random characters.

The created folder path is passed as a string to the callback's second
The created directory path is passed as a string to the callback's second
parameter.

The optional `options` argument can be a string specifying an encoding, or an
object with an `encoding` property specifying the character encoding to use.

```js
fs.mkdtemp(path.join(os.tmpdir(), 'foo-'), (err, folder) => {
fs.mkdtemp(path.join(os.tmpdir(), 'foo-'), (err, directory) => {
if (err) throw err;
console.log(folder);
console.log(directory);
// Prints: /tmp/foo-itXde2 or C:\Users\...\AppData\Local\Temp\foo-itXde2
});
```
@@ -2582,19 +2582,19 @@ must end with a trailing platform-specific path separator
const tmpDir = os.tmpdir();

// This method is *INCORRECT*:
fs.mkdtemp(tmpDir, (err, folder) => {
fs.mkdtemp(tmpDir, (err, directory) => {
if (err) throw err;
console.log(folder);
console.log(directory);
// Will print something similar to `/tmpabc123`.
// A new temporary directory is created at the file system root
// rather than *within* the /tmp directory.
});

// This method is *CORRECT*:
const { sep } = require('path');
fs.mkdtemp(`${tmpDir}${sep}`, (err, folder) => {
fs.mkdtemp(`${tmpDir}${sep}`, (err, directory) => {
if (err) throw err;
console.log(folder);
console.log(directory);
// Will print something similar to `/tmp/abc123`.
// A new temporary directory is created within
// the /tmp directory.
@@ -2611,7 +2611,7 @@ added: v5.10.0
* `encoding` {string} **Default:** `'utf8'`
* Returns: {string}

Returns the created folder path.
Returns the created directory path.

For detailed information, see the documentation of the asynchronous version of
this API: [`fs.mkdtemp()`][].
@@ -3476,7 +3476,7 @@ error raised if the file is not available.
To check if a file exists without manipulating it afterwards, [`fs.access()`][]
is recommended.

For example, given the following folder structure:
For example, given the following directory structure:

```fundamental
- txtDir
@@ -4945,11 +4945,11 @@ added: v10.0.0
* Returns: {Promise}

Asynchronously creates a directory then resolves the `Promise` with either no
arguments, or the first folder path created if `recursive` is `true`.
arguments, or the first directory path created if `recursive` is `true`.

The optional `options` argument can be an integer specifying mode (permission
and sticky bits), or an object with a `mode` property and a `recursive`
property indicating whether parent folders should be created. Calling
property indicating whether parent directories should be created. Calling
`fsPromises.mkdir()` when `path` is a directory that exists results in a
rejection only when `recursive` is false.

@@ -4964,7 +4964,7 @@ added: v10.0.0
* Returns: {Promise}

Creates a unique temporary directory and resolves the `Promise` with the created
folder path. A unique directory name is generated by appending six random
directory path. A unique directory name is generated by appending six random
characters to the end of the provided `prefix`. Due to platform
inconsistencies, avoid trailing `X` characters in `prefix`. Some platforms,
notably the BSDs, can return more than six random characters, and replace