v13.14.0 proposal

.github/workflows/build-tarball.yml

@@ -0,0 +1,141 @@
+name: Build from tarball
+
+on: [push, pull_request]
+
+env:
+  FLAKY_TESTS: dontcare
+
+jobs:
+  build-tarball:
+    env:
+      PYTHON_VERSION: 3.8
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v1
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Make tarball
+        run: |
+          export DISTTYPE=nightly
+          export DATESTRING=`date "+%Y-%m-%d"`
+          export COMMIT=xxxx
+          ./configure && make tar -j8
+          mkdir tarballs
+          mv *.tar.gz tarballs
+      - name: Upload tarball artifact
+        uses: actions/upload-artifact@v1
+        with:
+          name: tarballs
+          path: tarballs
+  test-tarball-linux:
+    env:
+      PYTHON_VERSION: 3.8
+    needs: build-tarball
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v1
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Download tarball
+        uses: actions/download-artifact@v1
+        with:
+          name: tarballs
+      - name: Extract tarball
+        run: |
+          tar xzf tarballs/*.tar.gz
+          echo "::set-env name=TAR_DIR::`basename tarballs/*.tar.gz .tar.gz`"
+      - name: Copy directories needed for testing
+        run: |
+          cp -r tools/node_modules $TAR_DIR/tools
+          cp -r tools/eslint-rules $TAR_DIR/tools
+      - name: Build
+        run: |
+          cd $TAR_DIR
+          make build-ci -j2 V=1
+      - name: Test
+        run: |
+          cd $TAR_DIR
+          make run-ci -j2 V=1
+  test-tarball-windows:
+    needs: build-tarball
+    runs-on: windows-latest
+    steps:
+      - name: Set up autocrlf
+        run: |
+          git config --global core.autocrlf true
+      - uses: actions/checkout@v2
+      - name: Set up Python 2.7
+        uses: actions/setup-python@v1
+        with:
+          python-version: 2.7
+      - name: Environment Information
+        run: npx envinfo
+      - name: Download tarball
+        uses: actions/download-artifact@v1
+        with:
+          name: tarballs
+      - name: Extract tarball
+        run: |
+          7z x tarballs/*.tar.gz
+          7z x *.tar -ttar
+      - name: Install deps
+        run: choco install nasm
+      - name: Build
+        run: |
+          $env:DEBUG_HELPER=1
+          $tarfile = dir *.tar
+          cd $tarfile.BaseName
+          $env:msbuild_args="/binaryLogger:node.binlog"
+          ./vcbuild.bat x64 release msi
+          echo "::set-env name=TAR_DIR::$pwd"
+      - name: Copy out directory to checkout dir
+        run: Move-Item -Path "$env:TAR_DIR\out" -Destination "$env:GITHUB_WORKSPACE"
+      - name: "Test JS Suites"
+        shell: cmd
+        run: |
+          set DEBUG_HELPER=1
+          ./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-js
+      - name: "Test C++ Suites"
+        shell: cmd
+        run: |
+          set DEBUG_HELPER=1
+          ./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-native
+  test-tarball-macOS:
+    needs: build-tarball
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v1
+        with:
+          PYTHON_VERSION: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Download tarball
+        uses: actions/download-artifact@v1
+        with:
+          name: tarballs
+      - name: Extract tarball
+        run: |
+          tar xzf tarballs/*.tar.gz
+          echo "::set-env name=TAR_DIR::`basename tarballs/*.tar.gz .tar.gz`"
+      - name: Copy directories needed for testing
+        run: |
+          cp -r tools/node_modules $TAR_DIR/tools
+          cp -r tools/eslint-rules $TAR_DIR/tools
+      - name: Build
+        run: |
+          cd $TAR_DIR
+          make build-ci -j8 V=1
+      - name: Test
+        run: |
+          cd $TAR_DIR
+          make run-ci -j8 V=1

.github/workflows/test-asan.yml

@@ -0,0 +1,28 @@
+name: test-asan
+
+on: [push, pull_request]
+
+env:
+  PYTHON_VERSION: 3.8
+  FLAKY_TESTS: dontcare
+
+jobs:
+  test-asan:
+    runs-on: ubuntu-latest
+    env:
+      CC: clang
+      CXX: clang++
+      LINK: clang++
+      CONFIG_FLAGS: --enable-asan
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v1
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: make build-ci -j2 V=1
+      - name: Test cctest
+        run: make cctest -j2 V=1

BUILDING.md

@@ -204,7 +204,7 @@ For use of AVX2,
 * nasm version 2.10 or higher in Windows
 
 Please refer to
- https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_ia32cap.html for details.
+ <https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_ia32cap.html> for details.
 
  If compiling without one of the above, use `configure` with the
 `--openssl-no-asm` flag. Otherwise, `configure` will fail.
@@ -277,7 +277,7 @@ $ make -j4
 If you run into a `No module named 'distutils.spawn'` error when executing
 `./configure`, please try `python3 -m pip install --upgrade setuptools` or
 `sudo apt install python3-distutils -y`.
-For more information, see https://github.com/nodejs/node/issues/30189.
+For more information, see <https://github.com/nodejs/node/issues/30189>.
 
 The `-j4` option will cause `make` to run 4 simultaneous compilation jobs which
 may reduce build time. For more information, see the

CHANGELOG.md

@@ -30,7 +30,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V13.md#13.13.0">13.13.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V13.md#13.14.0">13.14.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V13.md#13.13.0">13.13.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.12.0">13.12.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.11.0">13.11.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.10.1">13.10.1</a><br/>

README.md

@@ -1,3 +1,4 @@
+<!--lint disable no-literal-urls-->
 <p align="center">
   <a href="https://nodejs.org/">
     <img
@@ -79,7 +80,7 @@ contains the latest Carbon (Node.js 8) release.
 #### Nightly Releases
 <https://nodejs.org/download/nightly/>
 
-Each directory name and filename contains a date (in UTC time) and the commit
+Each directory name and filename contains a date (in UTC) and the commit
 SHA at the HEAD of the release.
 
 #### API Documentation
@@ -331,6 +332,8 @@ For information about the governance of the Node.js project, see
 **João Reis** &lt;reis@janeasystems.com&gt;
 * [joyeecheung](https://github.com/joyeecheung) -
 **Joyee Cheung** &lt;joyeec9h3@gmail.com&gt; (she/her)
+* [juanarbol](https://github.com/juanarbol) -
+**Juan José Arboleda** &lt;soyjuanarbol@gmail.com&gt; (he/him)
 * [JungMinu](https://github.com/JungMinu) -
 **Minwoo Jung** &lt;nodecorelab@gmail.com&gt; (he/him)
 * [kfarnung](https://github.com/kfarnung) -
@@ -367,6 +370,8 @@ For information about the governance of the Node.js project, see
 **Ouyang Yadong** &lt;oyydoibh@gmail.com&gt; (he/him)
 * [psmarshall](https://github.com/psmarshall) -
 **Peter Marshall** &lt;petermarshall@chromium.org&gt; (he/him)
+* [puzpuzpuz](https://github.com/puzpuzpuz) -
+**Andrey Pechkurov** &lt;apechkurov@gmail.com&gt; (he/him)
 * [Qard](https://github.com/Qard) -
 **Stephen Belanger** &lt;admin@stephenbelanger.com&gt; (he/him)
 * [refack](https://github.com/refack) -
@@ -546,7 +551,7 @@ maintaining the Node.js project.
 
 ### Release Keys
 
-GPG keys used to sign Node.js releases:
+Primary GPG keys for Node.js Releasers (some Releasers sign with subkeys):
 
 * **Beth Griggs** &lt;bethany.griggs@uk.ibm.com&gt;
 `4ED778F539E3634C779C87C6D7062848A1AB005C`

SECURITY.md

@@ -11,8 +11,7 @@ handling your submission.
 After the initial reply to your report, the security team will endeavor to keep
 you informed of the progress being made towards a fix and full announcement,
 and may ask for additional information or guidance surrounding the reported
-issue.  These updates will be sent at least every five days; in practice, this
-is more likely to be every 24-48 hours.
+issue.
 
 ### Node.js Bug Bounty Program
 

benchmark/async_hooks/async-resource-vs-destroy.js

@@ -101,7 +101,7 @@ function buildDestroy(getServe) {
 function buildAsyncLocalStorage(getServe) {
   const asyncLocalStorage = new AsyncLocalStorage();
   const server = createServer((req, res) => {
-    asyncLocalStorage.runSyncAndReturn({}, () => {
+    asyncLocalStorage.run({}, () => {
       getServe(getCLS, setCLS)(req, res);
     });
   });

common.gypi

@@ -35,7 +35,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.30',
+    'v8_embedder_string': '-node.32',
 
     ##### V8 defaults for Node.js #####
 
@@ -284,8 +284,9 @@
         'cflags+': [
           '-fno-omit-frame-pointer',
           '-fsanitize=address',
-          '-DLEAK_SANITIZER'
+          '-fsanitize-address-use-after-scope',
         ],
+        'defines': [ 'LEAK_SANITIZER', 'V8_USE_ADDRESS_SANITIZER' ],
         'cflags!': [ '-fomit-frame-pointer' ],
         'ldflags': [ '-fsanitize=address' ],
       }],

configure.py

@@ -635,6 +635,12 @@
     default=False,
     help='compile V8 with minimal optimizations and with runtime checks')
 
+parser.add_option('--v8-with-dchecks',
+    action='store_true',
+    dest='v8_with_dchecks',
+    default=False,
+    help='compile V8 with debug checks and runtime debugging features enabled')
+
 parser.add_option('--node-builtin-modules-path',
     action='store',
     dest='node_builtin_modules_path',
@@ -1235,6 +1241,7 @@ def configure_v8(o):
   o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0
   o['variables']['v8_no_strict_aliasing'] = 1  # Work around compiler bugs.
   o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1
+  o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0
   o['variables']['v8_random_seed'] = 0  # Use a random seed for hash tables.
   o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks.
   o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1

deps/openssl/config/archs/BSD-x86/asm/configdata.pm

@@ -111,8 +111,8 @@ our %config = (
   sourcedir => ".",
   target => "BSD-x86",
   tdirs => [ "ossl_shim" ],
-  version => "1.1.1f",
-  version_num => "0x1010106fL",
+  version => "1.1.1g",
+  version_num => "0x1010107fL",
 );
 
 our %target = (
@@ -7413,6 +7413,7 @@ our %unified_info = (
                 [
                     ".",
                     "include",
+                    "crypto/modes",
                 ],
             "crypto/rand/drbg_lib.o" =>
                 [

deps/openssl/config/archs/BSD-x86/asm/crypto/buildinf.h

@@ -11,7 +11,7 @@
  */
 
 #define PLATFORM "platform: BSD-x86"
-#define DATE "built on: Tue Mar 31 13:06:25 2020 UTC"
+#define DATE "built on: Tue Apr 21 13:28:30 2020 UTC"
 
 /*
  * Generate compiler_flags as an array of individual characters. This is a

deps/openssl/config/archs/BSD-x86/asm_avx2/configdata.pm

@@ -111,8 +111,8 @@ our %config = (
   sourcedir => ".",
   target => "BSD-x86",
   tdirs => [ "ossl_shim" ],
-  version => "1.1.1f",
-  version_num => "0x1010106fL",
+  version => "1.1.1g",
+  version_num => "0x1010107fL",
 );
 
 our %target = (
@@ -7413,6 +7413,7 @@ our %unified_info = (
                 [
                     ".",
                     "include",
+                    "crypto/modes",
                 ],
             "crypto/rand/drbg_lib.o" =>
                 [

deps/openssl/config/archs/BSD-x86/asm_avx2/crypto/buildinf.h

@@ -11,7 +11,7 @@
  */
 
 #define PLATFORM "platform: BSD-x86"
-#define DATE "built on: Tue Mar 31 13:06:27 2020 UTC"
+#define DATE "built on: Tue Apr 21 13:28:32 2020 UTC"
 
 /*
  * Generate compiler_flags as an array of individual characters. This is a

deps/openssl/config/archs/BSD-x86/no-asm/configdata.pm

@@ -110,8 +110,8 @@ our %config = (
   sourcedir => ".",
   target => "BSD-x86",
   tdirs => [ "ossl_shim" ],
-  version => "1.1.1f",
-  version_num => "0x1010106fL",
+  version => "1.1.1g",
+  version_num => "0x1010107fL",
 );
 
 our %target = (
@@ -7363,6 +7363,7 @@ our %unified_info = (
                 [
                     ".",
                     "include",
+                    "crypto/modes",
                 ],
             "crypto/rand/drbg_lib.o" =>
                 [

deps/openssl/config/archs/BSD-x86/no-asm/crypto/buildinf.h

@@ -11,7 +11,7 @@
  */
 
 #define PLATFORM "platform: BSD-x86"
-#define DATE "built on: Tue Mar 31 13:06:30 2020 UTC"
+#define DATE "built on: Tue Apr 21 13:28:34 2020 UTC"
 
 /*
  * Generate compiler_flags as an array of individual characters. This is a