Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: resolving more outstanding TODO comments #34865

Closed
wants to merge 5 commits into from
Closed

quic: resolving more outstanding TODO comments #34865

wants to merge 5 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 21, 2020

Continuing to resolve some outstanding TODO statements...

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jasnell jasnell requested a review from a team August 21, 2020 17:25
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 21, 2020
@jasnell jasnell added dont-land-on-v14.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Aug 21, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Aug 22, 2020
Open
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
jasnell added 5 commits August 24, 2020 10:31
@jasnell
quic: resolve http3 header todo
4acbbc6 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: resolve debug output todo
86111d6 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: clarify and resolve todo comment
1e78da1 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: remove unneeded TODO comment
aaaa51f 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
deps: fixup win arm64 build for ngtcp2/nghttp3
097e960
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2020 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32915/
QUIC-CI: https://ci.nodejs.org/job/node-test-commit/40425/

Windows CI runs appear to be failing for reasons unrelated to this PR.

@jasnell jasnell mentioned this pull request Aug 24, 2020
Closed
4 tasks
This was referenced Aug 25, 2020
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 2, 2020 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33012/
QUIC-CI: https://ci.nodejs.org/job/node-test-commit/40566/

@aduh95
Copy link
Contributor

aduh95 commented Nov 8, 2020

@jasnell is it ready to land?

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34191/

@jasnell jasnell marked this pull request as draft November 8, 2020 14:12
@jasnell
Copy link
Member Author

jasnell commented Nov 8, 2020

I'll be working on the quic stuff again in a few weeks

@jasnell jasnell closed this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @aduh95 @lundibundi @richardlau