Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: support AbortSignal in QuicSocket connect/listen #34908

Closed
wants to merge 7 commits into from
Closed

quic: support AbortSignal in QuicSocket connect/listen #34908

wants to merge 7 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 24, 2020 •
edited
Loading

This builds on #34865, which must land first (the first five commits are from that PR)

This does two things:

  • Minor cleanups on http3 native internals
  • Adds support for AbortSignal in QuicSocket connect and listen
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

jasnell added 5 commits August 24, 2020 10:31
@jasnell
quic: resolve http3 header todo
4acbbc6 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: resolve debug output todo
86111d6 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: clarify and resolve todo comment
1e78da1 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: remove unneeded TODO comment
aaaa51f 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
deps: fixup win arm64 build for ngtcp2/nghttp3
097e960
@jasnell jasnell requested a review from a team August 24, 2020 19:24
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 24, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

jasnell added 2 commits August 24, 2020 12:24
@jasnell
quic: minor cleanups to http3 internals
dccf7bb 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
quic: support AbortSignal in QuicSocket connect/listen
d2c8ebf 
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell added dont-land-on-v14.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Aug 28, 2020
@aduh95
Copy link
Contributor

aduh95 commented Nov 8, 2020

Is this ready to land?

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34192/

@jasnell jasnell marked this pull request as draft November 8, 2020 14:11
@jasnell
Copy link
Member Author

jasnell commented Nov 8, 2020

No, moving this back to draft. I'll be working on the quic stuff again within a few weeks.

@jasnell jasnell closed this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @aduh95 @benjamingr