Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x] deps: V8: backport 3f071e3e7e15 #35039

Closed
wants to merge 1 commit into from
Closed

[v14.x] deps: V8: backport 3f071e3e7e15 #35039

wants to merge 1 commit into from

Conversation

miladfarca
Copy link
Contributor

@miladfarca miladfarca commented Sep 3, 2020 •
edited
Loading

Original commit message:

PPC: Optimize clearing higher bits of mulhw/mulhwu

Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#69343}

Refs: v8/v8@3f071e3

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

deps: V8: backport 3f071e3e7e15
f878b6b 
Original commit message:

    PPC: Optimize clearing higher bits of mulhw/mulhwu

    Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468
    Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#69343}

Refs: v8/v8@3f071e3
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v14.x v8 engine Issues and PRs related to the V8 dependency. labels Sep 3, 2020
@miladfarca miladfarca mentioned this pull request Sep 3, 2020
Closed
@richardlau richardlau changed the title deps: V8: backport 3f071e3e7e15 [v14.x] deps: V8: backport 3f071e3e7e15 Sep 3, 2020
@richardlau
Copy link
Member

I think this is almost the same as #35036 (in terms of the line numbers of the changed lines) apart from the mismatch in v8_embedder_string (I actually believe we've missed a bump somewhere in v14.x). Let's try to land #35036 on master first and then try to cherry-pick it across to 14.x. If it cherry-picks cleanly we can close this backport PR.

@richardlau
Copy link
Member

I was able to cherry-pick b460c5c over to v14.x-staging as b6cbb7b with only the expected conflict with the v8_embedder_string which I fixed.

@richardlau richardlau closed this Sep 7, 2020
@miladfarca
Copy link
Contributor Author

@richardlau Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshCripps AshCripps AshCripps approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miladfarca @richardlau @BethGriggs @AshCripps @nodejs-github-bot