Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: backport 3f071e3e7e15 #35036

Closed
wants to merge 0 commits into from
Closed

deps: V8: backport 3f071e3e7e15 #35036

wants to merge 0 commits into from

Conversation

miladfarca
Copy link
Contributor

@miladfarca miladfarca commented Sep 3, 2020 •
edited
Loading

Original commit message:

PPC: Optimize clearing higher bits of mulhw/mulhwu

Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#69343}

Refs: v8/v8@3f071e3

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Sep 3, 2020
@miladfarca miladfarca mentioned this pull request Sep 3, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2020 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33040/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3334/ (✔️)

@richardlau richardlau mentioned this pull request Sep 3, 2020
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33041/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 4, 2020 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33055/ (✔️)

@codebytere
Copy link
Member

@richardlau i see dont-land-on and backport-open labels for v12.x and v14.x that conflict with each other; is this intended to go back?

@richardlau
Copy link
Member

@codebytere See #35038 for the backport for v12.x. @miladfarca opened the backports at the same time as this one. Probably thinking about it again we can remove the dont-land labels.

@Trott Trott closed this Sep 5, 2020
@Trott
Copy link
Member

Trott commented Sep 5, 2020

Landed in b460c5c

targos pushed a commit to targos/node that referenced this pull request Sep 7, 2020
@targos
deps: V8: backport 3f071e3e7e15
65f6fa7 
Original commit message:

    PPC: Optimize clearing higher bits of mulhw/mulhwu

    Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468
    Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#69343}

Refs: v8/v8@3f071e3

PR-URL: nodejs#35036
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@richardlau
deps: V8: backport 3f071e3e7e15
b6cbb7b 
Original commit message:

    PPC: Optimize clearing higher bits of mulhw/mulhwu

    Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468
    Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#69343}

Refs: v8/v8@3f071e3

PR-URL: #35036
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@richardlau
deps: V8: backport 3f071e3e7e15
96ae05a 
Original commit message:

    PPC: Optimize clearing higher bits of mulhw/mulhwu

    Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468
    Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#69343}

Refs: v8/v8@3f071e3

PR-URL: #35036
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau richardlau mentioned this pull request Sep 22, 2020
Closed
4 tasks
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@joesepi
deps: V8: backport 3f071e3e7e15
9158a71 
Original commit message:

    PPC: Optimize clearing higher bits of mulhw/mulhwu

    Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468
    Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#69343}

Refs: v8/v8@3f071e3

PR-URL: nodejs#35036
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshCripps AshCripps AshCripps approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@miladfarca @nodejs-github-bot @codebytere @richardlau @Trott @BethGriggs @AshCripps @MylesBorins @addaleax