Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: adjust validation to account for buffer.kMaxLength #35134

Closed
wants to merge 1 commit into from
Closed

buffer: adjust validation to account for buffer.kMaxLength #35134

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 9, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Sep 9, 2020
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 9, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33119/ (:green_heart:)

@addaleax addaleax requested a review from jasnell September 11, 2020 08:25
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2020
@github-actions
Copy link
Contributor

Landed in 3c56463

@github-actions github-actions bot closed this Sep 12, 2020
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2020
@addaleax @nodejs-github-bot
buffer: adjust validation to account for buffer.kMaxLength
3c56463 
PR-URL: #35134
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2020
@addaleax @ruyadorno
buffer: adjust validation to account for buffer.kMaxLength
5229ffa 
PR-URL: #35134
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
@addaleax addaleax deleted the buffer-validation-uint32 branch October 12, 2020 10:40
@addaleax addaleax mentioned this pull request Oct 12, 2020
Closed
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@addaleax @joesepi
buffer: adjust validation to account for buffer.kMaxLength
3969298 
PR-URL: nodejs#35134
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @jasnell @BridgeAR @ZYSzys