V14.12.0 proposal #35285
Merged
V14.12.0 proposal #35285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a bad value is assigned to EventEmitter.defaultMaxListener, a RangeError is thrown and not a TypeError. Update documentation to reflect this. PR-URL: #35069 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: #35059 PR-URL: #35066 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This reverts commit 07423b5. Refs: #35002 (comment) PR-URL: #35094 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
We need to emit dependency of ICU's toASCII in order to update the WPT fixtures. Since ICU and URL isn't the same implementation and they also follow different specifications. ICU's toASCII shouldn't have a dependency on WPT fixtures. Refs: #33770 (comment) PR-URL: #35077 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* sort references in ASCII order * replace abbreviation * split comma splice into two sentences and add appropriate punctuation * replace future tense with present tense PR-URL: #35083 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #35080 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Previously, the crypto.randomInt() message when "max" was less than or equal to "min" made it sound like the lower bound for "max" was hard-coded. Make it clear that it is instead dynamic based on the value of "min". For crypto.randomInt(10,0): Before: RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It must be > 10. Received 0 After: RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It must be greater than the value of "min" (10). Received 0 PR-URL: #35088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Use "must be a safe integer" rather than "must be safe integer". I believe the former is more easily understood/clear. PR-URL: #35089 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This improves readability, as well as awkward reptition of the word _while_ with two different meanings in a single sentence. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while PR-URL: #35078 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
PR-URL: #35065 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
* eliminate unneeded Set deletion/cleanup * use number of CPUs as limit for processes spawned rather than hard-coding the limit PR-URL: #35101 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
PR-URL: #35109 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #35111 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #35112 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #35113 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Refs: #35098 (comment) PR-URL: #35106 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #35117 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
- update security process to reflect current way to request tweet/retweet of security release Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #35107 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Notable changes: - Several issues have been addressed in uvwasi_fd_readdir(). A bug in the copying of the directory entry's name has been fixed. The function now returns UVWASI_ENOSYS on Windows and Android. Serdes support has been added for uvwasi_dirent_t's. - The libuv dependency has been updated to v1.39.0. PR-URL: #35104 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #35143 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Update email address to reflect move to Red Hat Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #35121 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Because of the condition that starts the `if` block, we know that `parentPath` must be truthy. So there is no need to check for that in the template string that generates the error message. PR-URL: #35123 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
PR-URL: #35126 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #35160 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #35134 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
PR-URL: #35139 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Sep 21, 2020
Error messages are a mix of present and past tense. They should be mostly or entirely present tense. This eliminates the past tense constructions "was found" and "were found". Backport-PR-URL: #35247 PR-URL: #35164 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno
force-pushed
the
v14.12.0-proposal
branch
from
5a94f69 to
efd5c83
Compare
This comment has been minimized.
This comment has been minimized.
|
Can #34015 or just 4b3654e be backported? See websockets/ws#1795. cc: @benjamingr @jasnell |
|
@targos yes but the issue is on Node.js 12. Node.js 14 is ok. I wonder if the event target fixes will ever be backported to Node.js 12. |
|
Ok, I understand what you're asking for, but this release proposal is for Node.js 14. |
|
Oh wow, sorry. I have not fully woken up yet. |
|
It would be great to have #35191 as it fixes a few broken links in the docs. |
richardlau
approved these changes
Sep 22, 2020
This comment has been minimized.
This comment has been minimized.
|
hi @aduh95 sorry but I think it's a bit too late for that one to land in time for this release 😊 |
BethGriggs
approved these changes
Sep 22, 2020
MylesBorins
approved these changes
Sep 22, 2020
ruyadorno
added a commit
that referenced
this pull request
Sep 22, 2020
ruyadorno
added a commit
to ruyadorno/nodejs.org
that referenced
this pull request
Sep 22, 2020
MylesBorins
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 22, 2020
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Notable changes: - deps: - update to uvwasi 0.0.11 (Colin Ihrig) [nodejs#35104](nodejs#35104) - n-api: - create N-API version 7 (Gabriel Schulhof) [nodejs#35199](nodejs#35199) - add more property defaults (Gerhard Stoebich) [nodejs#35214](nodejs#35214) PR-URL: nodejs#35285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2020-09-22, Version 14.12.0 (Current), @ruyadorno
Notable changes
Commits
5229ffadcf] - buffer: adjust validation to account for buffer.kMaxLength (Anna Henningsen) #351343d78686987] - build: increase API requests for stale action (Phillip Johnsen) #35235f2cc1c22c1] - build: filter issues & PRs to auto close by matching on stalled label (Phillip Johnsen) #35159f3c45a1cef] - Revert "build: require "allow edits" to be checked" (Rich Trott) #350941bb0ed3c6a] - crypto: improve invalid arg type message for randomInt() (Rich Trott) #350893573545315] - crypto: improve randomInt out-of-range error message (Rich Trott) #35088d4389b59b4] - deps: update to uvwasi 0.0.11 (Colin Ihrig) #35104836680a4ea] - doc: use present tense in error messages (Rich Trott) #35164b860a7f61c] - doc: standardize on _backward_ (Rich Trott) #35243d82dd0c773] - doc: revise stability section of values doc (Rich Trott) #352422bc335dcf6] - doc: clarify napi_property_attributes text (Rich Trott) #35253b62d9b47be] - doc: remove excessive formatting in dgram.md (Rich Trott) #35234b9161f408f] - doc: sort repl references in ASCII order (Rich Trott) #35230d195d20dbc] - doc: relax prohibition on personal pronouns (Rich Trott) #343536119e9511c] - doc: clarify use of NAPI_EXPERIMENTAL (Michael Dawson) #351956d4ab36175] - doc: update attributes used by n-api samples (doc: update attributes used by n-api samples #35220) (Gerhard Stoebich)7610fe500e] - doc: add issue labels sections to release guide (Michaël Zasso) #352242308be06b3] - doc: fix header level for error code (Rich Trott) #3521964ac5c68aa] - doc: fix small grammatical issues in timers.md (Turner Jabbour) #3520392a14d3c72] - doc: add technical values document (Michael Dawson) #35145dbfd3b261d] - doc: remove "end user" (Rich Trott) #35200c1c93a6cde] - doc: use command-line/command line consistently (Rich Trott) #3519870ec369b76] - doc: replace "you should do X" with "do X" (Rich Trott) #35194e5fffe2f8f] - doc: fix missing word in dgram.md (Tom Atkinson) #35231c1e16d15dd] - doc: fix deprecation documentation inconsistencies (Antoine du HAMEL) #35082910deff2de] - doc: fix broken link in crypto.md (Rich Trott) #35181066148d229] - doc: remove problematic auto-linking of curl man pages (Rich Trott) #35174aea3f77c8d] - doc: update eventLoopUtilization documentation (Anna Henningsen) #3515532d1731ae1] - doc: update process.release (schamberg97) #35167176e9e4054] - doc: fix broken links in modules.md (Rich Trott) #35182dc4c5696da] - doc: add missing copyFile change history (Shelley Vohr) #35056e8d479ed67] - doc: perform cleanup on security-release-process.md (Rich Trott) #3515499785e48ea] - doc: fix minor punctuation issue in path.md (Amila Welihinda) #35127ae85228e54] - doc: perform minor cleanup on cli.md (Rich Trott) #35152e4105140e7] - doc: improve table accessibility (Rich Trott) #351467dbcd24541] - doc: fix left nav color contrast (Rich Trott) #35141331142ca25] - doc: update contact info for Ash Cripps (Ash Cripps) #35139df70861863] - doc: simplify circular dependencies text in modules.md (Rich Trott) #35126f4e714aaf5] - doc: update my email address (Michael Dawson) #3512146b9f4b376] - doc: add missing changes entry for breakEvalOnSigint REPL option (Anna Henningsen) #35143122edad98b] - doc: update security process (Michael Dawson) #35107aa93c1c22d] - doc: fix broken link in perf_hooks.md (Rich Trott) #351135c8d2083c5] - doc: fix broken link in http2.md (Rich Trott) #35112f4e958fc0c] - doc: fix broken link in fs.md (Rich Trott) #3511179c6d92e49] - doc: fix broken links in deprecations.md (Rich Trott) #3510993e4d545d8] - doc: add note about path.basename on Windows (Tobias Nießen) #350650a2610a7aa] - doc: avoid double-while sentence in perf_hooks.md (Rich Trott) #350781cf9934e4e] - doc: make minor improvements to module.md (Rich Trott) #35083fb89be63be] - doc: use correct Error type for EventEmitter.defaultMaxListener (Rich Trott) #35069b75822dd93] - doc,test: specify and test CLI option precedence rules (Anna Henningsen) #351064bde865145] - errors: simplify ERR_REQUIRE_ESM message generation (Rich Trott) #351236e622d6337] - esm: better package.json parser errors (Guy Bedford) #35117beb75bd031] - fs: loosen validation to allow objects with an own toString function (Jordan Harband) #349938ea28536d0] - http: only set keep-alive when not exists (atian25@qq.com) #35138977b0ed865] - http: allow Content-Length header for 304 responses (Arnaud Lefebvre) #34835d8b57140b4] - https: set requestTimeout default to 0 (Robert Nagy) #3526412f2934224] - meta: add links to OpenJSF Slack (Mary Marchini) #35128f21a5c6200] - meta: update my collab entry (devsnek) #3516076e24f9aa9] - module: use isURLInstance instead of instanceof (Antoine du HAMEL) #34951314483cd09] - module: fix specifier resolution option value (himself65) #35098ca1181615e] - (SEMVER-MINOR) n-api: create N-API version 7 (Gabriel Schulhof) #351997f3b2b2a1f] - (SEMVER-MINOR) n-api: add more property defaults (Gerhard Stoebich) #352144f4faa8e3c] - readline: fix key name for function keys with modifiers (DrunkenPoney) #35268e29e2daf4c] - test: improve assertions in pummel/test-timers (Rich Trott) #352168357b56984] - test: add wasi readdir() test (Colin Ihrig) #3520249da459ce6] - test: improve pummel/test-timers.js (Rich Trott) #35175379c5cefd7] - test: revise test-policy-integrity (Rich Trott) #351016627c1f8e4] - test: remove setMaxListeners in test-crypto-random (Tobias Nießen) #35079bc38485fb1] - test: fix comment about DNS lookup test (Tobias Nießen) #350809faaa659b2] - test: separate the test fixtures between ICU and URL (Leko) #3507725f93f3ec3] - test: add more valid results to test-trace-atomics-wait (Anna Henningsen) #350660a97f44b50] - tools: update ESLint to 7.9.0 (Colin Ihrig) #35170cc @nodejs/releasers
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes