Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix broken link in crypto.md #35181

Merged
merged 1 commit into from
Sep 16, 2020
Merged

doc: fix broken link in crypto.md #35181

merged 1 commit into from
Sep 16, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 14, 2020

URL that lacks a scheme gets treated as a relative URL. Add missing
https://.

Checklist

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Sep 14, 2020
@Trott Trott merged commit 3aab64c into nodejs:master Sep 16, 2020
@Trott
Copy link
Member Author

Trott commented Sep 16, 2020

Landed in 3aab64c

@Trott Trott deleted the ironic branch September 16, 2020 13:11
URL that lacks a scheme gets treated as a relative URL. Add missing
`https://`.

PR-URL: nodejs#35181
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
URL that lacks a scheme gets treated as a relative URL. Add missing
`https://`.

PR-URL: #35181
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
URL that lacks a scheme gets treated as a relative URL. Add missing
`https://`.

PR-URL: #35181
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
URL that lacks a scheme gets treated as a relative URL. Add missing
`https://`.

PR-URL: nodejs#35181
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants