Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,tools: enforce access to prototype from primordials #36025

Merged
merged 1 commit into from
Nov 14, 2020
Merged

lib,tools: enforce access to prototype from primordials #36025

merged 1 commit into from
Nov 14, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 7, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
@aduh95 aduh95 requested a review from Leko November 7, 2020 16:41
@nodejs-github-bot nodejs-github-bot added process Issues and PRs related to the process subsystem. tools Issues and PRs related to the tools directory. labels Nov 7, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Nov 7, 2020
Merged
Closed
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2020
@aduh95 aduh95 force-pushed the prototype-primordials branch from 0c56e81 to 6d364f8 Compare November 9, 2020 09:47
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 force-pushed the prototype-primordials branch from 249ca96 to 07bab9c Compare November 10, 2020 09:24
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott Trott requested a review from guybedford November 11, 2020 13:27
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 11, 2020 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34336/ ✅

@aduh95 @Trott
lib,tools: enforce access to prototype from primordials
5c3944f 
PR-URL: nodejs#36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott force-pushed the prototype-primordials branch from 26c722d to 5c3944f Compare November 14, 2020 13:57
@Trott
Copy link
Member

Trott commented Nov 14, 2020

Landed in 5c3944f

@Trott Trott merged commit 5c3944f into nodejs:master Nov 14, 2020
@aduh95 aduh95 deleted the prototype-primordials branch November 14, 2020 14:24
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@aduh95 @codebytere
lib,tools: enforce access to prototype from primordials
75707f4 
PR-URL: #36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
targos pushed a commit that referenced this pull request May 16, 2021
@aduh95 @targos
lib,tools: enforce access to prototype from primordials
483c1a1 
PR-URL: #36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
lib,tools: enforce access to prototype from primordials
b3e22e1 
PR-URL: #36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leko Leko Leko approved these changes

@Trott Trott Trott approved these changes

@guybedford guybedford Awaiting requested review from guybedford

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. process Issues and PRs related to the process subsystem. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @Trott @Leko