Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.3.0 proposal #36232

Merged
merged 98 commits into from
Nov 24, 2020
Merged

v15.3.0 proposal #36232

merged 98 commits into from
Nov 24, 2020

Conversation

codebytere
Copy link
Member

2020-11-24, Version 15.3.0 (Current), @codebytere

Notable Changes

  • [6349b1d673] - (SEMVER-MINOR) dns: add a cancel() method to the promise Resolver (Szymon Marczak) #33099
  • [9ce9b016e6] - (SEMVER-MINOR) events: add max listener warning for EventTarget (James M Snell) #36001
  • [8390f8a86b] - (SEMVER-MINOR) http: add support for abortsignal to http.request (Benjamin Gruenbaum) #36048
  • [9c6be3cc90] - (SEMVER-MINOR) http2: allow setting the local window size of a session (Yongsheng Zhang) #35978
  • [15ff155c12] - (SEMVER-MINOR) lib: add throws option to fs.f/l/statSync (Andrew Casey) #33716
  • [85c85d368a] - (SEMVER-MINOR) path: add path/posix and path/win32 alias modules (ExE Boss) #34962
  • [d1baae3640] - (SEMVER-MINOR) readline: add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675
  • [5729478509] - (SEMVER-MINOR) src: add loop idle time in diagnostic report (Gireesh Punathil) #35940
  • [baa87c1a7d] - (SEMVER-MINOR) util: add util/types alias module (ExE Boss) #34055

Commits

  • [34aa0c868e] - assert: refactor to use more primordials (Antoine du Hamel) #35998
  • [28d710164a] - async_hooks: refactor to use more primordials (Antoine du Hamel) #36168
  • [1924255fdb] - async_hooks: fix leak in AsyncLocalStorage exit (Stephen Belanger) #35779
  • [3ee556a867] - benchmark: fix build warnings (Gabriel Schulhof) #36157
  • [fcc38a1312] - build: replace which with command -v (raisinten) #36118
  • [60874ba941] - build: try “python3” as a last resort for 3.x (Ole André Vadla Ravnås) #35983
  • [fbe210b2a1] - build: conditionally clear vcinstalldir (Brian Ingenito) #36009
  • [56f83e6876] - build: refactor configure.py to use argparse (raisinten) #35755
  • [0b70822461] - child_process: refactor to use more primordials (Antoine du Hamel) #36003
  • [e54108f2e4] - cluster: refactor to use more primordials (Antoine du Hamel) #36011
  • [272fc794b2] - crypto: fix format warning in AdditionalConfig (raisinten) #36060
  • [63a138e02f] - crypto: fix passing TypedArray to webcrypto AES methods (Antoine du Hamel) #36087
  • [c23ee3744f] - deps: upgrade npm to 7.0.12 (Ruy Adorno) #36153
  • [0fcbb1c0d5] - deps: V8: cherry-pick 3176bfd447a9 (Anna Henningsen) #35612
  • [27f1bc05fd] - deps: upgrade npm to 7.0.11 (Darcy Clarke) #36112
  • [8ae3ffe2be] - deps: V8: cherry-pick 1d0f426311d4 (Ole André Vadla Ravnås) #35986
  • [4b7ba11d67] - deps: V8: cherry-pick 4e077ff0444a (Ole André Vadla Ravnås) #35986
  • [098a5b1298] - deps: V8: cherry-pick 086eecbd96b6 (Ole André Vadla Ravnås) #35986
  • [d2c757ab19] - deps: V8: cherry-pick 27e1ac1a79ff (Ole André Vadla Ravnås) #35986
  • [6349b1d673] - (SEMVER-MINOR) dns: add a cancel() method to the promise Resolver (Szymon Marczak) #33099
  • [0fbade38ef] - doc: add arm64 macOS as experimental (Richard Lau) #36189
  • [42dfda8f78] - doc: remove stray comma in url.md (Rich Trott) #36175
  • [8bbdbccbb6] - doc: revise agent.destroy() text (Rich Trott) #36163
  • [545ac1fec5] - doc: fix punctuation in v8.md (Rich Trott) #36192
  • [a6a90af8c0] - doc: add compatibility/interop technical value (Geoffrey Booth) #35323
  • [4ab4a99900] - doc: de-emphasize wrapping in napi_define_class (Gabriel Schulhof) #36159
  • [bb29508e8f] - doc: add link for v8.takeCoverage() (Rich Trott) #36135
  • [24065b92f1] - doc: mark modules implementation as stable (Guy Bedford) #35781
  • [142cacdc63] - doc: clarify text about process not responding (Rich Trott) #36117
  • [0ff384b0be] - doc: esm docs consolidation and reordering (Guy Bedford) #36046
  • [b17a83a00d] - doc: claim ABI version for Electron v13 (Shelley Vohr) #36101
  • [e8a8513b2c] - doc: fix invalid link in worker_threads.md (Rich Trott) #36109
  • [cd33594a0d] - doc: move shigeki to emeritus (Rich Trott) #36093
  • [eefc6aa6c9] - doc: document the error when cwd not exists in child_process.spawn (FeelyChau) #34505
  • [841a2812d0] - doc: fix typo in debugger.md (Rich Trott) #36066
  • [500e709439] - doc: update list styles for remark-parse@9 rendering (Rich Trott) #36049
  • [a8dab217eb] - doc,url: fix url.hostname example (Rishabh Mehan) #33735
  • [e48ec703ba] - domain: improve deprecation warning text for DEP0097 (Anna Henningsen) #36136
  • [bcbf176c22] - errors: refactor to use more primordials (Antoine du Hamel) #36167
  • [66788970ac] - esm: refactor to use more primordials (Antoine du Hamel) #36019
  • [9ce9b016e6] - (SEMVER-MINOR) events: add max listener warning for EventTarget (James M Snell) #36001
  • [1550073dbc] - events: disabled manual construction AbortSignal (raisinten) #36094
  • [8a6cabbb23] - events: port some wpt tests (Ethan Arrowood) #34169
  • [3691eccf0a] - fs: remove experimental from promises.rmdir recursive (Anders Kaseorg) #36131
  • [76b1863240] - fs: filehandle read now accepts object as argument (Nikola Glavina) #34180
  • [2fdf509268] - http: fix typo in comment (Hollow Man) #36193
  • [8390f8a86b] - (SEMVER-MINOR) http: add support for abortsignal to http.request (Benjamin Gruenbaum) #36048
  • [387d92fd0e] - http: onFinish will not be triggered again when finished (rickyes) #35845
  • [48bf59bb8b] - http2: add support for AbortSignal to http2Session.request (Madara Uchiha) #36070
  • [8a0c3b9c76] - http2: refactor to use more primordials (Antoine du Hamel) #36142
  • [f0aed8c01c] - http2: add support for TypedArray to getUnpackedSettings (Antoine du Hamel) #36141
  • [9c6be3cc90] - (SEMVER-MINOR) http2: allow setting the local window size of a session (Yongsheng Zhang) #35978
  • [0b40568afe] - http2: delay session.receive() by a tick (Szymon Marczak) #35985
  • [1a4d43f840] - lib: refactor to use more primordials (Antoine du Hamel) #36140
  • [d6ea12e003] - lib: set abort-controller toStringTag (Benjamin Gruenbaum) #36115
  • [82f1cde57e] - lib: remove primordials.SafePromise (Antoine du Hamel) #36149
  • [15ff155c12] - (SEMVER-MINOR) lib: add throws option to fs.f/l/statSync (Andrew Casey) #33716
  • [75707f45eb] - lib,tools: enforce access to prototype from primordials (Antoine du Hamel) #36025
  • [79b2ba6744] - n-api: clean up binding creation (Gabriel Schulhof) #36170
  • [5698cc08f0] - n-api: fix test_async_context warnings (Gabriel Schulhof) #36171
  • [3d623d850c] - n-api: improve consistency of how we get context (Michael Dawson) #36068
  • [89da0c3353] - n-api: factor out calling pattern (Gabriel Schulhof) #36113
  • [5c0ddbca01] - net: fix invalid write after end error (Robert Nagy) #36043
  • [85c85d368a] - (SEMVER-MINOR) path: add path/posix and path/win32 alias modules (ExE Boss) #34962
  • [ed8af3a8b7] - perf_hooks: make nodeTiming a first-class object (Momtchil Momtchev) #35977
  • [eb9295b583] - promise: emit error on domain unhandled rejections (Benjamin Gruenbaum) #36082
  • [59af919d6b] - querystring: reduce memory usage by Int8Array (sapics) #34179
  • [d1baae3640] - (SEMVER-MINOR) readline: add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675
  • [6d1b1c7ad0] - src: integrate URL::href() and use in inspector (Daijiro Wachi) #35912
  • [7086f2e653] - src: refactor using-declarations node_env_var.cc (raisinten) #36128
  • [122797e87f] - src: remove duplicate logic for getting buffer (Yash Ladha) #34553
  • [5729478509] - (SEMVER-MINOR) src: add loop idle time in diagnostic report (Gireesh Punathil) #35940
  • [a81dc9ae18] - src,crypto: refactoring of crypto_context, SecureContext (James M Snell) #35665
  • [5fa35f6934] - test: update comments in test-fs-read-offset-null (Rich Trott) #36152
  • [73bb54af77] - test: update wpt url and resource (Daijiro Wachi) #36032
  • [77b47dfd08] - test: fix typo in inspector-helper.js (Luigi Pinca) #36127
  • [474664963c] - test: deflake test-http-destroyed-socket-write2 (Luigi Pinca) #36120
  • [f9bbd35937] - test: make test-http2-client-jsstream-destroy.js reliable (Rich Trott) #36129
  • [c19df17acb] - test: add test for fs.read when offset key is null (mayank agarwal) #35918
  • [9405cddbee] - test: improve test-stream-duplex-readable-end (Luigi Pinca) #36056
  • [3be5e86c57] - test: add util.inspect test for null maxStringLength (Rich Trott) #36086
  • [6a4cc43028] - test: replace var with const (Aleksandr Krutko) #36069
  • [a367c0dfc2] - timers: refactor to use more primordials (Antoine du Hamel) #36132
  • [a6ef92bc27] - tools: bump unist-util-find@1.0.1 to unist-util-find@1.0.2 (Rich Trott) #36106
  • [2d2491284e] - tools: only use 2 cores for macos action (Myles Borins) #36169
  • [d8fcf2c324] - tools: remove bashisms from license builder script (Antoine du Hamel) #36122
  • [7e7ddb11c0] - tools: hide commit queue action link (Antoine du Hamel) #36124
  • [63494e434a] - tools: update doc tools to remark-parse@9.0.0 (Rich Trott) #36049
  • [bf0550ce4e] - tools: enforce use of single quotes in editorconfig (Antoine du Hamel) #36020
  • [49649a499e] - tools: fix config serialization w/ long strings (Ole André Vadla Ravnås) #35982
  • [be220b213d] - tools: update ESLint to 7.13.0 (Luigi Pinca) #36031
  • [4140f491fd] - util: fix to inspect getters that access this (raisinten) #36052
  • [baa87c1a7d] - (SEMVER-MINOR) util: add util/types alias module (ExE Boss) #34055
  • [f7b2fce1c1] - vm: refactor to use more primordials (Antoine du Hamel) #36023
  • [4e3883ec2d] - win,build,tools: support VS prerelease (Baruch Odem) #36033

ExE-Boss and others added 30 commits November 22, 2020 10:18
Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002
Refs: #34055

PR-URL: #34962
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002

PR-URL: #34055
Refs: #34962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Since there is a setPrompt() there should be a getPrompt().
There are use-cases where it is needed to know what the
current prompt is. Adding a getPrompt() negates the need
to store the set prompt externally or read the internal
_prompt which would be bad practice.

Co-authored-by: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #33675
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #34179
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Don't error if not ended.

Fixes: #36029

PR-URL: #36043
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add WPT AddEventListenerOptions-once test.

PR-URL: #34169
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Update ESLint to 7.13.0

PR-URL: #36031
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
If exit is called and then run or enterWith are called within the
exit function, the als instace should not be added to the storageList
additional times. The correct behaviour is to remove the instance
from the storageList before executing the exit handler and then to
restore it after.

PR-URL: #35779
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #35985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #35978
Fixes: #31084
Refs: #26962
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Cleaup and improvement of crypto_context and SecureContext.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35665
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
So that “config.gypi” gets serialized correctly in cases such as:

    ./configure --v8-options='--write-protect-code-memory \
    --wasm-write-protect-code-memory'

Where “v8_options” gets prettyprinted into a multiline string.

PR-URL: #35982
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
remark-parse@9.0.0 combined with our html.js tool ends a list if a
multi-line item does not include indentation. Update our docs for this
formatting.

I looked around for a lint rule to enforce this but didn't find one
readily available. (Happy to be shown that I'm wrong about that!) We may
need to write one.

PR-URL: #36049
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #36049
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Fixes: #36045

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #36052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Original commit message:

    [wasm][mac] Support w^x codespaces for Apple Silicon

    Apple's upcoming arm64 devices will prevent rwx access to memory,
    but in turn provide a new per-thread way to switch between write
    and execute permissions. This patch puts that system to use for
    the WebAssembly subsystem.
    The approach relies on CodeSpaceWriteScope objects for now. That
    isn't optimal for background threads (which could stay in "write"
    mode permanently instead of toggling), but its simplicity makes
    it a good first step.

    Background:
    https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon

    Bug: chromium:1117591
    Change-Id: I3b60f0efd34c0fed924dfc71ee2c7805801c5d42
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2378307
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69791}

PR-URL: #35986
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Original commit message:

    [platform] Add Permission::kNoAccessWillJitLater enum value

    This value is unused for now. This CL is part 1 of a 3-step dance.
    Part 2 will be teaching Chrome's Platform implementation to accept
    the new value. Part 3 will then actually use it in V8.

    Bug: chromium:1117591
    Change-Id: Ie3aed20d4cc58f3def3be2a3a03bba4c3a37bf44
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2450056
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70335}

PR-URL: #35986
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Original commit message:

    [mac] Set MAP_JIT only when necessary

    This is a "minimal" change to achieve the required goal: seeing that
    there is only one place where we need to indicate that memory should
    be reserved with MAP_JIT, we can add a value to the Permissions enum
    instead of adding a second, orthogonal parameter.
    That way we avoid changing public API functions, which makes this CL
    easier to undo once we have platform-independent w^x in Wasm.

    Bug: chromium:1117591
    Change-Id: I6333d69ab29d5900c689f08dcc892a5f1c1159b8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435365
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70379}

PR-URL: #35986
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Original commit message:

    [mac-arm64] Fix missing #include

    For an "#if defined(MAP_JIT)" test to work as expected, <sys/mman.h>
    must be included in the compilation unit.

    Bug: chromium:1144200
    Change-Id: Ia0bf35ec1872c02457f1fbc0ee6689c7f7d27d4a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517689
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70986}

PR-URL: #35986
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #35845
Fixes: #35833
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: #26725
Fixes: #29813
Refs: #29814

PR-URL: #35755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Add libuv's cumulative idle time in the diagnostic report.
Add the data under the libuv's loop section

Refs: #34938
PR-URL: #35940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Use apostrophe for possessive.

PR-URL: #36066
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Replace `var` with `const` in vm context for test-util-inspect.js.

PR-URL: #36069
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
For scenario where target env is explicitly specified as vs2019, do
not clear VCINSTALLDIR which was being cleared to handle fallback to
vs2017 block when attempting to find a matching available VS.

Fixes: #35856

PR-URL: #36009
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
We were fetching the buffer from the float array to send out the
response in js land, however that logic is being duplicated in
node_process.h. Now they will be using an inline to fetch the array
buffers and making it more generic.

PR-URL: #34553
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #35998
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36003
Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: https://www.w3.org/TR/WebCryptoAPI/#subtlecrypto-interface
Fixes: #36083

PR-URL: #36087
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. tools Issues and PRs related to the tools directory. labels Nov 22, 2020
@nodejs nodejs deleted a comment from nodejs-github-bot Nov 23, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 23, 2020

PR-URL: #36202
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

PR-URL: #36238
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message for the release commit still has TODO for the PR-URL.

Notable changes:

dns:
  * (SEMVER-MINOR) add a cancel() method to the promise Resolver (Szymon Marczak) #33099
events:
  * (SEMVER-MINOR) add max listener warning for EventTarget (James M Snell) #36001
http:
  * (SEMVER-MINOR) add support for abortsignal to http.request (Benjamin Gruenbaum) #36048
http2:
  * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978
lib:
  * (SEMVER-MINOR) add throws option to fs.f/l/statSync (Andrew Casey) #33716
path:
  * (SEMVER-MINOR) add `path/posix` and `path/win32` alias modules (ExE Boss) #34962
readline:
  * (SEMVER-MINOR) add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675
src:
  * (SEMVER-MINOR) add loop idle time in diagnostic report (Gireesh Punathil) #35940
util:
  * (SEMVER-MINOR) add `util/types` alias module (ExE Boss) #34055

PR-URL: #36232
@nodejs-github-bot
Copy link
Collaborator

@bricss
Copy link

bricss commented Nov 24, 2020

Maybe it's yet possible to squeeze this #36238 in? 🙄

@codebytere codebytere merged commit 63e7dc1 into v15.x Nov 24, 2020
codebytere added a commit that referenced this pull request Nov 24, 2020
codebytere added a commit that referenced this pull request Nov 24, 2020
Notable changes:

dns:
  * (SEMVER-MINOR) add a cancel() method to the promise Resolver (Szymon Marczak) #33099
events:
  * (SEMVER-MINOR) add max listener warning for EventTarget (James M Snell) #36001
http:
  * (SEMVER-MINOR) add support for abortsignal to http.request (Benjamin Gruenbaum) #36048
http2:
  * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978
lib:
  * (SEMVER-MINOR) add throws option to fs.f/l/statSync (Andrew Casey) #33716
path:
  * (SEMVER-MINOR) add `path/posix` and `path/win32` alias modules (ExE Boss) #34962
readline:
  * (SEMVER-MINOR) add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675
src:
  * (SEMVER-MINOR) add loop idle time in diagnostic report (Gireesh Punathil) #35940
util:
  * (SEMVER-MINOR) add `util/types` alias module (ExE Boss) #34055

PR-URL: #36232
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Nov 24, 2020
@codebytere codebytere deleted the v15.3.0-proposal branch November 24, 2020 16:33
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Nov 24, 2020
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Nov 24, 2020
@ljharb
Copy link
Member

ljharb commented Nov 26, 2020

It seems like CIGTM tests for is-core-module would have been failing before this release :-/ i'm planning to release an update tomorrow to fix it, but it'd be great to get a ping in the future so i can do it in advance :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.