test: deflake test-http-destroyed-socket-write2 #36120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was failing before with timeouts on macOS, now it exits with 0. |
github-actions
bot
removed
the
request-ci
rickyes
reviewed
Nov 15, 2020
| }); | ||
| } | ||
| server.once(kResponseDestroyed, common.mustCall(function() { | ||
| req.write('hello'); |
There was a problem hiding this comment.
Is there a need for .mustCall here?
There was a problem hiding this comment.
Yes, otherwise there is no guarantee that the listener of the 'request' event added on line 33 is called.
There was a problem hiding this comment.
Anyway we can use common.mustCall() there (line 33) if it is easier to grok.
There was a problem hiding this comment.
I think I misunderstood. Do you mean adding a callback to this req.write()? If so, I think it is not needed. It's out of the scope of the test.
Trott
approved these changes
Nov 15, 2020
github-actions
bot
removed
the
request-ci
rickyes
approved these changes
Nov 16, 2020
Ensure that the write occurs in the same tick where the socket is destroyed by the other peer. PR-URL: nodejs#36120 Fixes: nodejs#36081 Fixes: nodejs#4066 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
|
Landed in e682814. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the write occurs in the same tick where the socket is
destroyed by the other peer.
Fixes: #36081
Fixes: #4066
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes