Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove primordials.SafePromise #36149

Merged
merged 1 commit into from
Nov 19, 2020
Merged

lib: remove primordials.SafePromise #36149

merged 1 commit into from
Nov 19, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 17, 2020

primordials.SafePromise is not used in core anymore, and async/await creates genuine Promise objects anyway.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95 aduh95 added lib / src Issues and PRs related to general changes in the lib or src directory. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 17, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34438/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2020
@aduh95 @Trott
lib: remove primordials.SafePromise
a46b21f 
PR-URL: nodejs#36149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the primordials-SafePromise branch from de2e461 to a46b21f Compare November 19, 2020 12:34
@Trott Trott merged commit a46b21f into nodejs:master Nov 19, 2020
@Trott
Copy link
Member

Trott commented Nov 19, 2020

Landed in a46b21f

@aduh95 aduh95 deleted the primordials-SafePromise branch November 19, 2020 12:59
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@aduh95 @codebytere
lib: remove primordials.SafePromise
82f1cde 
PR-URL: #36149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
lib: remove primordials.SafePromise
be537fe 
PR-URL: #36149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @Trott @lpinca @targos @joyeecheung