-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to 7.0.14 #36238
deps: upgrade npm to 7.0.14 #36238
Conversation
can we please fast-track? |
@codebytere please include this in tomorrow's 15.x release. I'll work on making sure it is landed. Failed tests are due to master being broken |
3da3d72
to
ede70d3
Compare
In an attempt to fix CI I've rebased out a couple of commits from master, fingers crossed that we can get a green CI |
Fix to CI issues has landed, so I'm running a fresh CI. Should be green or green-ish. I'll try to stay up until this lands. (It's not late here, but uh...yeah, I keep early hours these days.) |
ede70d3
to
7ccd2f9
Compare
rebased and kicked off another CI, hopefully fixes broken actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR-URL: #36238 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Landed in 767070c |
PR-URL: nodejs#36238 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
7.0.14 (2020-11-23)
DEPENDENCIES
09d21ab90
@npmcli/run-script@1.8.1