Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riscv: Add riscv into host_arch_cc #39004

Closed
wants to merge 2 commits into from
Closed

riscv: Add riscv into host_arch_cc #39004

wants to merge 2 commits into from

Conversation

luyahan
Copy link
Contributor

@luyahan luyahan commented Jun 11, 2021

No description provided.

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 11, 2021
@luyahan luyahan changed the title Add riscv into host_arch_cc riscv: Add riscv into host_arch_cc Jun 11, 2021
@luyahan luyahan force-pushed the patch-1 branch 2 times, most recently from 8d10f25 to ac9cf34 Compare June 11, 2021 09:12
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38657/

mhdawson
mhdawson approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38669/

targos pushed a commit that referenced this pull request Jul 11, 2021
@luyahan @targos
build: add riscv into host_arch_cc
1d63897 
PR-URL: #39004
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos
Copy link
Member

targos commented Jul 11, 2021

Landed in 1d63897

@targos targos closed this Jul 11, 2021
targos pushed a commit that referenced this pull request Jul 11, 2021
@luyahan @targos
build: add riscv into host_arch_cc
8381132 
PR-URL: #39004
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos mentioned this pull request Jul 13, 2021
Merged
@qjivy qjivy mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@luyahan @nodejs-github-bot @targos @jasnell @addaleax @richardlau @mhdawson @gengjiawen