Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: assign missing deprecation number #40324

Closed
wants to merge 1 commit into from
Closed

doc: assign missing deprecation number #40324

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 5, 2021

Refs: #36670

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Oct 5, 2021
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Fast-track has been requested by @aduh95. Please 👍 to approve.

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Landed in 20289e9...0d2b6ac

@github-actions github-actions bot closed this Oct 5, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 5, 2021
@targos @nodejs-github-bot
doc: assign missing deprecation number
0d2b6ac 
Refs: #36670

PR-URL: #40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@targos targos deleted the dep-156 branch October 5, 2021 11:27
dr-js pushed a commit to dr-js/node that referenced this pull request Oct 5, 2021
@targos @dr-js
doc: assign missing deprecation number
81eca55 
Refs: nodejs#36670

PR-URL: nodejs#40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos added a commit that referenced this pull request Oct 9, 2021
@targos
doc: assign missing deprecation number
a5a3a93 
Refs: #36670

PR-URL: #40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 12, 2021
@targos @danielleadams
doc: assign missing deprecation number
f848553 
Refs: #36670

PR-URL: #40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
@richardlau richardlau mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @Lxxyx @aduh95 @nodejs-github-bot