Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v16.12.0 proposal #40504

Merged
merged 60 commits into from
Oct 20, 2021
Merged

v16.12.0 proposal #40504

merged 60 commits into from
Oct 20, 2021

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Oct 18, 2021 •
edited
Loading

This is a quick release to clear the 50+ commits that are currently unreleased on v16.x-staging ahead of next week's LTS transition (where traditionally we only flip the LTS bit in those). Originally there was a planned regular 16 release for last week but that didn't happen because of the security releases that week.

This is intended to be the last "current" release of Node.js 16 and we'll expect future changes to 16 to be made under LTS guidelines.

2021-10-20, Version 16.12.0 (Current), @richardlau

Notable Changes

Experimental ESM Loader Hooks API

Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:

  1. resolve: resolve [+ getFormat]
  2. load: getFormat + getSource + transformSource

For consistency, getGlobalPreloadCode has been renamed to globalPreload.

A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.

Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468

Other Notable Changes

  • [8fdabcb918] - deps: upgrade npm to 8.1.0 (npm team) #40463
  • [d1d9f2de30] - doc: deprecate (doc-only) http abort related (dr-js) #36670
  • [4116b6c907] - (SEMVER-MINOR) vm: add support for import assertions in dynamic imports (Antoine du Hamel) #40249

Commits

foxxyz and others added 30 commits October 12, 2021 10:32
@foxxyz @danielleadams
doc: anchor link parity between markdown and html-generated docs
1ef2cf8 
Main changes:

- Replace current HTML anchor generation to match
  header anchor generation in Github markdown.
- Remove unnecessary double namespacing on generated anchors/links (E.G.
  `esm.md#loaders` instead of `esm.md#esm_loaders`).
- Anchors/links are automatically prefixed with their respective modules
  when concatenated for usage in `all.html`.

Benefits:

- All anchor links within and between markdown API docs actually work.
- Adding new anchor links no longer requires contributors to generate
  the HTML docs first to look up the correct anchors.
- Anchors are much shorter.
- All previous anchor links are preserved by generating hidden legacy
  anchors.

PR-URL: #39304
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@JakobJingleheimer @danielleadams
esm: consolidate ESM loader hooks
3743406 
doc: update ESM hook examples

esm: fix unsafe primordial

doc: fix ESM example linting

esm: allow source of type ArrayBuffer

doc: update ESM hook changelog to include resolve format

esm: allow all ArrayBuffers and TypedArrays for load hook source

doc: tidy code & API docs

doc: convert ESM source table header from Title Case to Sentence case

doc: add detailed explanation for getPackageType

esm: add caveat that ESMLoader::import() must NOT be renamed

esm: tidy code declaration of getFormat protocolHandlers

doc: correct ESM doc link (bad conflict resolution)

doc: update ESM hook limitation for CJS

esm: tweak preload description

doc: update ESM getPackageType() example explanation

PR-URL: #37468
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
@GeoffreyBooth @danielleadams
v8: remove --harmony-top-level-await
5f3f3a5 
PR-URL: #40226
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@gc @danielleadams
crypto: remove incorrect constructor invocation
a8926d1 
PR-URL: #40300
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@dr-js @danielleadams
doc: deprecate (doc-only) http abort related
d1d9f2d 
Refs: #36641
Refs: #36617 (comment)

Documentation-only deprecate `.aborted` property and `'abort'`,
`'aborted'` event in `http`, and suggest using the corresponding
Stream API instead.

Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Robert Nagy <ronagy@icloud.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #36670
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos @danielleadams
doc: assign missing deprecation number
f848553 
Refs: #36670

PR-URL: #40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@tniessen @danielleadams
doc: fix typo in ESM example
3b3aaa0 
Refs: #37468

PR-URL: #40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MasonM @danielleadams
doc: fix typo in esm.md
5b074af 
_subpath_ is not defined in this context. This is pretty clearly meant
to be _packageSubpath_, which is the second argument to
`PACKAGE_SELF_RESOLVE`

PR-URL: #40273
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@JakobJingleheimer @danielleadams
doc: correct ESM load hook table header
71a94aa 
`resolve` does not return a `source` property

PR-URL: #40234
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@VoltrexKeyva @danielleadams
dns: refactor and use validators
2d409ed 
The logical NOT operator and validators should be used where
appropriate.

PR-URL: #40022
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@aduh95 @targos
vm: add support for import assertions in dynamic imports
4116b6c 
PR-URL: #40249
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@mhdawson @targos
doc: add link to core promises tracking issue
38d8138 
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40355
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@RaisinTen @targos
dgram: add nread assertion to UDPWrap::OnRecv
7e02124 
This asserts that the number of bytes received by the socket is less
than or equal to the size allocated for the temporary storage.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40295
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@warlock1996 @targos
doc: improve phrasing in fs.md
6c091c7 
PR-URL: #40255
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott @targos
tools: warn about duplicates when generating AUTHORS file
c3a744f 
PR-URL: #40304
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@Trott @targos
meta: use .mailmap to consolidate AUTHORS entries for ide
5668182 
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
a single entry.

PR-URL: #40367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@Trott @targos
doc: format doc/guides using format-md task
fb7afb9 
PR-URL: #40358
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 @targos
test: improve test coverage of fs.ReadStream with FileHandle
13d6a56 
PR-URL: #40018
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@Mesteery @targos
meta: update label-pr-config
7f50313 
PR-URL: #40199
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gdccwxx @targos
test: fix "test/common/debugger" identify async function
d8a36ee 
PR-URL: #40348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@gdccwxx @targos
test: replace .then chains with await
07dae7f 
PR-URL: #40348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Ayase-252 @targos
test: add test for readStream.path when fd is specified
641b1bb 
Refs: #40252 (review)

PR-URL: #40359
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gdccwxx @targos
lib: refactor to use let
168020e 
move variable into each for loop

PR-URL: #40364
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott @targos
meta: consolidate AUTHORS entry for thw0rted
1224817 
Use a .mailmap entry to consolidate the two entries for thw0rted in
AUTHORS into one entry.

PR-URL: #40387
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@zcbenz @targos
build: make scripts in gyp run with right python
2de57ed 
PR-URL: #39730
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen @targos
test: fix typos in whatwg-webstreams explanations
6f6b99c 
PR-URL: #40389
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos
typings: fix declaration of primordials
65b51d0 
PR-URL: #40222
Fixes: #40144
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos
typings: define types for timers binding
c3a7a0b 
PR-URL: #40222
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos
typings: add missing types to options and util bindings
ca9a854 
PR-URL: #40222
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos
typings: define types for os binding
7733b5e 
PR-URL: #40222
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@richardlau
Copy link
Member Author

allowed returning format from either resolve or load hooks.

this is actually not correct: format MUST be returned by a load hook. So perhaps

allowed a returning format hint from resolve hook.

And, not sure if it matters: getGlobalPreloadCode was merely renamed to globalPreload (nothing else about it changed).

What would be really helpful is one or two sentences to go in the Notable changes section that explains why the change is notable for anyone reading the changelog. Otherwise we'll just have the following, which really doesn't suggest "This is a very notable change, as it changes how loader hooks work and deprecates the previous system." (maybe the sentence is "Changes the way loader hooks work and deprecates the previous system."?)

Notable Changes

  • [8fdabcb918] - deps: upgrade npm to 8.1.0 (npm team) #40463
  • [d1d9f2de30] - doc: deprecate (doc-only) http abort related (dr-js) #36670
  • [3743406b0a] - (SEMVER-MINOR) esm: consolidate ESM loader hooks (Jacob Smith) #37468
  • [4116b6c907] - (SEMVER-MINOR) vm: add support for import assertions in dynamic imports (Antoine du Hamel) #40249

@JakobJingleheimer
Copy link
Member

these are coming from the author info in Git

gah, sorry. I dunno how that messed up on my laptop (I just fixed it in my git global config). I'll look into the mailmap this week.

I'll update the changelog here

thank you!

What would be really helpful is one or two sentences to go in the Notable changes section that explains why the change is notable for anyone reading the changelog.

okay! I shall send over this evening.

@JakobJingleheimer
Copy link
Member

How about something like this:

Experimental ESM Loader Hooks API

Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:

  1. resolve: resolve [+ getFormat]
  2. load: getFormat + getSource + transformSource

For consistency, getGlobalPreloadCode has been renamed to globalPreload.

A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.

Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468

shrujalshah28 added a commit to shrujalshah28/ts-node that referenced this pull request Oct 19, 2021
@shrujalshah28
update version checks for v16
b53f1be 
Ref: nodejs/node#40504
shrujalshah28 added a commit to shrujalshah28/ts-node that referenced this pull request Oct 19, 2021
@shrujalshah28
update version checks for v16
bc5cdab 
Ref: nodejs/node#40504
@richardlau
2021-10-20, Version 16.12.0 (Current)
4941550 
Notable Changes:

Experimental ESM Loader Hooks API:

Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:
1. `resolve`: `resolve` [+ `getFormat`]
2. `load`: `getFormat` + `getSource` + `transformSource`

For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`.

A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.

Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468

Other Notable Changes:

deps:
  * upgrade npm to 8.1.0 (npm team) #40463
doc:
  * deprecate (doc-only) http abort related (dr-js) #36670
vm:
  * (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249

PR-URL: #40504
@shrujalshah28 shrujalshah28 mentioned this pull request Oct 19, 2021
Merged
@richardlau
Copy link
Member Author

richardlau commented Oct 19, 2021 •
edited
Loading

I've updated the notable changes PTAL.

I've also bumped the date to tomorrow as it's late here.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 20, 2021
Open
27 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 20, 2021 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40378/ (✔️)
Release build: https://ci-release.nodejs.org/job/iojs+release/8021/

@richardlau richardlau merged commit 4941550 into v16.x Oct 20, 2021
richardlau added a commit that referenced this pull request Oct 20, 2021
@richardlau
Working on v16.12.1
731495d 
PR-URL: #40504
richardlau added a commit that referenced this pull request Oct 20, 2021
@richardlau
2021-10-20, Version 16.12.0 (Current)
7ed303b 
Notable Changes:

Experimental ESM Loader Hooks API:

Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:
1. `resolve`: `resolve` [+ `getFormat`]
2. `load`: `getFormat` + `getSource` + `transformSource`

For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`.

A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.

Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468

Other Notable Changes:

deps:
  * upgrade npm to 8.1.0 (npm team) #40463
doc:
  * deprecate (doc-only) http abort related (dr-js) #36670
vm:
  * (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249

PR-URL: #40504
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Oct 20, 2021
@richardlau
Blog: v16.12.0 release post
b16d6a5 
Refs: nodejs/node#40504
@richardlau richardlau mentioned this pull request Oct 20, 2021
Merged
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Oct 20, 2021
@richardlau
Blog: v16.12.0 release post (#4199)
880f472 
Refs: nodejs/node#40504
@richardlau richardlau deleted the v16.12.0-proposal branch October 20, 2021 15:13
@github-actions github-actions bot mentioned this pull request Oct 21, 2021
Open
30 tasks
cspotcode pushed a commit to TypeStrong/ts-node that referenced this pull request Oct 21, 2021
@shrujalshah28
update version checks for v16 (#1522)
b16134b 
* update version checks for v16

Ref: nodejs/node#40504

* add test to check old ESM Loader Hooks API on v16.11.1

* fix wrong version number
This was referenced Oct 22, 2021
Open
Open
Open
Open
@RaisinTen RaisinTen mentioned this pull request Nov 18, 2021
Closed
@ruzell22 ruzell22 mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@targos targos targos approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.