doc: Remove ESLint disable comments which were breaking the CJS/ESM code block toggles #40408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
aduh95
approved these changes
Oct 11, 2021
aduh95
added
the
author ready
Trott
approved these changes
Oct 12, 2021
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Lxxyx
approved these changes
Oct 12, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 54a85d6...15ce81a |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
PR-URL: #40408 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
PR-URL: #40408 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the code blocks for the assert docs were not properly showing the CJS/ESM toggle which was due to some unnecessary ESLint disable comments. Removing these comments fixed the issue so the code blocks once again work as expected.
See the current docs for an example of the currently broken behavior: https://nodejs.org/docs/latest-v16.x/api/assert.html#assert_assert_doesnotreject_asyncfn_error_message