Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: remove unused variables in AppendExceptionLine #4264

Closed
wants to merge 1 commit into from

Conversation

yorkie
Copy link
Contributor

@yorkie yorkie commented Dec 13, 2015

These variables in node.cc seems not to be used, just help to clean them :-)

@mscdex mscdex added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 13, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Dec 13, 2015

LGTM pending CI

@bnoordhuis
Copy link
Member

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Dec 14, 2015

@jasnell
Copy link
Member

jasnell commented Dec 14, 2015

CI failures are related. Landing

@jasnell
Copy link
Member

jasnell commented Dec 14, 2015

LGTM

jasnell pushed a commit that referenced this pull request Dec 14, 2015
PR-URL: #4264
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 14, 2015

Landed in d3c498b

@jasnell jasnell closed this Dec 14, 2015
@yorkie yorkie deleted the node/clean branch December 15, 2015 17:24
@yorkie
Copy link
Contributor Author

yorkie commented Dec 15, 2015

Thanks :-)

cjihrig pushed a commit that referenced this pull request Dec 15, 2015
PR-URL: #4264
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
MylesBorins pushed a commit that referenced this pull request Dec 30, 2015
PR-URL: #4264
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
PR-URL: #4264
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4264
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants