-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.3.0 Release Proposal (Stable) #4281
Conversation
@Fishrock123 I should be able to work on this tomorrow. Is https://github.com/nodejs/node/blob/master/doc/releases.md still the reference document to use, and is it up to date? It's been a while since I've done a release. |
Not seeing #4215 included in this. |
Line 30 in the changelog? |
@cjihrig yes, I think that doc is still accurate. Jenkins has been solid (iojs+release job), the flow has been working nicely. The additional part that's not documented is creating a website post. The easiest way to do that is to wait until you've competed everything else and have promoted the build then run https://github.com/nodejs/nodejs.org/blob/master/scripts/release-post.js to make the post in that repo, it'll use the promoted builds and changelog to build the post and it should be good to go unless you want to make some notes in there. Run Also, look at the v5.2.0 tag and changelog entry for the current format, we're putting "(Stable)" in there now, just copy all that. I'll be around in your afternoon if you need any help. |
@cjihrig There are slightly updated notes here: #3254 In specific, can you make sure to not land #3567, even though it is |
Some tips I'm not sure are mentioned:
Once you have everything else done, to make the commit list for the blog / make doing the changelog easier: |
Notable changes: * domains: - Fix handling of uncaught exceptions. (Julien Gilli) #3654. * https: - Added support for disabling session caching. (Fedor Indutny) #4252. * repl: - Allow third party modules to be imported using require(). This corrects a regression from 5.2.0. (Ben Noordhuis) #4215. * deps: - Upgrade libuv to 1.8.0. (Saúl Ibarra Corretgé) #4276. PR-URL: #4281
I wonder if it might better to hold off on the release because of #4297 |
@rvagg and @Fishrock123 thanks for the pointers. We should probably work to consolidate the content in |
@Fishrock123 That's an additive change, so should be fine to land. |
protip for |
I'd like to move on with the release. But I'd like some confirmation that:
|
@cjihrig Seems fine to me. |
Notable changes: * buffer: - Buffer.prototype.includes() has been added to keep parity with TypedArrays. (Alexander Martin) #3567. * domains: - Fix handling of uncaught exceptions. (Julien Gilli) #3654. * https: - Added support for disabling session caching. (Fedor Indutny) #4252. * repl: - Allow third party modules to be imported using require(). This corrects a regression from 5.2.0. (Ben Noordhuis) #4215. * deps: - Upgrade libuv to 1.8.0. (Saúl Ibarra Corretgé) #4276. PR-URL: #4281
Notable changes: * buffer: - Buffer.prototype.includes() has been added to keep parity with TypedArrays. (Alexander Martin) #3567. * domains: - Fix handling of uncaught exceptions. (Julien Gilli) #3654. * https: - Added support for disabling session caching. (Fedor Indutny) #4252. * repl: - Allow third party modules to be imported using require(). This corrects a regression from 5.2.0. (Ben Noordhuis) #4215. * deps: - Upgrade libuv to 1.8.0. (Saúl Ibarra Corretgé) #4276. PR-URL: #4281 Conflicts: src/node_version.h
Release is done. |
Related: nodejs/node#4281 PR-URL: nodejs#79 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Related: nodejs/node#4281 Related: nodejs/docker-node#79 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Related: nodejs/node#4281 Related: nodejs/docker-node#79 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Related: nodejs/node#4281 Related: nodejs/docker-node#79 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Notable changes: * buffer: - Buffer.prototype.includes() has been added to keep parity with TypedArrays. (Alexander Martin) nodejs#3567. * domains: - Fix handling of uncaught exceptions. (Julien Gilli) nodejs#3654. * https: - Added support for disabling session caching. (Fedor Indutny) nodejs#4252. * repl: - Allow third party modules to be imported using require(). This corrects a regression from 5.2.0. (Ben Noordhuis) nodejs#4215. * deps: - Upgrade libuv to 1.8.0. (Saúl Ibarra Corretgé) nodejs#4276. PR-URL: nodejs#4281 Conflicts: src/node_version.h
Related: nodejs/node#4281 Related: nodejs/docker-node#79 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
The usual weekly-ish.
I think this would be a minor but I didn't check too in detail.
I'll be out tomorrow, so If someone else from @nodejs/release (@cjihrig maybe?) wants to take this up, I've created the PR base as https://github.com/nodejs/node/tree/propose-v5.3.0
Edited from here down by @cjihrig
6ca5ea3860
] - 2015-12-09, Version 5.2.0 (Stable) (Rod Vagg) #4181da5cdc2207
] - assert: accommodate ES6 classes that extend Error (Rich Trott) #416667e181986a
] - (SEMVER-MINOR) buffer: add includes() for parity with TypedArray (Alexander Martin) #356784dea1bd0c
] - configure: fix arm vfpv2 (Jörg Krause) #4203a7f5dfd14c
] - configure: use __ARM_ARCH to determine arm version (João Reis) #41230e3912be0b
] - configure: respect CC_host in host arch detection (João Reis) #411769b94ec55c
] - deps: upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) #4276a8854e5b59
] - doc: document the cache parameter for fs.realpathSync (Jackson Tian) #42859e1b7aa874
] - doc: document backlog for server.listen() variants (Jan Schär) #4025435d571f22
] - doc: update AUTHORS list (Rod Vagg) #41833b3061365a
] - doc: update irc channels: #node.js and #node-dev (Nelson Pecora) #27439538fd02e5
] - doc: clarify error events in HTTP module documentation (Lenny Markus) #4275c6efd535e4
] - doc: fix improper http.get sample code (Hideki Yamamura) #4263498c9adb08
] - doc: add CTC meeting minutes 2015-10-28 (Rod Vagg) #3661671347cf13
] - doc: fixup socket.remoteAddress (Arthur Gautier) #4198f050cab3d8
] - doc: copyedit console doc (Rich Trott) #42251a21a5368b
] - doc: move description of 'equals' method to right place (janriemer) #42279a9c5259bf
] - doc: Fixing broken links to the v8 wiki (Tom Gallacher) #424137ed05b8c1
] - doc: copyedit child_process doc (Rich Trott) #4188e47ae5808b
] - doc: copyedit buffer doc (Rich Trott) #418770fb06a90b
] - doc: clarify assert.fail doc (Rich Trott) #4186e3187cc81e
] - doc: copyedit addons doc (Rich Trott) #4185931ab967ff
] - doc: add calvinmetcalf to collaborators (Calvin Metcalf) #421801ce23148b
] - doc: add mcollina to collaborators (Matteo Collina) #4220bd8753aabf
] - doc: add rmg to collaborators (Ryan Graham) #421973a9a6fc92
] - doc: harmonize description ofca
argument (Ben Noordhuis) #4213dfc8bedbc5
] - doc: change references from node to Node.js (Roman Klauke) #41777a518788e9
] - doc, test: symbols as event names (Bryan English) #4151425a3545d2
] - (SEMVER-MINOR) domains: fix handling of uncaught exceptions (Julien Gilli) #3654acef181fde
] - (SEMVER-MINOR) https: support disabling session caching (Fedor Indutny) #42522a60e2ad71
] - module,src: do not wrap modules with -1 lineOffset (cjihrig) #4298d3c498b1b7
] - node: remove unused variables in AppendExceptionLine (Yazhong Liu) #4264aad6b9f0eb
] - repl: display error message when loading directory (Prince J Wesley) #4170213ede6cee
] - repl: fix require('3rdparty') regression (Ben Noordhuis) #4215f176b31e74
] - src: remove __builtin_bswap16 call (Ben Noordhuis) #4290ce2471673f
] - src: remove unused BITS_PER_LONG macro (Ben Noordhuis) #4290b799a74709
] - src: fix line numbers on core errors (cjihrig) #4254c311b61430
] - src: fix deprecation message for ErrnoException (Martin von Gagern) #42692859f9ef92
] - test: fix debug-port-cluster flakiness (Ben Noordhuis) #4310cb0b4a6bc0
] - test: add test for debugging one line files (cjihrig) #42980b9c3a30d6
] - test: add test for tls.parseCertString (Evan Lucas) #42837598ed6cc0
] - test: parallelize test-repl-persistent-history (Jeremiah Senkpiel) #4247668449ad14
] - test: use regular timeout times for ARMv8 (Jeremiah Senkpiel) #424823e7703c85
] - test: fix http-many-ended-pipelines flakiness (Santiago Gimeno) #40413b94991bda
] - test: fix tls-inception flakiness (Santiago Gimeno) #419586a3bd09b0
] - test: fix tls-inception (Santiago Gimeno) #41951e89830a11
] - test: don't assume openssl s_client supports -ssl3 (Ben Noordhuis) #4204c5b4f6bc99
] - (SEMVER-MINOR) tls: introducesecureContext
fortls.connect
(Fedor Indutny) #4246e0bb118a1d
] - tls_wrap: inherit from theAsyncWrap
first (Fedor Indutny) #4268d63cceeb10
] - tools: add .editorconfig (ronkorving) #29934b267df93e
] - udp: remove a needless instanceof Buffer check (ronkorving) #4301