src: remove __builtin_bswap16 call #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is fine. LGTM. |
Fishrock123
added
c++
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: nodejs#4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Not supported by apple-gcc and I'm not convinced it's worth adding more preprocessor hacks when it should be easy as pie for the compiler to to optimize the byteswap. If it doesn't, fix the compiler. Fixes: nodejs#4284 PR-URL: nodejs#4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
@bnoordhuis should this be backported to LTS? or is this making changes to stuff that never made it to 4.x |
|
@Fishrock123 we should add this to #4281 |
|
@thealphanerd Added lts-watch-v4.x label. Didn't see it in v4.x but it's still in v4.x-staging. |
|
Awesome thanks! I wonder if there is a smart way we can modify the meta data of commits landed on LTS to specify that other commits must land with them. I'm going to mull on this and likely open an issue about it if I can think of a solution |
bnoordhuis
added a commit
that referenced
this pull request
Dec 15, 2015
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: #4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
|
#3410 will have to land into LTS before this commit can |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: #4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: #4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: #4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: nodejs#4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Not supported by apple-gcc and I'm not convinced it's worth adding more preprocessor hacks when it should be easy as pie for the compiler to to optimize the byteswap. If it doesn't, fix the compiler. Fixes: nodejs#4284 PR-URL: nodejs#4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Jul 11, 2016
Said builtins are not supported by older versions of apple-gcc, breaking the build on OS X 10.8. Fixes: nodejs#7618 Refs: nodejs#4290 Refs: nodejs#7157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not supported by apple-gcc and I'm not convinced it's worth adding more
preprocessor hacks when it should be easy as pie for the compiler to
to optimize the byteswap. If it doesn't, fix the compiler.
Fixes: #4284
CI: https://ci.nodejs.org/job/node-test-pull-request/1002/