Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 8.10.0 #43061

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 8.10.0 #43061

wants to merge 1 commit into from

Conversation

npm-cli-bot
Copy link
Contributor

v8.10.0 (2022-05-11)

Features

Bug Fixes

Dependencies

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels May 11, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
tniessen
tniessen approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 16, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43061
✔  Done loading data for nodejs/node/pull/43061
----------------------------------- PR info ------------------------------------
Title      deps: upgrade npm to 8.10.0 (#43061)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     npm-cli-bot:npm-8.10.0 -> nodejs:master
Labels     npm, fast-track, needs-ci, dont-land-on-v14.x
Commits    1
 - deps: upgrade npm to 8.10.0
Committers 1
 - npm-cli+bot@github.com 
PR-URL: https://github.com/nodejs/node/pull/43061
Reviewed-By: Ruy Adorno 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43061
Reviewed-By: Ruy Adorno 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 11 May 2022 17:17:21 GMT
   ✔  Approvals: 4
   ✔  - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/43061#pullrequestreview-969793434
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43061#pullrequestreview-969847804
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43061#pullrequestreview-969897537
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43061#pullrequestreview-970082411
   ℹ  This PR is being fast-tracked
   ⚠  GitHub cannot link the author of 'deps: upgrade npm to 8.10.0' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-05-11T18:16:38Z: https://ci.nodejs.org/job/node-test-pull-request/43962/
- Querying data for job/node-test-pull-request/43962/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2334046116

@sepehrst
Copy link

This needs a rebase. As well as almost every other non doc: PR which are not based on top of 347000c (prior to the landing time of #43085 @ May 15, 2022, 5:05 AM UTC)

@ruyadorno
Copy link
Member

Thanks @wraithgar!

@wraithgar
Copy link

I clicked the button in the github ui so it did a merge commit, not a rebase. idk if that matters here but now you know.

@ruyadorno
Copy link
Member

I'm not sure this will work 🤔 I'll go ahead and rebase the commit to be sure 😊

@ruyadorno ruyadorno added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen tniessen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 17, 2022
@github-actions github-actions bot mentioned this pull request May 18, 2022
Open
28 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44067/

@ruyadorno ruyadorno added the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43061
✔  Done loading data for nodejs/node/pull/43061
----------------------------------- PR info ------------------------------------
Title      deps: upgrade npm to 8.10.0 (#43061)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     npm-cli-bot:npm-8.10.0 -> nodejs:master
Labels     npm, fast-track, needs-ci, dont-land-on-v14.x
Commits    1
 - deps: upgrade npm to 8.10.0
Committers 1
 - Ruy Adorno 
PR-URL: https://github.com/nodejs/node/pull/43061
Reviewed-By: Ruy Adorno 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43061
Reviewed-By: Ruy Adorno 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - deps: upgrade npm to 8.10.0
   ℹ  This PR was created on Wed, 11 May 2022 17:17:21 GMT
   ✔  Approvals: 4
   ✔  - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/43061#pullrequestreview-969793434
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43061#pullrequestreview-969847804
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43061#pullrequestreview-969897537
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43061#pullrequestreview-970082411
   ℹ  This PR is being fast-tracked
   ⚠  GitHub cannot link the author of 'deps: upgrade npm to 8.10.0' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-05-18T14:21:53Z: https://ci.nodejs.org/job/node-test-pull-request/44067/
- Querying data for job/node-test-pull-request/44067/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2346657102

@lpinca
Copy link
Member

lpinca commented May 18, 2022

Landed in 06dd8c3.

lpinca pushed a commit that referenced this pull request May 18, 2022
@lpinca
deps: upgrade npm to 8.10.0
06dd8c3 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@lpinca lpinca closed this May 18, 2022
This was referenced May 19, 2022
Open
Open
Open
Open
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request May 27, 2022
@ruyadorno
deps: upgrade npm to 8.10.0
d0b53c0 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
bengl pushed a commit that referenced this pull request May 30, 2022
@bengl
deps: upgrade npm to 8.10.0
d42de13 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@ruyadorno ruyadorno mentioned this pull request May 30, 2022
Merged
@bengl bengl mentioned this pull request May 31, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@juanarbol
deps: upgrade npm to 8.10.0
e69fc6f 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
juanarbol pushed a commit that referenced this pull request Jun 1, 2022
@juanarbol
deps: upgrade npm to 8.10.0
68572bd 
PR-URL: #43061
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@juanarbol juanarbol mentioned this pull request Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@npm-cli-bot @nodejs-github-bot @sepehrst @ruyadorno @wraithgar @lpinca @tniessen @VoltrexKeyva @targos @richardlau