Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consolidate bugs, docs, repo command logic #4857

Merged
merged 1 commit into from
May 9, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented May 4, 2022

All three of these commands do the same thing: open a manifest and find
a url inside to open it. The finding of that manifest was not very
consistent across these three commands. Some work with workspaces while
others don't. Some work correctly with --prefix while others don't.

This PR consolidates these commands so that they all are consistent in
how they find the manifest being referenced. The specifics of which url
they open are still left to each command. The util that only these
three commands were using was consolidated into their base class.

@wraithgar wraithgar requested a review from a team as a code owner May 4, 2022 18:51
@npm-robot
Copy link
Contributor

npm-robot commented May 4, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 51.123 ±6.02 28.063 ±0.12 16.012 ±0.02 18.271 ±0.91 2.604 ±0.03 2.558 ±0.04 2.049 ±0.02 10.446 ±0.05 2.012 ±0.02 2.993 ±0.10
#4857 47.446 ±2.47 28.246 ±0.09 15.817 ±0.11 18.969 ±0.65 2.578 ±0.01 2.573 ±0.04 2.052 ±0.03 10.766 ±0.02 2.058 ±0.02 3.206 ±0.22
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.934 ±2.37 21.460 ±0.15 11.568 ±0.12 12.565 ±0.00 2.333 ±0.01 2.334 ±0.00 2.068 ±0.01 7.662 ±0.17 1.895 ±0.02 2.629 ±0.03
#4857 35.150 ±0.85 21.850 ±0.37 11.587 ±0.07 12.569 ±0.16 2.340 ±0.05 2.360 ±0.00 2.060 ±0.05 7.675 ±0.12 1.923 ±0.02 2.729 ±0.07

All three of these commands do the same thing: open a manifest and find
a url inside to open it.  The finding of that manifest was not very
consistent across these three commands. Some work with workspaces while
others don't. Some work correctly with `--prefix` while others don't.

This PR consolidates these commands so that they all are consistent in
how they find the manifest being referenced.  The specifics of which url
they open are still left to each command.  The util that only these
three commands were using was consolidated into their base class.
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 consistency! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants