Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: consolidate environment cleanup queue #44379

Closed
wants to merge 1 commit into from
Closed

src: consolidate environment cleanup queue #44379

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.

Moves the implementations of the cleanup queue to its own class so that
it can be used in node::Realm too.

Refs: #44348
Refs: #42528

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2022 •
edited by legendecas
Loading

Review requested:

  • @nodejs/gyp
  • @nodejs/startup

@legendecas legendecas force-pushed the shadow-realm/cleanup-callbacks branch from 885ed6c to d0e5fe4 Compare August 24, 2022 18:02
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 24, 2022
@legendecas legendecas mentioned this pull request Aug 25, 2022
Closed
@legendecas legendecas force-pushed the shadow-realm/cleanup-callbacks branch from d0e5fe4 to b712fb6 Compare August 28, 2022 17:26
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46303/

joyeecheung
joyeecheung reviewed Aug 30, 2022
View reviewed changes
src/cleanup_queue.h Outdated Show resolved Hide resolved
src/cleanup_queue-inl.h Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Aug 31, 2022
Open
30 tasks
@legendecas legendecas force-pushed the shadow-realm/cleanup-callbacks branch from b712fb6 to 0e48bdf Compare August 31, 2022 16:30
This was referenced Sep 1, 2022
Open
Open
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46383/

This was referenced Sep 3, 2022
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46418/

@legendecas
src: consolidate environment cleanup queue
60e285a 
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.

Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.
@legendecas legendecas force-pushed the shadow-realm/cleanup-callbacks branch from 0e48bdf to 60e285a Compare September 5, 2022 16:06
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
Open
17 tasks
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46435/

@github-actions github-actions bot mentioned this pull request Sep 7, 2022
Open
15 tasks
@legendecas
Copy link
Member Author

Landed in 0b5b5ed. Thank you for the review!

@legendecas legendecas closed this Sep 7, 2022
legendecas added a commit that referenced this pull request Sep 7, 2022
@legendecas
src: consolidate environment cleanup queue
0b5b5ed 
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.

Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.

PR-URL: #44379
Refs: #44348
Refs: #42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@legendecas legendecas deleted the shadow-realm/cleanup-callbacks branch September 7, 2022 16:07
@legendecas legendecas mentioned this pull request Sep 7, 2022
Closed
@github-actions github-actions bot mentioned this pull request Sep 8, 2022
Open
12 tasks
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@legendecas @Fyko
src: consolidate environment cleanup queue
d1f6237 
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.

Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.

PR-URL: nodejs#44379
Refs: nodejs#44348
Refs: nodejs#42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
@legendecas @RafaelGSS
src: consolidate environment cleanup queue
e8101af 
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.

Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.

PR-URL: #44379
Refs: #44348
Refs: #42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 26, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
@legendecas @RafaelGSS
src: consolidate environment cleanup queue
03913a9 
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.

Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.

PR-URL: #44379
Refs: #44348
Refs: #42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
@legendecas @RafaelGSS
src: consolidate environment cleanup queue
6878448 
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.

Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.

PR-URL: #44379
Refs: #44348
Refs: #42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@legendecas legendecas added the realm Issues and PRs related to the ShadowRealm API and node::Realm label Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. realm Issues and PRs related to the ShadowRealm API and node::Realm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendecas @nodejs-github-bot @joyeecheung