Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.10.0 proposal #44799

Merged
merged 106 commits into from
Sep 28, 2022
Merged

v18.10.0 proposal #44799

merged 106 commits into from
Sep 28, 2022

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Sep 26, 2022

2022-09-27, Version 18.10.0 (Current), @RafaelGSS

Notable changes

doc:

gyp:

http:

stream:

Commits

Commits
  • [6a2f1988a2] - benchmark: fix startup benchmark (Evan Lucas) #44727
  • [54870ea603] - benchmark: add stream destroy benchmark (SindreXie) #44533
  • [143abcb9ac] - bootstrap: clean up inspector console methods during serialization (Joyee Cheung) #44279
  • [4ce6e2196c] - bootstrap: remove unused global parameter in per-context scripts (Joyee Cheung) #44472
  • [2799157766] - build: remove redundant entry in crypto (Jiawen Geng) #44604
  • [5c69813006] - build: rewritten the Android build system (BuShe Pie) #44207
  • [3b808634a3] - Revert "build: go faster, drop -fno-omit-frame-pointer" (Ben Noordhuis) #44566
  • [1315a83333] - build: fix bad upstream merge (Stephen Gallagher) #44642
  • [4700ee5fc0] - (SEMVER-MINOR) cli: add --watch (Moshe Atlow) #44366
  • [5eb48b66ea] - cluster: use inspector utils (Moshe Atlow) #44592
  • [26f25c9c80] - crypto: restrict PBKDF2 args to signed int (Tobias Nießen) #44575
  • [934cc9af11] - deps: update to ngtcp2 0.8.1 and nghttp3 0.7.0 (Tobias Nießen) #44622
  • [7571c3a1a4] - deps: update corepack to 0.14.1 (Node.js GitHub Bot) #44704
  • [bc9403f4cd] - deps: update ngtcp2 update instructions (Tobias Nießen) #44619
  • [a1ed4fa601] - deps: upgrade npm to 8.19.2 (npm team) #44632
  • [f07d095928] - deps: update to uvwasi 0.0.13 (Colin Ihrig) #44524
  • [7e0b9e150b] - dns: remove unnecessary parameter from validateOneOf (Yagiz Nizipli) #44635
  • [0f232e9749] - dns: refactor default resolver (Joyee Cheung) #44541
  • [8247d93b9c] - doc: mention git node backport (RafaelGSS) #44764
  • [8b5333932d] - doc: ensure to revert node_version changes (Rafael Gonzaga) #44760
  • [dc7d90494d] - doc: fix description for napi_get_cb_info() in n-api.md (Daeyeon Jeong) #44761
  • [2dab3bd020] - doc: update the deprecation for exit code to clarify its scope (Daeyeon Jeong) #44714
  • [2f99461152] - doc: update guidance for adding new modules (Michael Dawson) #44576
  • [e353bf7116] - doc: add registry number for Electron 22 (Keeley Hammond) #44748
  • [d537b61b5e] - doc: include code examples for webstreams consumers (Lucas Santos) #44387
  • [faa40c39af] - doc: mention where to push security commits (RafaelGSS) #44691
  • [48b1ad4059] - doc: remove extra space on threadpool usage (Connor Burton) #44734
  • [51f026a0d0] - doc: make legacy banner slightly less bright (Rich Trott) #44665
  • [31c19e3ef5] - doc: improve building doc for Windows Powershell (Brian Muenzenmeyer) #44625
  • [3777582b64] - doc: maintain only one list of MODP groups (Tobias Nießen) #44644
  • [d9cdc392cf] - doc: add legendecas to TSC list (Michael Dawson) #44662
  • [fca3ee4eff] - doc: remove comma in README.md (Taha-Chaudhry) #44599
  • [3214715df0] - doc: use serial comma in report docs (Daeyeon Jeong) #44608
  • [073f11eb24] - doc: use serial comma in stream docs (Daeyeon Jeong) #44609
  • [054b1d92cf] - doc: remove empty line in YAML block (Claudio Wunder) #44617
  • [70ccc5ea1f] - (SEMVER-MINOR) doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588
  • [1c83824b01] - doc: remove old OpenSSL ENGINE constants (Tobias Nießen) #44589
  • [c76d182578] - doc: fix heading levels for test runner hooks (Fabian Meyer) #44603
  • [4d6b46ea80] - doc: fix errors in http.md (Luigi Pinca) #44587
  • [10891e637f] - doc: fix vm.Script createCachedData example (Chengzhong Wu) #44487
  • [793855702d] - doc: mention how to get commit release (Rafael Gonzaga) #44572
  • [f47f1d518a] - doc: fix link in process.md (Antoine du Hamel) #44594
  • [eaa675d8b5] - doc: do not use weak MODP group in example (Tobias Nießen) #44585
  • [84934137ce] - doc: remove ebpf from supported tooling list (Rafael Gonzaga) #44549
  • [8752854258] - doc: emphasize that createCipher is never secure (Tobias Nießen) #44538
  • [07af3f0f43] - doc: document attribute Script.cachedDataRejected (Chengzhong Wu) #44451
  • [59e3601ef3] - doc: move policy docs to the permissions scope (Rafael Gonzaga) #44222
  • [629324052e] - doc,crypto: cleanup removed pbkdf2 behaviours (Filip Skokan) #44733
  • [7ffc037d63] - doc,inspector: document changes of inspector.close (Chengzhong Wu) #44628
  • [8b54f01c52] - esm,loader: tidy ESMLoader internals (Jacob Smith) #44701
  • [ce085d753f] - fs: fix typo in mkdir example (SergeyTsukanov) #44791
  • [0ccc17295e] - fs: remove unused option in fs.fstatSync() (Livia Medeiros) #44613
  • [bbccebf451] - gyp: libnode for ios app embedding (chexiongsheng) #44210
  • [aaee9b1f1d] - (SEMVER-MINOR) http: throw error on content-length mismatch (sidwebworks) #44378
  • [8b256a303a] - inspector: expose inspector.close on workers (Chengzhong Wu) #44489
  • [29e3e2c227] - lib: don't match sourceMappingURL in strings (Alan Agius) #44658
  • [1e137c2859] - lib: fix reference leak (falsandtru) #44499
  • [687ffcc3ce] - lib: reset RegExp statics before running user code (Antoine du Hamel) #44247
  • [9a432148a4] - lib,test: fix bug in InternalSocketAddress (Tobias Nießen) #44618
  • [2a37f74e34] - meta: update AUTHORS (Node.js GitHub Bot) #44777
  • [dffc204959] - meta: add mailmap entry for dnlup (Rich Trott) #44716
  • [45b3bf3587] - meta: update AUTHORS (Node.js GitHub Bot) #44705
  • [8e954fa843] - meta: move dnlup to emeriti (dnlup) #44667
  • [4b0697e34c] - meta: update test_runner in label-pr-config (Shrujal Shah) #44615
  • [c0f5adc1ca] - meta: update AUTHORS (Node.js GitHub Bot) #44591
  • [ab5a304c67] - module: open stat/readPackage to mutations (Maël Nison) #44537
  • [b63315d140] - module: exports & imports map invalid slash deprecation (Guy Bedford) #44477
  • [ed1d634297] - node-api: add deprecation code of uncaught exception (Chengzhong Wu) #44624
  • [7d9de70f4a] - src: avoid using v8 on Isolate termination (Santiago Gimeno) #44669
  • [15be38e98c] - src: remove <unistd.h> from node_os.cc (Tobias Nießen) #44668
  • [8de484963d] - src: avoid copy when creating Blob (Tobias Nießen) #44616
  • [f4b620f83c] - src: make ReqWrap weak (Rafael Gonzaga) #44074
  • [99ad732f5b] - src: make NearHeapLimitCallback() more robust (Joyee Cheung) #44581
  • [bf77161c48] - src: dump isolate stats when process exits (daomingq) #44534
  • [e8101af459] - src: consolidate environment cleanup queue (Chengzhong Wu) #44379
  • [ce719290de] - stream: handle a pending pull request from a released reader (Daeyeon Jeong) #44702
  • [457673b0ac] - stream: refactor use es2020 statement (SindreXie) #44533
  • [00185f170a] - stream: remove abortReason from WritableStreamDefaultController (Daeyeon Jeong) #44540
  • [4a77a11270] - (SEMVER-MINOR) stream: add ReadableByteStream.tee() (Daeyeon Jeong) #44505
  • [9f755e1d88] - stream: fix writableStream.abort() (Daeyeon Jeong) #44327
  • [3474cd870f] - test: verify napi_remove_wrap with napi_delete_reference (Chengzhong Wu) #44754
  • [fa315b7a5a] - test: change promises to async/await (Madhulika Sharma) #44683
  • [0f8ce84005] - test: use async/await in test-debugger-invalid-args (Nupur Chauhan) #44678
  • [1172498a82] - test: update test-debugger-low-level to use await/async (Meghana Ramesh) #44688
  • [16f85cc82f] - test: fix watch mode test flake (Moshe Atlow) #44739
  • [7ed87538c3] - test: check that sysconf returns a positive value (Tobias Nießen) #44666
  • [dda556d002] - test: change promise to async/await in debugger-watcher (“Pooja) #44687
  • [8acb425de1] - test: fix addon tests compilation with OpenSSL 1.1.1 (Adam Majer) #44725
  • [6606a111bd] - test: deflake watch mode tests (Moshe Atlow) #44621
  • [792040269a] - test: fix test-performance-measure (smitley) #44637
  • [fcfdb6c31e] - test: improve lib/readline.js coverage (MURAKAMI Masahiko) #42686
  • [2618ccb8f8] - test: fix test-repl not validating leaked globals properly (Antoine du Hamel) #44640
  • [938751be43] - test: fix test-runner-inspect (Moshe Atlow) #44620
  • [353cd846e6] - test: ignore stale process cleanup failures on Windows (Joyee Cheung) #44480
  • [35f55ae6bb] - test: use python3 instead of python (Luigi Pinca) #44545
  • [90a98a657a] - test: split watch mode inspector tests to sequential (Moshe Atlow) #44551
  • [1b2b0a318a] - test: fix DebugSymbolsTest.ReqWrapList on PPC64LE (Daniel Bevenius) #44341
  • [ed64119ca8] - test: add more cases for parse-encoding (Tony Gorez) #44427
  • [a28ae1656f] - test_runner: include stack of uncaught exceptions (Moshe Atlow) #44614
  • [603eb54743] - test_runner: support using --inspect with --test (Moshe Atlow) #44520
  • [42225c38a4] - tls: fix out-of-bounds read in ClientHelloParser (Tobias Nießen) #44580
  • [2dbc1f8b15] - tools: add update-llhttp.sh (Paolo Insogna) #44652
  • [2ad225787f] - tools: fix typo in update-nghttp2.sh (Luigi Pinca) #44664
  • [2e77644d6b] - tools: add timezone update workflow (Lenvin Gonsalves) #43988
  • [bdea068dc9] - tools: update eslint to 8.23.1 (Node.js GitHub Bot) #44639
  • [efbd18a51b] - tools: update lint-md-dependencies to @rollup/plugin-node-resolve@14.1.0 (Node.js GitHub Bot) #44638
  • [d31ea02a01] - tools: update gyp-next to v0.13.0 (Jiawen Geng) #44605
  • [570b099a83] - tools: update lint-md-dependencies to @rollup/plugin-node-resolve@14.0.1 (Node.js GitHub Bot) #44590
  • [730b8ce059] - tools: increase timeout of running WPT (Joyee Cheung) #44574
  • [d265bf04f8] - tools: fix shebang to use python3 by default (Himself65) #44531
  • [90e8977a2f] - v8: add setHeapSnapshotNearHeapLimit (theanarkh) #44420
  • [2d87b6ffa0] - win: fix fs.realpath.native for long paths (StefanStojanovic) #44536

The upstream merge of e27e709d3c
accidentally removed code related to systemtap and dtrace.

Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
PR-URL: #44642
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. dont-land-on-v14.x meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 26, 2022
@RafaelGSS RafaelGSS added release Issues and PRs related to Node.js releases. and removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. dependencies Pull requests that update a dependency file. dont-land-on-v14.x labels Sep 26, 2022
@nodejs-github-bot

This comment was marked as outdated.

aduh95 and others added 9 commits September 26, 2022 16:13
Fixes: #43740

Backport-PR-URL: #43741
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #44247
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This includes:

- Fixing `writableStream.abort(reason)`. Passing the reason was missing.

- Leaving a TODO to remove the internal abortReason property of
  WritableStreamDefaultController.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44327
Refs: https://streams.spec.whatwg.org/#writable-stream-abort
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #44222
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #44427
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Currently, DebugSymbolsTest.ReqWrapList fails on PPC64LE when Node has
been configured with Link Time Optimization (LTO) and using RHEL 8.5
and gcc:
```console
$ . /opt/rh/gcc-toolset-11/enable
$ export CC='ccache gcc'
$ export CXX='ccache g++'
$ ./configure --enable-lto
$ make -j8 cctest
...
21:52:27 [ RUN      ] DebugSymbolsTest.ReqWrapList
21:52:27 ../test/cctest/test_node_postmortem_metadata.cc:203: Failure
21:52:27 Expected equality of these values:
21:52:27   expected
21:52:27     Which is: 140736537072320
21:52:27   calculated
21:52:27     Which is: 1099680328560
21:52:27 [  FAILED  ] DebugSymbolsTest.ReqWrapList (43 ms)
```

After looking into this is seems that the compiler is tampering with the
`last` variable when compiling with LTO enabled. This commit suggests
adding volatile to this variable to prevent the compiler from tampering
with it.

PR-URL: #44341
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #44472
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Explicitly document the attribute `Script.cachedDataRejected` in a
dedicated section.

Removes the documented option `produceCachedData` and the description
of `cachedDataRejected` in `vm.runInContext`, `vm.runInNewContext`,
and `vm.runInThisContext` as the created `vm.Script` instance is not
accessible from userland in these methods.

PR-URL: #44451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Notable changes:

- A bug has been fixed in `uvwasi_fd_readdir()` that caused
  the number of entries to be processed incorrectly.

PR-URL: #44524
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #44499
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
RafaelGSS added a commit that referenced this pull request Sep 27, 2022
Notable changes:

doc:
  * (SEMVER-MINOR) deprecate modp1, modp2, and modp5 groups (Tobias Nießen) <#44588>
gyp:
  * libnode for ios app embedding (chexiongsheng) <#44210>
http:
  * (SEMVER-MINOR) throw error on content-length mismatch (sidwebworks) (<#44378>)
stream:
  * (SEMVER-MINOR) add `ReadableByteStream.tee()` (Daeyeon Jeong) (<#44505>)

PR-URL: #44799
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@RafaelGSS
Copy link
Member Author

@nodejs/build looks like our machines are running out of space. Could you help me with that? ref: https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1015/47624/testReport/junit/(root)/test/pummel_test_fs_largefile/

Notable changes:

doc:
  * (SEMVER-MINOR) deprecate modp1, modp2, and modp5 groups (Tobias Nießen) <#44588>
gyp:
  * libnode for ios app embedding (chexiongsheng) <#44210>
http:
  * (SEMVER-MINOR) throw error on content-length mismatch (sidwebworks) (<#44378>)
stream:
  * (SEMVER-MINOR) add `ReadableByteStream.tee()` (Daeyeon Jeong) (<#44505>)

PR-URL: #44799
@RafaelGSS
Copy link
Member Author

FYI @nodejs/releasers I'm postponing the release to tomorrow due to #44799 (comment).

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2022

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2022

@RafaelGSS RafaelGSS merged commit bdf069b into v18.x Sep 28, 2022
@RafaelGSS RafaelGSS deleted the v18.10.0-proposal branch September 28, 2022 17:32
RafaelGSS added a commit that referenced this pull request Sep 28, 2022
RafaelGSS added a commit that referenced this pull request Sep 28, 2022
Notable changes:

doc:
  * (SEMVER-MINOR) deprecate modp1, modp2, and modp5 groups (Tobias Nießen) <#44588>
gyp:
  * libnode for ios app embedding (chexiongsheng) <#44210>
http:
  * (SEMVER-MINOR) throw error on content-length mismatch (sidwebworks) (<#44378>)
stream:
  * (SEMVER-MINOR) add `ReadableByteStream.tee()` (Daeyeon Jeong) (<#44505>)

PR-URL: #44799
RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Sep 28, 2022
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.