v18.10.0 proposal

.github/label-pr-config.yml

@@ -102,6 +102,7 @@ subSystemLabels:
   /^lib\/internal\/url\.js$/: whatwg-url
   /^lib\/internal\/modules\/esm/: esm
   /^lib\/internal\/webstreams/: web streams
+  /^lib\/internal\/test_runner/: dont-land-on-v14.x
 
   # All other lib/ files map directly
   /^lib\/_(\w+)_\w+\.js?$/: $1  # e.g. _(stream)_wrap

.github/workflows/timezone-update.yml

@@ -0,0 +1,48 @@
+name: Timezone update
+on:
+  schedule:
+    # Run once a week at 00:05 AM UTC on Sunday.
+    - cron: 5 0 * * 0
+
+  workflow_dispatch:
+
+jobs:
+  timezone_update:
+    if: github.repository == 'nodejs/node'
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout nodejs/node
+        uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+
+      - name: Checkout unicode-org/icu-data
+        uses: actions/checkout@v3
+        with:
+          path: icu-data
+          persist-credentials: false
+          repository: unicode-org/icu-data
+
+      - run: ./tools/update-timezone.mjs
+
+      - name: Open Pull Request
+        uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f  # Create a PR or update the Action's existing PR
+        env:
+          GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
+        with:
+          author: Node.js GitHub Bot <github-bot@iojs.org>
+          body: |
+            This PR was generated by tools/timezone-update.yml.
+
+            Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data
+
+            To test, build node off this branch & log the version of tz using
+            ```js
+            console.log(process.versions.tz)
+            ```
+          branch: actions/timezone-update
+          commit-message: 'deps: update timezone'
+          labels: dependencies
+          title: 'deps: update timezone'
+          reviewers: \@nodejs/i18n-api

.mailmap

@@ -137,6 +137,7 @@ David Mark Clements <david.clements@nearform.com> <huperekchuno@googlemail.com>
 David Siegel <david@artcom.de> <david.siegel@artcom.de>
 DC <dcposch@dcpos.ch>
 Deepjyoti Mondal <djmdeveloper060796@gmail.com>
+dnlup <dnlup.dev@gmail.com> <dwon.dnl@gmail.com>
 Domenic Denicola <domenic@domenicdenicola.com>
 Domenic Denicola <domenic@domenicdenicola.com> <d@domenic.me>
 Doug Wade <doug@dougwade.io> <doug.wade@redfin.com>
@@ -200,7 +201,6 @@ Hannes Magnusson <hannes.magnusson@gmail.com> <hannes.magnusson@creditkarma.com>
 Hassaan Pasha <pasha.hassaan@gmail.com> <hassaan.pasha@teamo.io>
 Hendrik Schwalm <mail@hendrikschwalm.de>
 Henry Chin <hheennrryy@gmail.com>
-Nick Sia <nicholas.sia@vgw.co> <31839263+nicksia-vgw@users.noreply.github.com>
 Herbert Vojčík <herby@mailbox.sk>
 Hitesh Kanwathirtha <hiteshk@microsoft.com> <digitalinfinity@gmail.com>
 Icer Liang <liangshuangde@163.com> <wizicer@users.noreply.github.com>
@@ -374,6 +374,7 @@ Nam Nguyen <nam.nguyen@de.ibm.com>
 Nebu Pookins <nebu@nebupookins.net>
 Netto Farah <nettofarah@gmail.com>
 Nicholas Kinsey <pyrotechnick@feistystudios.com>
+Nick Sia <nicholas.sia@vgw.co> <31839263+nicksia-vgw@users.noreply.github.com>
 Nick Soggin <nicksoggin@gmail.com> <iSkore@users.noreply.github.com>
 Nigel Kibodeaux <nigelmail@gmail.com> <nigel@team.about.me>
 Nikola Glavina <glavina.nikola5@gmail.com> <nikola.glavina@student.um.si>

AUTHORS

@@ -2694,7 +2694,7 @@ Yann Hamon <yann.hamon@contentful.com>
 Ben Swinburne <ben.swinburne@gmail.com>
 Colin Prince <col@colinprince.com>
 TJKoury <TJKoury@gmail.com>
-dnlup <dwon.dnl@gmail.com>
+dnlup <dnlup.dev@gmail.com>
 Hang Jiang <jianghangscu@gmail.com>
 Vladislav Kaminsky <wlodzislav@outlook.com>
 Daiki Ihara <sasurau4@gmail.com>
@@ -3514,5 +3514,19 @@ Jeff Dickey <216188+jdxcode@users.noreply.github.com>
 Matías Zúñiga <matias.nicolas.zc@gmail.com>
 metonym <ericyl.us@gmail.com>
 Brian Evans <53117772+mrbrianevans@users.noreply.github.com>
+falsandtru <falsandtru@users.noreply.github.com>
+东灯 <43312495+Lampese@users.noreply.github.com>
+Fabian Meyer <3982806+meyfa@users.noreply.github.com>
+StefanStojanovic <StefanStojanovic@users.noreply.github.com>
+Claudio Wunder <cwunder@gnome.org>
+Shrujal Shah <shrujalshah@hotmail.com>
+Taha-Chaudhry <46199675+Taha-Chaudhry@users.noreply.github.com>
+smitley <brandon.smitley@gmail.com>
+Brian Muenzenmeyer <Brian.Muenzenmeyer@target.com>
+sidwebworks <xodedeveloper@gmail.com>
+Connor Burton <me@connorburton.com>
+chexiongsheng <chexiongsheng@qq.com>
+Lucas Santos <lhs.santoss@gmail.com>
+“Pooja <pakcutie14@gmail.com>
 
 # Generated by tools/update-authors.mjs

BUILDING.md

@@ -621,6 +621,7 @@ Set-ExecutionPolicy Unrestricted -Force
 iex ((New-Object System.Net.WebClient).DownloadString('https://boxstarter.org/bootstrapper.ps1'))
 get-boxstarter -Force
 Install-BoxstarterPackage https://raw.githubusercontent.com/nodejs/node/HEAD/tools/bootstrap/windows_boxstarter -DisableReboots
+refreshenv
 ```
 
 The entire installation using Boxstarter will take up approximately 10 GB of

CHANGELOG.md

@@ -35,7 +35,8 @@ release.
 </tr>
 <tr>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V18.md#18.9.1">18.9.1</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V18.md#18.10.0">18.10.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V18.md#18.9.1">18.9.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.9.0">18.9.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.8.0">18.8.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.7.0">18.7.0</a><br/>

README.md

@@ -1,6 +1,6 @@
 # Node.js
 
-Node.js is an open-source, cross-platform, JavaScript runtime environment.
+Node.js is an open-source, cross-platform JavaScript runtime environment.
 
 For information on using Node.js, see the [Node.js website][].
 
@@ -178,6 +178,8 @@ For information about the governance of the Node.js project, see
   **James M Snell** <<jasnell@gmail.com>> (he/him)
 * [joyeecheung](https://github.com/joyeecheung) -
   **Joyee Cheung** <<joyeec9h3@gmail.com>> (she/her)
+* [legendecas](https://github.com/legendecas) -
+  **Chengzhong Wu** <<legendecas@gmail.com>> (he/him)
 * [mcollina](https://github.com/mcollina) -
   **Matteo Collina** <<matteo.collina@gmail.com>> (he/him)
 * [mhdawson](https://github.com/mhdawson) -
@@ -310,8 +312,6 @@ For information about the governance of the Node.js project, see
   **Gus Caplan** <<me@gus.host>> (they/them)
 * [dmabupt](https://github.com/dmabupt) -
   **Xu Meng** <<dmabupt@gmail.com>> (he/him)
-* [dnlup](https://github.com/dnlup)
-  **Daniele Belardi** <<dwon.dnl@gmail.com>> (he/him)
 * [edsadr](https://github.com/edsadr) -
   **Adrian Estrada** <<edsadr@gmail.com>> (he/him)
 * [erickwendel](https://github.com/erickwendel) -
@@ -494,6 +494,8 @@ For information about the governance of the Node.js project, see
   **Jamie Davis** <<davisjam@vt.edu>> (he/him)
 * [digitalinfinity](https://github.com/digitalinfinity) -
   **Hitesh Kanwathirtha** <<digitalinfinity@gmail.com>> (he/him)
+* [dnlup](https://github.com/dnlup)
+  **dnlup** <<dnlup.dev@gmail.com>>
 * [eljefedelrodeodeljefe](https://github.com/eljefedelrodeodeljefe) -
   **Robert Jefe Lindstaedt** <<robert.lindstaedt@gmail.com>>
 * [estliberitas](https://github.com/estliberitas) -

android-configure

@@ -1,83 +1,35 @@
-#!/bin/bash
-
-# In order to cross-compile node for Android using NDK, run:
-#   source android-configure <path_to_ndk> [arch]
-#
-# By running android-configure with source, will allow environment variables to
-# be persistent in current session. This is useful for installing native node
-# modules with npm. Also, don't forget to set the arch in npm config using
-# 'npm config set arch=<arch>'
-
-if [ $# -ne 3 ]; then
-  echo "$0 should have 3 parameters: ndk_path, target_arch and sdk_version"
-  return 1
-fi
-
-NDK_PATH=$1
-ARCH="$2"
-ANDROID_SDK_VERSION=$3
-
-if [ $ANDROID_SDK_VERSION -lt 24 ]; then
-  echo "$ANDROID_SDK_VERSION should equal or later than 24 (Android 7.0)"
-fi
-
-case $ARCH in
-    arm)
-        DEST_CPU="arm"
-        TOOLCHAIN_NAME="armv7a-linux-androideabi"
-        ;;
-    x86)
-        DEST_CPU="ia32"
-        TOOLCHAIN_NAME="i686-linux-android"
-        ;;
-    x86_64)
-        DEST_CPU="x64"
-        TOOLCHAIN_NAME="x86_64-linux-android"
-        ARCH="x64"
-        ;;
-    arm64|aarch64)
-        DEST_CPU="arm64"
-        TOOLCHAIN_NAME="aarch64-linux-android"
-        ARCH="arm64"
-        ;;
-    *)
-        echo "Unsupported architecture provided: $ARCH"
-        return 1
-        ;;
-esac
-
-HOST_OS="linux"
-HOST_ARCH="x86_64"
-export CC_host=$(command -v gcc)
-export CXX_host=$(command -v g++)
-
-host_gcc_version=$($CC_host --version | grep gcc | awk '{print $NF}')
-major=$(echo $host_gcc_version | awk -F . '{print $1}')
-minor=$(echo $host_gcc_version | awk -F . '{print $2}')
-if [ -z $major ] || [ -z $minor ] || [ $major -lt 6 ] || ( [ $major -eq 6 ] && [ $minor -lt 3 ] ); then
-  echo "host gcc $host_gcc_version is too old, need gcc 6.3.0"
-  return 1
-fi
-
-SUFFIX="$TOOLCHAIN_NAME$ANDROID_SDK_VERSION"
-TOOLCHAIN=$NDK_PATH/toolchains/llvm/prebuilt/$HOST_OS-$HOST_ARCH
-
-export PATH=$TOOLCHAIN/bin:$PATH
-export CC=$TOOLCHAIN/bin/$SUFFIX-clang
-export CXX=$TOOLCHAIN/bin/$SUFFIX-clang++
-
-
-GYP_DEFINES="target_arch=$ARCH"
-GYP_DEFINES+=" v8_target_arch=$ARCH"
-GYP_DEFINES+=" android_target_arch=$ARCH"
-GYP_DEFINES+=" host_os=$HOST_OS OS=android"
-export GYP_DEFINES
-
-if [ -f "configure" ]; then
-    ./configure \
-        --dest-cpu=$DEST_CPU \
-        --dest-os=android \
-        --without-snapshot \
-        --openssl-no-asm \
-        --cross-compiling
-fi
+#!/bin/sh
+
+# Locate an acceptable Python interpreter and then re-execute the script.
+# Note that the mix of single and double quotes is intentional,
+# as is the fact that the ] goes on a new line.
+_=[ 'exec' '/bin/sh' '-c' '''
+command -v python3.10 >/dev/null && exec python3.10 "$0" "$@"
+command -v python3.9 >/dev/null && exec python3.9 "$0" "$@"
+command -v python3.8 >/dev/null && exec python3.8 "$0" "$@"
+command -v python3.7 >/dev/null && exec python3.7 "$0" "$@"
+command -v python3.6 >/dev/null && exec python3.6 "$0" "$@"
+command -v python3 >/dev/null && exec python3 "$0" "$@"
+exec python "$0" "$@"
+''' "$0" "$@"
+]
+del _
+
+import sys
+try:
+  from shutil import which
+except ImportError:
+  from distutils.spawn import find_executable as which
+
+print('Node.js android configure: Found Python {}.{}.{}...'.format(*sys.version_info))
+acceptable_pythons = ((3, 10), (3, 9), (3, 8), (3, 7), (3, 6))
+if sys.version_info[:2] in acceptable_pythons:
+  import android_configure
+else:
+  python_cmds = ['python{}.{}'.format(*vers) for vers in acceptable_pythons]
+  sys.stderr.write('Please use {}.\n'.format(' or '.join(python_cmds)))
+  for python_cmd in python_cmds:
+      python_cmd_path = which(python_cmd)
+      if python_cmd_path and 'pyenv/shims' not in python_cmd_path:
+        sys.stderr.write('\t{} {}\n'.format(python_cmd_path, ' '.join(sys.argv[:1])))
+  sys.exit(1)

android-patches/trap-handler.h.patch

@@ -0,0 +1,26 @@
+--- trap-handler.h	2022-08-11 09:01:23.384000000 +0800
++++ fixed-trap-handler.h	2022-08-11 09:09:15.352000000 +0800
+@@ -17,23 +17,7 @@
+ namespace internal {
+ namespace trap_handler {
+
+-// X64 on Linux, Windows, MacOS, FreeBSD.
+-#if V8_HOST_ARCH_X64 && V8_TARGET_ARCH_X64 &&                        \
+-    ((V8_OS_LINUX && !V8_OS_ANDROID) || V8_OS_WIN || V8_OS_DARWIN || \
+-     V8_OS_FREEBSD)
+-#define V8_TRAP_HANDLER_SUPPORTED true
+-// Arm64 (non-simulator) on Mac.
+-#elif V8_TARGET_ARCH_ARM64 && V8_HOST_ARCH_ARM64 && V8_OS_DARWIN
+-#define V8_TRAP_HANDLER_SUPPORTED true
+-// Arm64 simulator on x64 on Linux, Mac, or Windows.
+-#elif V8_TARGET_ARCH_ARM64 && V8_HOST_ARCH_X64 && \
+-    (V8_OS_LINUX || V8_OS_DARWIN)
+-#define V8_TRAP_HANDLER_VIA_SIMULATOR
+-#define V8_TRAP_HANDLER_SUPPORTED true
+-// Everything else is unsupported.
+-#else
+ #define V8_TRAP_HANDLER_SUPPORTED false
+-#endif
+
+ // Setup for shared library export.
+ #if defined(BUILDING_V8_SHARED) && defined(V8_OS_WIN)

android_configure.py

@@ -0,0 +1,76 @@
+import platform
+import sys
+import os
+
+# TODO: In next version, it will be a JSON file listing all the patches, and then it will iterate through to apply them.
+def patch_android():
+    print("- Patches List -")
+    print("[1] [deps/v8/src/trap-handler/trap-handler.h] related to https://github.com/nodejs/node/issues/36287")
+    if platform.system() == "Linux":
+        os.system('patch -f ./deps/v8/src/trap-handler/trap-handler.h < ./android-patches/trap-handler.h.patch')
+    print("\033[92mInfo: \033[0m" + "Tried to patch.")
+
+if platform.system() == "Windows":
+    print("android-configure is not supported on Windows yet.")
+    sys.exit(1)
+
+if len(sys.argv) == 2 and sys.argv[1] == "patch":
+    patch_android()
+    sys.exit(0)
+
+if len(sys.argv) != 4:
+    print("Usage: ./android-configure [patch] <path to the Android NDK> <Android SDK version> <target architecture>")
+    sys.exit(1)
+
+if not os.path.exists(sys.argv[1]) or not os.listdir(sys.argv[1]):
+    print("\033[91mError: \033[0m" + "Invalid path to the Android NDK")
+    sys.exit(1)
+
+if int(sys.argv[2]) < 24:
+    print("\033[91mError: \033[0m" + "Android SDK version must be at least 24 (Android 7.0)")
+    sys.exit(1)
+
+android_ndk_path = sys.argv[1]
+android_sdk_version = sys.argv[2]
+arch = sys.argv[3]
+
+if arch == "arm":
+    DEST_CPU = "arm"
+    TOOLCHAIN_PREFIX = "armv7a-linux-androideabi"
+elif arch in ("aarch64", "arm64"):
+    DEST_CPU = "arm64"
+    TOOLCHAIN_PREFIX = "aarch64-linux-android"
+    arch = "arm64"
+elif arch == "x86":
+    DEST_CPU = "ia32"
+    TOOLCHAIN_PREFIX = "i686-linux-android"
+elif arch == "x86_64":
+    DEST_CPU = "x64"
+    TOOLCHAIN_PREFIX = "x86_64-linux-android"
+    arch = "x64"
+else:
+    print("\033[91mError: \033[0m" + "Invalid target architecture, must be one of: arm, arm64, aarch64, x86, x86_64")
+    sys.exit(1)
+
+print("\033[92mInfo: \033[0m" + "Configuring for " + DEST_CPU + "...")
+
+if platform.system() == "Darwin":
+    host_os = "darwin"
+    toolchain_path = android_ndk_path + "/toolchains/llvm/prebuilt/darwin-x86_64"
+
+elif platform.system() == "Linux":
+    host_os = "linux"
+    toolchain_path = android_ndk_path + "/toolchains/llvm/prebuilt/linux-x86_64"
+
+os.environ['PATH'] += os.pathsep + toolchain_path + "/bin"
+os.environ['CC'] = toolchain_path + "/bin/" + TOOLCHAIN_PREFIX + android_sdk_version + "-" +  "clang"
+os.environ['CXX'] = toolchain_path + "/bin/" + TOOLCHAIN_PREFIX + android_sdk_version + "-" + "clang++"
+
+GYP_DEFINES = "target_arch=" + arch
+GYP_DEFINES += " v8_target_arch=" + arch
+GYP_DEFINES += " android_target_arch=" + arch
+GYP_DEFINES += " host_os=" + host_os + " OS=android"
+os.environ['GYP_DEFINES'] = GYP_DEFINES
+
+if os.path.exists("./configure"):
+    os.system("./configure --dest-cpu=" + DEST_CPU + " --dest-os=android --openssl-no-asm --cross-compiling")

benchmark/fixtures/require-cachable.js

@@ -2,8 +2,8 @@
 
 const { internalBinding } = require('internal/test/binding');
 const {
-  moduleCategories: { canBeRequired }
-} = internalBinding('native_module');
+  builtinCategories: { canBeRequired }
+} = internalBinding('builtins');
 
 for (const key of canBeRequired) {
   require(`node:${key}`);