feat(I18n): MSI installer French #46024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
install
abenhamdine
suggested changes
Dec 31, 2022
|
I had read the microsoft docs normally it's working. So if you can explain why it's ins't use |
|
I mentioned that in #45090 (comment) but tl;dr it's never been enabled / never worked. |
|
I understand what you are saying. But the question is why because I read a big part of the microsoft docs and normally it is supposed to work |
|
The version of WiX (installer tool) we used at the time only supported English and German. Before you ask, I don't know what it supports now. :-) At any rate, more work is needed to actually make this PR work. You can reverse-engineer it from #45138. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translation of MSI installer into French.