Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add tip for session.post function #46354

Merged
merged 1 commit into from
Jan 29, 2023
Merged

doc: add tip for session.post function #46354

merged 1 commit into from
Jan 29, 2023

Conversation

theanarkh
Copy link
Contributor

Do not set reportProgress to true when post HeapProfiler.takeHeapSnapshot or HeapProfiler.stopTrackingHeapObjects command to V8.

cc @bnoordhuis
Refs: #44634

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels Jan 26, 2023
@theanarkh theanarkh force-pushed the add_tips_for_post_function_in_inspector branch from 64c8567 to 7f5d20d Compare January 26, 2023 02:38
bnoordhuis
bnoordhuis reviewed Jan 26, 2023
View reviewed changes
doc/api/inspector.md Outdated Show resolved Hide resolved
@theanarkh theanarkh force-pushed the add_tips_for_post_function_in_inspector branch from 7f5d20d to 82d992f Compare January 26, 2023 18:03
@theanarkh theanarkh force-pushed the add_tips_for_post_function_in_inspector branch from 82d992f to 5d90855 Compare January 26, 2023 18:04
@theanarkh theanarkh added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 27, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @theanarkh. Please 👍 to approve.

@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46354
✔  Done loading data for nodejs/node/pull/46354
----------------------------------- PR info ------------------------------------
Title      doc: add tip for session.post function (#46354)
Author     theanarkh  (@theanarkh)
Branch     theanarkh:add_tips_for_post_function_in_inspector -> nodejs:main
Labels     doc, inspector, fast-track
Commits    1
 - doc: add tip for session.post function
Committers 1
 - theanarkh 
PR-URL: https://github.com/nodejs/node/pull/46354
Refs: https://github.com/nodejs/node/issues/44634
Reviewed-By: Ben Noordhuis 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46354
Refs: https://github.com/nodejs/node/issues/44634
Reviewed-By: Ben Noordhuis 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 26 Jan 2023 02:36:59 GMT
   ✔  Approvals: 2
   ✔  - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/46354#pullrequestreview-1272345252
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46354#pullrequestreview-1273384786
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4029815905

@theanarkh theanarkh added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 29, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46354
✔  Done loading data for nodejs/node/pull/46354
----------------------------------- PR info ------------------------------------
Title      doc: add tip for session.post function (#46354)
Author     theanarkh  (@theanarkh)
Branch     theanarkh:add_tips_for_post_function_in_inspector -> nodejs:main
Labels     doc, inspector, fast-track
Commits    1
 - doc: add tip for session.post function
Committers 1
 - theanarkh 
PR-URL: https://github.com/nodejs/node/pull/46354
Refs: https://github.com/nodejs/node/issues/44634
Reviewed-By: Ben Noordhuis 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46354
Refs: https://github.com/nodejs/node/issues/44634
Reviewed-By: Ben Noordhuis 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 26 Jan 2023 02:36:59 GMT
   ✔  Approvals: 2
   ✔  - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/46354#pullrequestreview-1272345252
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46354#pullrequestreview-1273384786
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4034813395

@theanarkh theanarkh added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0a46107 into nodejs:main Jan 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 0a46107

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@theanarkh @ruyadorno
doc: add tip for session.post function
968db21 
PR-URL: #46354
Refs: #44634
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@theanarkh @juanarbol
doc: add tip for session.post function
4663ff7 
PR-URL: #46354
Refs: #44634
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@theanarkh @juanarbol
doc: add tip for session.post function
c35a7c2 
PR-URL: #46354
Refs: #44634
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@theanarkh @juanarbol
doc: add tip for session.post function
129dccf 
PR-URL: #46354
Refs: #44634
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theanarkh @nodejs-github-bot @bnoordhuis @lpinca